Loading...

XML

Word

Printable

Type: Improvement
Resolution: Unresolved
Priority: Minor
Fix Version/s: None
Affects Version/s: Future Dev
Component/s: Performance
Labels:
- CatalystIT
- ci
- hqteam_hedgehog
- partner
- partner-eummena
- triaged

Pull from Repository:
https://github.com/brendanheywood/moodle
Pull Main Branch:
MDL-85235-web-manifest
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...brendanheywood:moodle:MDL-85235-web-manifest
Testing Instructions:
Hide

In chrome open dev tools > network, and add the column for Set-Cookies

As an admin turn on the config for:
enablemobilewebservice
enablesmartappbanners

Load any page in chrome

Confirm that the web manifest is loaded

Confirm that no cookies headers are set on the response

Confirm that public + 1 hour expires headers are set

Reload the page

Confirm the manifest is loaded from the local browser disk cache
Show
In chrome open dev tools > network, and add the column for Set-Cookies As an admin turn on the config for: enablemobilewebservice enablesmartappbanners Load any page in chrome Confirm that the web manifest is loaded Confirm that no cookies headers are set on the response Confirm that public + 1 hour expires headers are set Reload the page Confirm the manifest is loaded from the local browser disk cache
Pre-check results:
Hide

Code verified against automated checks with warnings.

Checked MDL-85235 using repository: https://github.com/brendanheywood/moodle

main (0 errors / 1 warnings) [branch: MDL-85235-web-manifest | CI Job]

overview (0/1), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

Warn: The MDL-85235-web-manifest branch at https://github.com/brendanheywood/moodle has not been rebased recently (>20 days ago).

Should these errors be fixed?

Built on: Thu May 8 02:56:15 UTC 2025
Show
Code verified against automated checks with warnings. Checked MDL-85235 using repository: https://github.com/brendanheywood/moodle main (0 errors / 1 warnings) [branch: MDL-85235-web-manifest | CI Job ] overview (0/1) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Warn: The MDL-85235 -web-manifest branch at https://github.com/brendanheywood/moodle has not been rebased recently (>20 days ago). Should these errors be fixed? Built on: Thu May 8 02:56:15 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch MDL-85235-web-manifest

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19217/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65705/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65706/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65707/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65708/ App tests (stable app version)

Built on: Thu May 8 04:25:46 UTC 2025
Show
Launching automatic jobs for branch MDL-85235 -web-manifest https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19217/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65705/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65706/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65707/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65708/ App tests (stable app version) Built on: Thu May 8 04:25:46 UTC 2025

Was just trawling the logs for some sites and noticed that this page was one of the most requested urls which seemed very weird and so did a bit of digging. It was being loaded on every single page for every single person and basically adds nothing of value to the UX unless you happen to then bookmark the page and then it check this metadata for the offline experience, even though moodle doesn't even support offline web stuff. So it's just wasted cpu cycles.

In chrome open dev tools > network, and add the column for Set-Cookies
Turn on the config for:
enablemobilewebservice
enablesmartappbanners
Load any page in chrome
Note that the web manifest is reloaded on every page view, ie its not cached even though it is essentially static or extremely slow moving data
Note that the request has fresh new session cookies sent on every request

Assignee:: Brendan Heywood

Reporter:: Brendan Heywood

Peer reviewer:: Tomo Tsuyuki

Participants:: Brendan Heywood, CiBoT, Tomo Tsuyuki

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Created:: 17/Apr/25 8:54 PM

Updated:: 13/Jun/25 4:05 PM

Details

Description

Attachments

Activity

People

Dates

Clockify