Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-85225

Message emoji picker fails when show template information is enabled.

XMLWordPrintable

    • MOODLE_500_STABLE
    • MOODLE_501_STABLE
    • MDL-85225-main
    • Hide
      1. Open the message drawer and clean the browser console
      2. Then click on a conversation (could be the one that is automatically created to yourself)
        1. Check that no errors appear in the console.
      3. Click the emoji picker and pick one emoji
        1. Check that the emoji is inserted in the message field.
      4. Go to "site administration -> development -> debugging" and enable "Show template information"
      5. Go to the dashboard and open the browser console (F12 in Chrome).
      6. Again, open the message drawer and clean the browser console
      7. Then click on a conversation
        1. Check that no errors appear in the console.
      8. Click the emoji picker and pick one emoji
        1. Check that the emoji is inserted in the message field.
      Show
      Open the message drawer and clean the browser console Then click on a conversation (could be the one that is automatically created to yourself) Check that no errors appear in the console. Click the emoji picker and pick one emoji Check that the emoji is inserted in the message field. Go to "site administration -> development -> debugging" and enable "Show template information" Go to the dashboard and open the browser console (F12 in Chrome). Again, open the message drawer and clean the browser console Then click on a conversation Check that no errors appear in the console. Click the emoji picker and pick one emoji Check that the emoji is inserted in the message field.
    • Hide

      Code verified against automated checks.

      Checked MDL-85225 using repository: https://github.com/ferranrecio/moodle.git

      More information about this report

      Built on: Wed Apr 16 15:28:30 UTC 2025

      Show
      Code verified against automated checks. Checked MDL-85225 using repository: https://github.com/ferranrecio/moodle.git main (0 errors / 0 warnings) [branch: MDL-85225-main | CI Job ] More information about this report Built on: Wed Apr 16 15:28:30 UTC 2025
    • Hide

      Launching automatic jobs for branch MDL-85225-main

      Built on: Wed Apr 16 16:25:17 UTC 2025

      Show
      Launching automatic jobs for branch MDL-85225 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19048/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65133/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65134/ Behat (Firefox - boost) --> unrelated (can be ignored) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65135/ Behat (Firefox - classic) --> unrelated (can be ignored) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65136/ App tests (stable app version) --> unrelated (can be ignored) Built on: Wed Apr 16 16:25:17 UTC 2025
    • 1
    • HQ 2025 Sprint I1.4 Moppies

      The lib/amd/src/emoji/picker.js module throws an error when the developer setting "Show template information" is enabled.

      The explanation is straightforward: in both createHeaderRow and createEmojiRow, after loading the template, "firstChild" is utilised instead of "firstElementChild". Consequently, it refers to the template comment rather than the template's first element node.

      Typically, it's understood that displaying template information may disrupt certain Javascript modules. In this instance, though, the theme might override the emoji template, which means the module unnecessarily depends on the template structure. Implementing this minor adjustment will enhance the module's stability.

        1. MDL-85225.png
          MDL-85225.png
          686 kB

            tusefomal Ferran Recio
            tusefomal Ferran Recio
            Amaia Anabitarte Amaia Anabitarte
            David Woloszyn David Woloszyn
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours
                2h

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.