Loading...

XML

Word

Printable

Type: Bug
Resolution: Unresolved
Priority: Minor
Fix Version/s: None
Affects Version/s: 4.5.4, 5.0
Component/s: Report builder
Labels:

Affected Branches:
MOODLE_405_STABLE, MOODLE_500_STABLE
Epic Link:
Report builder performance
Pull from Repository:
https://github.com/paulholden/moodle.git
Pull 4.5 Branch:
MDL-85223-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...paulholden:MDL-85223-405
Pull 5.0 Branch:
MDL-85223-500
Pull 5.0 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_500_STABLE...paulholden:MDL-85223-500
Pull Main Branch:
MDL-85223
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...paulholden:MDL-85223
Testing Instructions:
Hide

Log in as admin

Navigate to Users > Accounts > User profile fields in site administration

Create a new profile field

Navigate to Reports in user menu

Create new report from User source

In report editor, confirm the following are available as both filter and condition:

User > Picture

User > [Your profile field]
Show
Log in as admin Navigate to Users > Accounts > User profile fields in site administration Create a new profile field Navigate to Reports in user menu Create new report from User source In report editor, confirm the following are available as both filter and condition: User > Picture User > [Your profile field]
Pre-check results:
Hide

Code verified against automated checks.

Checked MDL-85223 using repository: https://github.com/paulholden/moodle.git

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-85223-405 | CI Job]

MOODLE_500_STABLE (0 errors / 0 warnings) [branch: MDL-85223-500 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-85223 | CI Job]

_{More information about this report}

Built on: Thu May 29 14:43:22 UTC 2025
Show
Code verified against automated checks. Checked MDL-85223 using repository: https://github.com/paulholden/moodle.git MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-85223-405 | CI Job ] MOODLE_500_STABLE (0 errors / 0 warnings) [branch: MDL-85223-500 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-85223 | CI Job ] More information about this report Built on: Thu May 29 14:43:22 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch MDL-85223-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19634/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67128/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67129/ Behat (Firefox - boost)

Launching automatic jobs for branch MDL-85223-500

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19635/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67130/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67131/ Behat (Firefox - boost)

Launching automatic jobs for branch MDL-85223

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19636/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67132/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67133/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67134/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67135/ App tests (stable app version)

Built on: Tue Jun 10 04:30:23 UTC 2025
Show
Launching automatic jobs for branch MDL-85223 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19634/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67128/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67129/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-85223 -500 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19635/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67130/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67131/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-85223 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19636/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67132/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67133/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67134/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67135/ App tests (stable app version) Built on: Tue Jun 10 04:30:23 UTC 2025

Story Points:
1
Sprint:
WP Sprint 2025-I2.2 (Espresso)

This is rather inefficient: https://github.com/moodle/moodle/blob/bf164840d9236c36057334d99482d50784f11b26/reportbuilder/classes/local/entities/user.php#L90-L99 because it's requesting all filters from both itself and the user profile fields helper multiple times

Use the fluid interface pattern we use in all other entities: https://github.com/moodle/moodle/blob/bf164840d9236c36057334d99482d50784f11b26/reportbuilder/classes/local/entities/course.php#L97-L104 to ensure we only generate all filter instances once within the user entity

This improves performance, so adding to MDL-84719 epic

Assignee:: Paul Holden

Reporter:: Paul Holden

Peer reviewer:: Ilya Tregubov

Participants:: Ilya Tregubov, Paul Holden

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Created:: 16/Apr/25 4:38 PM

Updated:: 10/Jun/25 12:30 PM

Estimated:

Not Specified

Remaining:

Logged:

Details

Description

Attachments

Activity

People

Dates

Time Tracking

Clockify