Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-85216

Allow add pix icon as part of the report action tag

XMLWordPrintable

    • MOODLE_501_STABLE
    • MOODLE_501_STABLE
    • Hide

      Setup

      1. Manually apply the following change: 

        $ git diff
        		 
        diff --git a/admin/user.php b/admin/user.php
        		 
        index 7ac5ba013bf..62a0372f3f2 100644
        		 
        --- a/admin/user.php
        		 
        +++ b/admin/user.php
        		 
        @@ -175,6 +175,7 @@
        		 
                     get_string('addnewuser', 'moodle'),
        		 
                     ['class' => 'btn btn-primary ms-auto', 'data-action' => 'add-user', 'href' => (string) $url],
        		 
                     'a',
        		 
        +            new \pix_icon('t/add', ''),
        		 
                 ));
        		 
             }

      Test

      1. Log in as admin
      2. Navigate to Users > Accounts > Browse list of users in site administration
      3. Confirm the Add a new user button text is preceded by a "+" icon
      Show
      Setup Manually apply the following change: $ git diff diff --git a/admin/user.php b/admin/user.php index 7ac5ba013bf..62a0372f3f2 100644 --- a/admin/user.php +++ b/admin/user.php @@ -175,6 +175,7 @@ get_string('addnewuser', 'moodle'), ['class' => 'btn btn-primary ms-auto', 'data-action' => 'add-user', 'href' => (string) $url], 'a', + new \pix_icon('t/add', ''), )); } Test Log in as admin Navigate to Users > Accounts > Browse list of users in site administration Confirm the Add a new user button text is preceded by a " + " icon
    • Hide

      Code verified against automated checks.

      Checked MDL-85216 using repository: https://github.com/paulholden/moodle/

      More information about this report

      Built on: Thu Apr 17 09:46:22 UTC 2025

      Show
      Code verified against automated checks. Checked MDL-85216 using repository: https://github.com/paulholden/moodle/ main (0 errors / 0 warnings) [branch: MDL-85216 | CI Job ] More information about this report Built on: Thu Apr 17 09:46:22 UTC 2025
    • 1
    • WP Sprint 2025-I2.1 (Clones)

      As part of WP-5423 we need to add icons to the exported report action using the new API (set_report_action), but this can't be achieved since there aren't allowed to render pix_icon instance or RAW data as part of the title, so let's fix this with the most suitable/solid implementation.

        1. MDL-85216.png
          195 kB
          Ron Carl Alfon Yu

            pholden Paul Holden
            carlos.castillo@moodle.com Carlos Castillo
            Carlos Castillo Carlos Castillo
            Laurent David Laurent David
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 24 minutes
                1h 24m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.