Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-85202

Update upgrade_stale_php_files_present() before 5.0 release

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Fixed
    • Icon: Critical Critical
    • 5.0.1
    • 5.0
    • Installation
    • MOODLE_500_STABLE
    • MOODLE_500_STABLE
    • MDL-85202-500
    • Hide

      Note: TARGET for this issue are:

      1. main
      2. MOODLE_500_STABLE

      Web

      1. Create/check out a 4.5.x site. For example:

        $ git checkout v4.5.3
        

      2. Install the site.
      3. Check out the TARGET branch

        git checkout TARGET 

      4. Apply the patch if you're not on the integration.git
      5. Create any of the following files that are being detected by the patch. (e.g. on Linux, use the "touch" command):
        • admin/process_email.php

          $ touch admin/process_email.php
          

        • badges/preferences_form.php

          $ touch badges/preferences_form.php
          

        • etc
      6. Open your Moodle instance on your browser.
      7. Log in as admin and proceed with the upgrade.
      8. Confirm that a message ("Mixed Moodle versions detected....") is displayed saying that there are problems upgrading and a proper procedure for upgrading to a major release.
      9. Delete the touched file(s) in point 5.
      10. Click Reload
      11. Confirm that the upgrade now proceeds OK

      CLI

      1. Repeat points 1-5 from the "Web" instructions.
      2. Run the CLI upgrade

        $ php admin/cli/upgrade.php
        

      3. Confirm that a message ("Mixed Moodle versions detected....") is displayed saying that there are problems upgrading and a proper procedure for upgrading to a major release.
      4. Delete the touched file(s) in point web - 5.
      5. Run the CLI upgrade again

        $ php admin/cli/upgrade.php
        

      6. Confirm that now the process runs OK, with a prompt asking you for confirmation and then a number of upgrade steps and settings being setup.
      7. Confirm that the process ends with a text like this (the numbers are not important), the "successfully" is.:

        Command line upgrade from XXXXX (Build: XXXXX) (XXXXX) to XXXXX (Build: XXXXX) (XXXXX) completed successfully.

      Show
      Note: TARGET for this issue are: main MOODLE_500_STABLE Web Create/check out a 4.5.x site. For example: $ git checkout v4.5.3 Install the site. Check out the TARGET branch git checkout TARGET Apply the patch if you're not on the integration.git Create any of the following files that are being detected by the patch. (e.g. on Linux, use the " touch " command): admin/process_email.php $ touch admin/process_email.php badges/preferences_form.php $ touch badges/preferences_form.php etc Open your Moodle instance on your browser. Log in as admin and proceed with the upgrade. Confirm that a message ("Mixed Moodle versions detected....") is displayed saying that there are problems upgrading and a proper procedure for upgrading to a major release. Delete the touched file(s) in point 5. Click Reload Confirm that the upgrade now proceeds OK CLI Repeat points 1-5 from the "Web" instructions. Run the CLI upgrade $ php admin/cli/upgrade.php Confirm that a message ("Mixed Moodle versions detected....") is displayed saying that there are problems upgrading and a proper procedure for upgrading to a major release. Delete the touched file(s) in point web - 5. Run the CLI upgrade again $ php admin/cli/upgrade.php Confirm that now the process runs OK, with a prompt asking you for confirmation and then a number of upgrade steps and settings being setup. Confirm that the process ends with a text like this (the numbers are not important), the "successfully" is.: Command line upgrade from XXXXX (Build: XXXXX) (XXXXX) to XXXXX (Build: XXXXX) (XXXXX) completed successfully.
    • Hide

      Code verified against automated checks.

      Checked MDL-85202 using repository: https://github.com/paulholden/moodle/

      More information about this report

      Built on: Tue Apr 15 06:57:10 UTC 2025

      Show
      Code verified against automated checks. Checked MDL-85202 using repository: https://github.com/paulholden/moodle/ MOODLE_500_STABLE (0 errors / 0 warnings) [branch: MDL-85202-500 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-85202 | CI Job ] More information about this report Built on: Tue Apr 15 06:57:10 UTC 2025
    • Show
      Launching automatic jobs for branch MDL-85202 -500 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19028/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65068/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65069/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-85202 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19029/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65070/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65071/ Behat (Firefox - boost)  --> Unrelated (can be ignored) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65072/ Behat (Firefox - classic)  --> Unrelated (can be ignored) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65073/ App tests (stable app version)  --> Unrelated (can be ignored) Built on: Tue Apr 15 08:25:20 UTC 2025
    • Team Hedgehog 2024 Sprint 3.3

      Simply verify we have a number (4-5) of files for the next major release. They all must be files deleted since last stable version (405) and current main.

      $ git diff --name-status MOODLE_XX_STABLE..main | grep ^D
      

      And, then, simply, add them to upgrade_stale_php_files_present()

      Note that it's better not to pick any plugin file that maybe reinstalled manually (exception being forum files because that plugin is mandatory)

      Note: (to avoid forgetting it in next iteration of this issue). Don't forget the leading slashes in the paths

        1. (1) 11 Passed -- (Main)MDL-85202.png
          188 kB
          Kim Jared Lucas
        2. (1) 8 Passed -- (Main)MDL-85202.png
          402 kB
          Kim Jared Lucas
        3. (2) 3 Passed -- (Main)MDL-85202.png
          217 kB
          Kim Jared Lucas
        4. (2) 7 Passed -- (Main)MDL-85202.png
          209 kB
          Kim Jared Lucas

            pholden Paul Holden
            pholden Paul Holden
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            Huong Nguyen Huong Nguyen
            Kim Jared Lucas Kim Jared Lucas
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 34 minutes
                1h 34m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.