-
Bug
-
Resolution: Fixed
-
Minor
-
4.1.18, 4.3.9, 4.4.8, 4.5
-
MOODLE_401_STABLE, MOODLE_403_STABLE, MOODLE_404_STABLE, MOODLE_405_STABLE
-
MOODLE_404_STABLE, MOODLE_405_STABLE, MOODLE_500_STABLE
-
MDL-85170-405 -
MDL-85170-main -
- Go to display_options() public function in /mod/choice/renderer.php
- Confirm the number of html_writer::start_tag('ul' calls is the same as the number of html_writer::end_tag('ul' calls
-
Code verified against automated checks. 
Checked
MDL-85170using repository: https://github.com/aanabit/moodle.git
MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-85170-405 | CI Job]- main (0 errors / 0 warnings) [branch: MDL-85170-main | CI Job]
More information about this report
Built on: Fri Apr 11 15:27:22 UTC 2025
Code verified against automated checks. Checked MDL-85170 using repository: https://github.com/aanabit/moodle.git MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-85170-405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-85170-main | CI Job ] More information about this report Built on: Fri Apr 11 15:27:22 UTC 2025 -
-
1
-
HQ 2025 Sprint I1.4 Moppies
In display options, an UL list is opened right after the form tag :
$html = html_writer::start_tag('form', $attributes);
$html .= html_writer::start_tag('ul', array('class' => 'choices list-unstyled unstyled'));
closed just before adding a clearfloat div :
$html .= html_writer::tag('li','', array('class'=>'clearfloat'));
$html .= html_writer::end_tag('ul');
But additionally closed again at end before closing the form :
$html .= html_writer::end_tag('ul');
$html .= html_writer::end_tag('form');
Removing last closing occurrence make things fine.
