Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.5.5, 5.0.1
Affects Version/s: 4.5.4
Component/s: Forms Library
Labels:

Affected Branches:
MOODLE_405_STABLE
Fixed Branches:
MOODLE_405_STABLE, MOODLE_500_STABLE
Pull from Repository:
https://github.com/paulholden/moodle/
Pull 4.5 Branch:
~~MDL-85169~~-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...paulholden:MDL-85169-405
Pull 5.0 Branch:
~~MDL-85169~~-500
Pull 5.0 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_500_STABLE...paulholden:MDL-85169-500
Pull Main Branch:
~~MDL-85169~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...paulholden:MDL-85169
Testing Instructions:
Hide

Navigate to course question bank

Add a new Essay question type

Set Response options > Allow attachments to "1"

Click on Accepted file types

Confirm the Accepted file types text input element is focused
Show
Navigate to course question bank Add a new Essay question type Set Response options > Allow attachments to "1" Click on Accepted file types Confirm the Accepted file types text input element is focused
Pre-check results:
Hide

Code verified against automated checks with warnings.

Checked ~~MDL-85169~~ using repository: https://github.com/paulholden/moodle/

MOODLE_405_STABLE (0 errors / 4 warnings) [branch: MDL-85169-405 | CI Job]

overview (0/0), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/4), gherkin (0/0),

MOODLE_500_STABLE (0 errors / 4 warnings) [branch: MDL-85169-500 | CI Job]

overview (0/0), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/4), gherkin (0/0),

main (0 errors / 4 warnings) [branch: MDL-85169 | CI Job]

overview (0/0), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/4), gherkin (0/0),

Should these errors be fixed?

Built on: Fri May 2 13:58:13 UTC 2025
Show
Code verified against automated checks with warnings. Checked MDL-85169 using repository: https://github.com/paulholden/moodle/ MOODLE_405_STABLE (0 errors / 4 warnings) [branch: MDL-85169-405 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/4) , gherkin (0/0) , MOODLE_500_STABLE (0 errors / 4 warnings) [branch: MDL-85169-500 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/4) , gherkin (0/0) , main (0 errors / 4 warnings) [branch: MDL-85169 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/4) , gherkin (0/0) , Should these errors be fixed? Built on: Fri May 2 13:58:13 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-85169~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19173/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65531/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65532/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-85169~~-500

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19174/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65533/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65534/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-85169~~

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19175/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65535/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65536/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65537/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65538/ App tests (stable app version) --> unrelated failure, please ignore.

Built on: Fri May 2 14:25:23 UTC 2025
Show
Launching automatic jobs for branch MDL-85169 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19173/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65531/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65532/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-85169 -500 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19174/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65533/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65534/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-85169 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19175/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65535/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65536/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65537/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65538/ App tests (stable app version) --> unrelated failure, please ignore. Built on: Fri May 2 14:25:23 UTC 2025

Sprint:
Hhogs Merge Review Candidates

Clicking on the labels of form elements will normally move focus on the form element.

A JS code is meant to do this for the core_form/element-group template, but it does not work because it points to a non-existent element ID.

Note that ~~MDL-61823~~ added the relevant IDs that enabled this functionality, but it needed to be reverted in ~~MDL-85139~~ because it caused an issue related to duplicate element IDs on the page.

We need to create a proper solution to fix this issue that is safe and robust.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

MDL-85169.png
88 kB
28/May/25 9:44 AM

has a non-specific relationship to

MDL-85139 invalid HTML because of duplicate element IDs

Closed

MDL-61823 The filetypes form element has two labels, one of which is broken

Closed

Assignee:: Paul Holden

Reporter:: Jun Pataleta

Peer reviewer:: Carlos Castillo

Integrator:: Huong Nguyen

Tester:: Ron Carl Alfon Yu

Participants:: Carlos Castillo, CiBoT, Huong Nguyen, Jun Pataleta, Paul Holden, Ron Carl Alfon Yu

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Created:: 11/Apr/25 3:46 PM

Updated:: 06/Jun/25 3:12 PM

Resolved:: 30/May/25 5:07 PM

Estimated:

Not Specified

Remaining:

Logged:

54m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify