Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 5.0
Affects Version/s: 5.0
Component/s: Installation, Unit tests
Labels:

Affected Branches:
MOODLE_500_STABLE
Fixed Branches:
MOODLE_500_STABLE
Pull from Repository:
https://github.com/marinaglancy/moodle
Pull Main Branch:
~~MDL-85123~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...marinaglancy:moodle:MDL-85123
Testing Instructions:
Hide

Install plugin https://github.com/moodleworkplace/moodle-tool_datewatch

$ git clone https://github.com/moodleworkplace/moodle-tool_datewatch admin/tool/datewatch

Run the tests from tests/plugin_manager_test.php with the patch and make sure they pass

$ vendor/bin/phpunit lib/tests/plugin_manager_test.php
Show
Install plugin https://github.com/moodleworkplace/moodle-tool_datewatch $ git clone https://github.com/moodleworkplace/moodle-tool_datewatch admin/tool/datewatch Run the tests from tests/plugin_manager_test.php with the patch and make sure they pass $ vendor/bin/phpunit lib/tests/plugin_manager_test.php
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-85123~~ using repository: https://github.com/marinaglancy/moodle

main (0 errors / 0 warnings) [branch: MDL-85123 | CI Job]

_{More information about this report}

Built on: Mon Apr 7 10:46:08 UTC 2025
Show
Code verified against automated checks. Checked MDL-85123 using repository: https://github.com/marinaglancy/moodle main (0 errors / 0 warnings) [branch: MDL-85123 | CI Job ] More information about this report Built on: Mon Apr 7 10:46:08 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-85123~~

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18947/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64837/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64838/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64839/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64840/ App tests (stable app version)

Built on: Mon Apr 7 12:25:29 UTC 2025
Show
Launching automatic jobs for branch MDL-85123 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18947/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64837/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64838/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64839/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64840/ App tests (stable app version) Built on: Mon Apr 7 12:25:29 UTC 2025

We have two failures in plugin_manager_test in Workplace. They are caused by one of our plugins calling get_plugins_with_function and rebuilding the plugin_manager cache, so that the mocked values are not returned.

core\plugin_manager_test::test_plugin_manager_deprecated_subplugintype

Failed asserting that two strings are equal.

--- Expected

+++ Actual

@@ @@

-'uptodate'

+'new'

/var/www/html/lib/tests/plugin_manager_test.php:901

core\plugin_manager_test::test_plugin_manager_deprecated_subplugintype

Failed asserting that two strings are equal.

--- Expected

+++ Actual

@@ @@

-'uptodate'

+'new'

/var/www/html/lib/tests/plugin_manager_test.php:901

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

MDL-85123.png
102 kB
08/Apr/25 3:10 PM

is a regression caused by

MDL-79843 Introduce mechanism for plugin type deprecation

Closed

Assignee:: Marina Glancy

Reporter:: Marina Glancy

Peer reviewer:: Paul Holden

Integrator:: Huong Nguyen

Tester:: Ron Carl Alfon Yu

Participants:: CiBoT, Huong Nguyen, Marina Glancy, Paul Holden, Ron Carl Alfon Yu

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Created:: 07/Apr/25 5:06 PM

Updated:: 08/Apr/25 11:34 PM

Resolved:: 08/Apr/25 11:34 PM

Estimated:

Remaining:

Logged:

5h 36m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify