Loading...

XML

Word

Printable

Type: Bug
Resolution: Unresolved
Priority: Minor
Fix Version/s: None
Affects Version/s: 4.4.8, 4.5.4, 5.0
Component/s: Files API
Labels:
- CatalystIT
- ci
- partner

Affected Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE, MOODLE_500_STABLE
Pull from Repository:
https://github.com/matthewhilton/moodle
Pull 4.4 Branch:
mdl85075-44
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...matthewhilton:moodle:mdl85075-44
Pull 4.5 Branch:
mdl85075-45
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...matthewhilton:moodle:mdl85075-45
Pull Main Branch:
mdl85075-main
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...matthewhilton:moodle:mdl85075-main
Testing Instructions:
Hide

Install https://github.com/catalyst/moodle-tool_curlmanager (This plugin defines a curl_security_helper callback in it's lib.php)

Run unit test vendor/bin/phpunit --filter=test_curl_basics_with_security_helper

Confirm the above unit test passes
Show
Install https://github.com/catalyst/moodle-tool_curlmanager (This plugin defines a curl_security_helper callback in it's lib.php) Run unit test vendor/bin/phpunit --filter=test_curl_basics_with_security_helper Confirm the above unit test passes
Pre-check results:
Hide

Code verified against automated checks.

Checked MDL-85075 using repository: https://github.com/matthewhilton/moodle

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: mdl85075-44 | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: mdl85075-45 | CI Job]

main (0 errors / 0 warnings) [branch: mdl85075-main | CI Job]

_{More information about this report}

Built on: Sun Apr 6 23:48:16 UTC 2025
Show
Code verified against automated checks. Checked MDL-85075 using repository: https://github.com/matthewhilton/moodle MOODLE_404_STABLE (0 errors / 0 warnings) [branch: mdl85075-44 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: mdl85075-45 | CI Job ] main (0 errors / 0 warnings) [branch: mdl85075-main | CI Job ] More information about this report Built on: Sun Apr 6 23:48:16 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch mdl85075-44

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18932/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64794/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64795/ Behat (Firefox - boost)

Launching automatic jobs for branch mdl85075-45

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18933/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64796/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64797/ Behat (Firefox - boost)

Launching automatic jobs for branch mdl85075-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18934/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64798/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64799/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64800/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64801/ App tests (stable app version)

Built on: Mon Apr 7 00:25:21 UTC 2025
Show
Launching automatic jobs for branch mdl85075-44 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18932/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64794/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64795/ Behat (Firefox - boost) Launching automatic jobs for branch mdl85075-45 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18933/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64796/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64797/ Behat (Firefox - boost) Launching automatic jobs for branch mdl85075-main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18934/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64798/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64799/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64800/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64801/ App tests (stable app version) Built on: Mon Apr 7 00:25:21 UTC 2025

The mere presence of an additional curl security helper plugin causes a test failure, due to what seems like an incorrect test:

1) core\filelib_test::test_curl_basics_with_security_helper

Failed asserting that two strings are identical.

--- Expected

+++ Actual

@@ @@

-'You shall not pass'

+'The URL is blocked.'/var/www/moodle/lib/tests/filelib_test.php:303

A quick inspection seems to show this is because the tests use a mock helper, but this mock helper is not used when an additional helper is installed, so the tests fail.

In lib/tests/filelib_test.php:3034 is checking the contents returned is 'You shall not pass', but because check_securityhelper_blocklist here:

https://github.com/moodle/moodle/blob/b00c328d2dbbd49dcba8738c9da3ba4302e56c3a/lib/filelib.php#L3742

is returning the curlmanager plugin, instead of the mocked security helper, which would return in the block below but is never reached:

https://github.com/moodle/moodle/blob/b00c328d2dbbd49dcba8738c9da3ba4302e56c3a/lib/filelib.php#L3751

This can probably be fixed by just reordering these blocks so the mock helper is always executed first.

Reproduce:

Install https://github.com/catalyst/moodle-tool_curlmanager

vendor/bin/phpunit --filter=test_curl_basics_with_security_helper

Assignee:: Matthew Hilton

Reporter:: Matthew Hilton

Peer reviewer:: Peter Burnett

Participants:: CiBoT, Jun Pataleta, Matthew Hilton, Peter Burnett

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Created:: 01/Apr/25 9:55 AM

Updated:: 13/Jun/25 4:05 PM

Details

Description

Reproduce:

Attachments

Activity

People

Dates

Clockify