Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Major
Fix Version/s: 5.0
Affects Version/s: 5.0
Component/s: Gradebook
Labels:

Affected Branches:
MOODLE_500_STABLE
Fixed Branches:
MOODLE_500_STABLE
Pull from Repository:
https://github.com/catalyst/moodle
Pull Main Branch:
~~MDL-85058~~_main
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...catalyst:moodle:MDL-85058_main
Testing Instructions:
Hide

Follow the testing instructions of ~~MDL-80984~~ until section "Testing: Penalty implementation on an assignment" (included).

Change the language to Catalan or any language which does not use a period as decimal separator.

Go to the gradebook.

There should be no more exeption:

Excepció - number_format(): Argument #1 ($num) must be of type float, string given
Show
Follow the testing instructions of MDL-80984 until section "Testing: Penalty implementation on an assignment" (included). Change the language to Catalan or any language which does not use a period as decimal separator. Go to the gradebook. There should be no more exeption: Excepció - number_format(): Argument #1 ($num) must be of type float, string given
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-85058~~ using repository: https://github.com/catalyst/moodle

main (0 errors / 0 warnings) [branch: MDL-85058_main | CI Job]

_{More information about this report}

Built on: Tue Apr 1 05:37:13 UTC 2025
Show
Code verified against automated checks. Checked MDL-85058 using repository: https://github.com/catalyst/moodle main (0 errors / 0 warnings) [branch: MDL-85058_main | CI Job ] More information about this report Built on: Tue Apr 1 05:37:13 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-85058~~_main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18887/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64664/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64665/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64666/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64667/ App tests (stable app version)

Built on: Wed Apr 2 02:30:14 UTC 2025
Show
Launching automatic jobs for branch MDL-85058 _main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18887/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64664/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64665/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64666/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64667/ App tests (stable app version) Built on: Wed Apr 2 02:30:14 UTC 2025

Steps to reproduce:

Follow the testing instructions of ~~MDL-80984~~ until section "Testing: Penalty implementation on an assignment" (included).
Change the language to Catalan or any language which does not use a period as decimal separator.
Go to the gradebook.

The following exception is displayed:
Excepció - number_format(): Argument #1 ($num) must be of type float, string given

The cause of the exception is in this function, which calls format_float twice for the same value: https://github.com/moodle/moodle/blob/main/grade/classes/output/penalty_indicator.php#L74

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

MDL-85058.png
237 kB
04/Apr/25 5:03 PM

caused a regression

MDL-80984 Implement generic penalties in Gradebook

Closed

Assignee:: Nathan Nguyen

Reporter:: Albert Gasset

Peer reviewer:: Alexander Van der Bellen

Integrator:: Mihail Geshoski

Tester:: Ron Carl Alfon Yu

Participants:: Albert Gasset, Alexander Van der Bellen, CiBoT, Dmitrii Metelkin, Huong Nguyen, Juan Leyva, Mihail Geshoski, Nathan Nguyen, Ron Carl Alfon Yu

Votes:: 1 Vote for this issue

Watchers:: 9 Start watching this issue

Created:: 31/Mar/25 4:27 PM

Updated:: 04/Apr/25 11:42 PM

Resolved:: 04/Apr/25 11:42 PM

Estimated:

Not Specified

Remaining:

Logged:

6h 50m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify