Loading...

XML

Word

Printable

Type: Bug
Resolution: Unresolved
Priority: Minor
Fix Version/s: None
Affects Version/s: 4.5, 5.1
Component/s: Text editor TinyMCE
Labels:
- ci
- external_confirmed

Affected Branches:
MOODLE_405_STABLE, MOODLE_501_STABLE
Pull from Repository:
https://github.com/NashTechOpenUniversity/moodle
Pull 4.5 Branch:
MDL-85050-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...NashTechOpenUniversity:moodle:MDL-85050-405
Pull 5.0 Branch:
MDL-85050-500
Pull 5.0 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_500_STABLE...NashTechOpenUniversity:moodle:MDL-85050-500
Pull Main Branch:
MDL-85050-master
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...NashTechOpenUniversity:moodle:MDL-85050-master
Testing Instructions:
Hide

Prerequisites

Use Google Chrome or Microsoft Edge browser to reproduce this issue

Testing

Log in to your account as the admin user.

Navigate to the Edit Profile section.

Click on the "Image" icon in the toolbar located in the description field.

Press the 'Tab' key on the keyboard until the 'Add file' link appears.

Click on the "Add file" link

Click on the "Cancel" button in the OS file manager

Verify that the OS file manager does not reappear.
Show
Prerequisites Use Google Chrome or Microsoft Edge browser to reproduce this issue Testing Log in to your account as the admin user. Navigate to the Edit Profile section. Click on the "Image" icon in the toolbar located in the description field. Press the 'Tab' key on the keyboard until the ' Add file ' link appears. Click on the "Add file" link Click on the "Cancel" button in the OS file manager Verify that the OS file manager does not reappear.
Pre-check results:
Hide

Code verified against automated checks with warnings.

Checked MDL-85050 using repository: https://github.com/NashTechOpenUniversity/moodle

MOODLE_405_STABLE (0 errors / 1 warnings) [branch: MDL-85050-405 | CI Job]

overview (0/1), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

Warn: The MDL-85050-405 branch at https://github.com/NashTechOpenUniversity/moodle has not been rebased recently (>20 days ago).

MOODLE_500_STABLE (0 errors / 1 warnings) [branch: MDL-85050-500 | CI Job]

overview (0/1), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

Warn: The MDL-85050-500 branch at https://github.com/NashTechOpenUniversity/moodle has not been rebased recently (>20 days ago).

main (0 errors / 1 warnings) [branch: MDL-85050-master | CI Job]

overview (0/1), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

Warn: The MDL-85050-master branch at https://github.com/NashTechOpenUniversity/moodle has not been rebased recently (>20 days ago).

Should these errors be fixed?

Built on: Mon Jun 9 03:28:59 UTC 2025
Show
Code verified against automated checks with warnings. Checked MDL-85050 using repository: https://github.com/NashTechOpenUniversity/moodle MOODLE_405_STABLE (0 errors / 1 warnings) [branch: MDL-85050-405 | CI Job ] overview (0/1) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Warn: The MDL-85050 -405 branch at https://github.com/NashTechOpenUniversity/moodle has not been rebased recently (>20 days ago). MOODLE_500_STABLE (0 errors / 1 warnings) [branch: MDL-85050-500 | CI Job ] overview (0/1) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Warn: The MDL-85050 -500 branch at https://github.com/NashTechOpenUniversity/moodle has not been rebased recently (>20 days ago). main (0 errors / 1 warnings) [branch: MDL-85050-master | CI Job ] overview (0/1) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Warn: The MDL-85050 -master branch at https://github.com/NashTechOpenUniversity/moodle has not been rebased recently (>20 days ago). Should these errors be fixed? Built on: Mon Jun 9 03:28:59 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch MDL-85050-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19627/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67104/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67105/ Behat (Firefox - boost)

Launching automatic jobs for branch MDL-85050-500

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19628/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67106/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67107/ Behat (Firefox - boost)

Launching automatic jobs for branch MDL-85050-master

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19629/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67108/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67109/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67110/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67111/ App tests (stable app version)

Built on: Mon Jun 9 04:30:40 UTC 2025
Show
Launching automatic jobs for branch MDL-85050 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19627/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67104/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67105/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-85050 -500 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19628/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67106/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67107/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-85050 -master https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19629/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67108/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67109/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67110/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/67111/ App tests (stable app version) Built on: Mon Jun 9 04:30:40 UTC 2025

When inserting an image and navigating to 'add a file', the file explorer window appears twice.

To reproduce:

Go to the sanbox and find a forum to reply to.
Select the image button in the text editor.
Keep pressing tab until you see 'Add a file' and press enter
Select 'cancel' on the file explorer window that appears
Note that the file explorer window reappears
Select 'cancel' and the file explorer window should disappear for good.

For additional info this appears to work ok in Firefox but not Chrome or Edge.

has been marked as being related by

MDL-85715 PR only: MDL-85050 - TinyMCE: When finding an image to insert, the file explorer window reappears if you hit cancel.

Closed

Assignee:: Toan Lam

Reporter:: Scott Redrup

Peer reviewer:: Meirza

Participants:: Kim Jared Lucas, Meirza, Scott Redrup, Toan Lam

Votes:: 1 Vote for this issue

Watchers:: 4 Start watching this issue

Created:: 28/Mar/25 5:27 PM

Updated:: 09/Jun/25 12:30 PM

Details

Description

Attachments

Issue Links

Activity

People

Dates

Clockify