Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Major
Fix Version/s: 4.4.8, 4.5.4
Affects Version/s: 4.4.7, 4.5.3
Component/s: JavaScript, Libraries, Report builder
Labels:

Affected Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Epic Link:
WP-805
Pull from Repository:
https://github.com/paulholden/moodle/
Pull 4.4 Branch:
~~MDL-85007~~-404
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...paulholden:MDL-85007-404
Pull 4.5 Branch:
~~MDL-85007~~-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...paulholden:MDL-85007-405
Pull Main Branch:
~~MDL-85007~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...paulholden:MDL-85007
Testing Instructions:
Hide

Setup

Log in as admin

Install this plugin: https://github.com/paulholden/moodle-block_rbreport

$ git clone https://github.com/paulholden/moodle-block_rbreport blocks/rbreport

Navigate to Reports in user menu

Create new report from Users report source

Include default setup: Yes

Test

Navigate to Dashboard

Turn editing on

Press Add a block

Choose Report...

Select report: <Your previously created report>

Press Save changes in the modal

Press Add a block (again)

Choose Report...

Select report: <The same previously created report>

Press Save changes in the modal

Sort some of the columns in the first block instance

Confirm background of first block instance changes colour

Sort some of the columns in the second block instance

Confirm background of second block instance changes colour

Regression test

Navigate to Users > Accounts > Browse list of users

Confirm you can sort and page the users table
Show
Setup Log in as admin Install this plugin: https://github.com/paulholden/moodle-block_rbreport $ git clone https://github.com/paulholden/moodle-block_rbreport blocks/rbreport Navigate to Reports in user menu Create new report from Users report source Include default setup: Yes Test Navigate to Dashboard Turn editing on Press Add a block Choose Report... Select report: <Your previously created report> Press Save changes in the modal Press Add a block (again) Choose Report... Select report: <The same previously created report> Press Save changes in the modal Sort some of the columns in the first block instance Confirm background of first block instance changes colour Sort some of the columns in the second block instance Confirm background of second block instance changes colour Regression test Navigate to Users > Accounts > Browse list of users Confirm you can sort and page the users table
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-85007~~ using repository: https://github.com/paulholden/moodle/

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-85007-404 | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-85007-405 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-85007 | CI Job]

_{More information about this report}

Built on: Tue Mar 25 20:59:11 UTC 2025
Show
Code verified against automated checks. Checked MDL-85007 using repository: https://github.com/paulholden/moodle/ MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-85007-404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-85007-405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-85007 | CI Job ] More information about this report Built on: Tue Mar 25 20:59:11 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-85007~~-404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18792/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64373/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64374/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-85007~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18793/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64375/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64376/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-85007~~

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18794/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64377/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64378/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64379/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64380/ App tests (stable app version)

Built on: Tue Mar 25 20:26:02 UTC 2025
Show
Launching automatic jobs for branch MDL-85007 -404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18792/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64373/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64374/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-85007 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18793/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64375/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64376/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-85007 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18794/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64377/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64378/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64379/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64380/ App tests (stable app version) Built on: Tue Mar 25 20:26:02 UTC 2025

Story Points:
2
Sprint:
WP Sprint 2025-I1.3 (Clones)

The code for dynamically updating table content is thus:

https://github.com/moodle/moodle/blob/89d76fdc25ead41d29253972c45268a21dae7633/lib/table/amd/src/dynamic.js#L91-L101

The problem is that the table that is being dynamically updated is not necessarily the same table upon which we dispatch the event

The problem is the same as reported in ~~MDL-85001~~ - when there are two of the same report builder reports on a page (similar scenario as described in that issue, e.g. multiple blocks, each pointing at the same report), then events that should be triggered for the second report are instead triggered for the first instance of the report in the DOM

This is because getTableFromId(tableRoot.dataset.tableUniqueid); will return the same value for each table, because they each have the following attribute:

data-table-uniqueid="custom-report-table-306"

This problem could be reproduced in Moodle if ever a situation arose where the same dynamic table was rendered multiple times in DOM, however it's more prevalent in Workplace with our report block and the chart visualisation project

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

MDL-85007.png
26/Mar/25 3:30 PM
324 kB
Ron Carl Alfon Yu

has been marked as being related by

MDL-85001 Report builder filtering doesn't work when report duplicated on page

Closed

Assignee:: Paul Holden

Reporter:: Paul Holden

Peer reviewer:: Pedro Jordao

Integrator:: Jake Dallimore

Tester:: Ron Carl Alfon Yu

Participants:: CiBoT, Jake Dallimore, Paul Holden, Pedro Jordao, Ron Carl Alfon Yu

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Created:: 25/Mar/25 11:48 PM

Updated:: 02/Apr/25 6:50 PM

Resolved:: 28/Mar/25 8:09 PM

Estimated:

Not Specified

Remaining:

Logged:

4h 17m

Details

Setup

Test

Regression test

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify