Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Major
Fix Version/s: 4.4.8, 4.5.4
Affects Version/s: 4.4.7, 4.5.3
Component/s: Report builder
Labels:

Affected Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Epic Link:
WP-805
Pull from Repository:
https://github.com/paulholden/moodle.git
Pull 4.4 Branch:
~~MDL-85001~~-404
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...paulholden:MDL-85001-404
Pull 4.5 Branch:
~~MDL-85001~~-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...paulholden:MDL-85001-405
Pull Main Branch:
~~MDL-85001~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...paulholden:MDL-85001
Testing Instructions:
Hide

Setup

Log in as admin

Install this plugin: https://moodle.org/plugins/block_rbreport

Navigate to Reports in user menu

Create new report from Users report source

Include default setup: Yes

Test

Navigate to Dashboard

Turn editing on

Press Add a block

Choose Report...

Select report: <Your previously created report>

Click on Save changes in the Modal "Add Report block"

Press Add a block (again)

Choose Report...

Select report: <The same previously created report>

Click on Save changes in the Modal "Add Report block"

Open Filters on first block instance

Change some filter values and apply

Confirm page doesn't reload and first block instance report updates

Open Filters on second block instance

Change some filter values and apply

Confirm page doesn't reload and second block instance report updates
Show
Setup Log in as admin Install this plugin: https://moodle.org/plugins/block_rbreport Navigate to Reports in user menu Create new report from Users report source Include default setup: Yes Test Navigate to Dashboard Turn editing on Press Add a block Choose Report... Select report: <Your previously created report> Click on Save changes in the Modal "Add Report block" Press Add a block (again) Choose Report... Select report: <The same previously created report> Click on Save changes in the Modal "Add Report block" Open Filters on first block instance Change some filter values and apply Confirm page doesn't reload and first block instance report updates Open Filters on second block instance Change some filter values and apply Confirm page doesn't reload and second block instance report updates
Pre-check results:
Hide

Code verified against automated checks with warnings.

Checked ~~MDL-85001~~ using repository: https://github.com/paulholden/moodle.git

MOODLE_404_STABLE (0 errors / 2 warnings) [branch: MDL-85001-404 | CI Job]

overview (0/0), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/2), gherkin (0/0),

MOODLE_405_STABLE (0 errors / 2 warnings) [branch: MDL-85001-405 | CI Job]

overview (0/0), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/2), gherkin (0/0),

main (0 errors / 2 warnings) [branch: MDL-85001 | CI Job]

overview (0/0), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/2), gherkin (0/0),

Should these errors be fixed?

Built on: Tue Mar 25 12:17:27 UTC 2025
Show
Code verified against automated checks with warnings. Checked MDL-85001 using repository: https://github.com/paulholden/moodle.git MOODLE_404_STABLE (0 errors / 2 warnings) [branch: MDL-85001-404 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/2) , gherkin (0/0) , MOODLE_405_STABLE (0 errors / 2 warnings) [branch: MDL-85001-405 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/2) , gherkin (0/0) , main (0 errors / 2 warnings) [branch: MDL-85001 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/2) , gherkin (0/0) , Should these errors be fixed? Built on: Tue Mar 25 12:17:27 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-85001~~-404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18789/ PHPUnit (sqlsrv / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64363/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64364/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64365/ Behat (Firefox - classic / complete)

Launching automatic jobs for branch ~~MDL-85001~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18790/ PHPUnit (sqlsrv / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64366/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64367/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64368/ Behat (Firefox - classic / complete)

Launching automatic jobs for branch ~~MDL-85001~~

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18791/ PHPUnit (sqlsrv / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64369/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64370/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64371/ Behat (Firefox - classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64372/ App tests (stable app version) / complete)

Built on: Tue Mar 25 17:14:22 UTC 2025
Show
Launching automatic jobs for branch MDL-85001 -404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18789/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64363/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64364/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64365/ Behat (Firefox - classic / complete) Launching automatic jobs for branch MDL-85001 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18790/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64366/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64367/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64368/ Behat (Firefox - classic / complete) Launching automatic jobs for branch MDL-85001 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18791/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64369/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64370/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64371/ Behat (Firefox - classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64372/ App tests (stable app version) / complete) Built on: Tue Mar 25 17:14:22 UTC 2025

Story Points:
3
Sprint:
WP Sprint 2025-I1.3 (Clones)

This wouldn't typically happen in LMS, but it causes a problem for plugins when the same report is rendered to the page multiple times. In this case, for all duplicate reports (after the first) their filtering is broken

This currently affects Workplace open-source block: https://moodle.org/plugins/block_rbreport where multiple page blocks refer to the same report, and also affects the chart visualisation project where the page will show a report, and allow for it to be opened in a full screen modal (therefore duplicating the report in the page DOM):

The problem is that the filters loader only considers the report ID, which as we've determined is not guaranteed to be unique on the page

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

MDL-85001.png
26/Mar/25 4:21 PM
203 kB
Ron Carl Alfon Yu
Screenshot from 2025-03-25 10-53-27.png
25/Mar/25 7:05 PM
20 kB
Paul Holden

has a non-specific relationship to

MDL-85007 Dynamic table triggers updated events in wrong table instances

Closed

Assignee:: Paul Holden

Reporter:: Paul Holden

Peer reviewer:: Carlos Castillo

Integrator:: David Carrillo

Tester:: Ron Carl Alfon Yu

Participants:: Carlos Castillo, CiBoT, David Carrillo, Huong Nguyen, Paul Holden, Ron Carl Alfon Yu

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Created:: 25/Mar/25 7:01 PM

Updated:: 11/Apr/25 3:42 PM

Resolved:: 28/Mar/25 8:09 PM

Estimated:

Not Specified

Remaining:

Logged:

5h 45m

Details

Setup

Test

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify