Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.5.5, 5.0.1
Affects Version/s: 4.4.7, 4.5 regressions, 4.5.3
Component/s: Enrolments
Labels:
- ci
- regression
- triaged

Affected Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Fixed Branches:
MOODLE_405_STABLE, MOODLE_500_STABLE
Pull from Repository:
https://github.com/paulholden/moodle
Pull 4.5 Branch:
~~MDL-84996~~-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...paulholden:MDL-84996-405
Pull 5.0 Branch:
~~MDL-84996~~-500
Pull 5.0 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_500_STABLE...paulholden:MDL-84996-500
Pull Main Branch:
~~MDL-84996~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...paulholden:MDL-84996

Testing Instructions:

Hide

Setup

Log in as admin
Go to Site admin -> General -> Advanced features
Enable web services
Go to Site admin -> Server -> Web services -> Manage protocols
Enable REST protocol
Go to Site admin -> Server -> Web services -> External services
Create a new service
- Name: My service
- Enabled: Yes
Add the following functions to the new service:
- enrol_manual_enrol_users
Go to Site admin -> Server -> Web services -> Manage tokens
Create a token for yourself to use My service
- Make a note of the generated token (<TOKEN>)
Create a new course
- Make a note of the course ID (<COURSEID>)
Create a new user
- Make a note of the user ID (<USERID>)

Test valid user

Execute the following webservice request:

$ curl --silent "<WWWROOT>/webservice/rest/server.php?moodlewsrestformat=json" --data "wstoken=<TOKEN>&wsfunction=enrol_manual_enrol_users&enrolments[0][userid]=<USERID>&enrolments[0][courseid]=<COURSEID>&enrolments[0][roleid]=5" | python -m "json.tool"

View participants of your test course
Confirm test user is enrolled

Test invalid user

Execute the following webservice request:

$ curl --silent "<WWWROOT>/webservice/rest/server.php?moodlewsrestformat=json" --data "wstoken=<TOKEN>&wsfunction=enrol_manual_enrol_users&enrolments[0][userid]=98765&enrolments[0][courseid]=<COURSEID>&enrolments[0][roleid]=5" | python -m "json.tool"

Confirm you see the message "invaliduser" (or "invalidrecordunknown" depending on your debugging set).

Show

Setup Log in as admin Go to Site admin -> General -> Advanced features Enable web services Go to Site admin -> Server -> Web services -> Manage protocols Enable REST protocol Go to Site admin -> Server -> Web services -> External services Create a new service Name: My service Enabled: Yes Add the following functions to the new service: enrol_manual_enrol_users Go to Site admin -> Server -> Web services -> Manage tokens Create a token for yourself to use My service Make a note of the generated token ( <TOKEN> ) Create a new course Make a note of the course ID ( <COURSEID> ) Create a new user Make a note of the user ID ( <USERID> ) Test valid user Execute the following webservice request: $ curl --silent "<WWWROOT>/webservice/rest/server.php?moodlewsrestformat=json" --data "wstoken=<TOKEN>&wsfunction=enrol_manual_enrol_users&enrolments[0][userid]=<USERID>&enrolments[0][courseid]=<COURSEID>&enrolments[0][roleid]=5" | python -m "json.tool" View participants of your test course Confirm test user is enrolled Test invalid user Execute the following webservice request: $ curl --silent "<WWWROOT>/webservice/rest/server.php?moodlewsrestformat=json" --data "wstoken=<TOKEN>&wsfunction=enrol_manual_enrol_users&enrolments[0][userid]=98765&enrolments[0][courseid]=<COURSEID>&enrolments[0][roleid]=5" | python -m "json.tool" Confirm you see the message "invaliduser" (or "invalidrecordunknown" depending on your debugging set).

Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-84996~~ using repository: https://github.com/paulholden/moodle

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-84996-405 | CI Job]

MOODLE_500_STABLE (0 errors / 0 warnings) [branch: MDL-84996-500 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-84996 | CI Job]

_{More information about this report}

Built on: Wed May 14 09:08:36 UTC 2025
Show
Code verified against automated checks. Checked MDL-84996 using repository: https://github.com/paulholden/moodle MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-84996-405 | CI Job ] MOODLE_500_STABLE (0 errors / 0 warnings) [branch: MDL-84996-500 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-84996 | CI Job ] More information about this report Built on: Wed May 14 09:08:36 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-84996~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19377/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66237/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66238/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-84996~~-500

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19378/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66239/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66240/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-84996~~

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19379/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66241/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66242/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66243/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66244/ App tests (stable app version)

Built on: Mon May 19 10:30:42 UTC 2025
Show
Launching automatic jobs for branch MDL-84996 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19377/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66237/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66238/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-84996 -500 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19378/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66239/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66240/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-84996 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19379/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66241/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66242/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66243/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66244/ App tests (stable app version) Built on: Mon May 19 10:30:42 UTC 2025

After upgrading to Version 4.5.3+ (Build: 20250318) , some calls to webservice/rest/server.php?wsfunction=enrol_manual_enrol_users&... yield the following error response:

{"exception":"TypeError","message":"core\\user::get_name_placeholders(): Argument #1 ($user) must be of type stdClass, bool given, called in \/moodle\/html\/moodle\/lib\/enrollib.php on line 3677"}

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

MDL-84996.png
260 kB
29/May/25 2:04 PM
Screenshot 2025-05-28 at 6.20.01 pm.png
91 kB
29/May/25 8:53 AM

has been marked as being related by

MDL-85572 PR only: MDL-84996 - PHP error while using enrol_manual_enrol_users web service with invalid users

Closed

is a regression caused by

MDL-64148 Information for user email templates should be consistent

Closed

Assignee:: Paul Holden

Reporter:: Fortiphyd

Peer reviewer:: Yusuf Wibisono

Integrator:: David Woloszyn

Tester:: Ron Carl Alfon Yu

Participants:: CiBoT, David Woloszyn, Fortiphyd, Michael Hawkins, Paul Holden, Ron Carl Alfon Yu, Yusuf Wibisono

Votes:: 0 Vote for this issue

Watchers:: 8 Start watching this issue

Created:: 25/Mar/25 3:35 AM

Updated:: 30/May/25 5:07 PM

Resolved:: 30/May/25 5:07 PM

Estimated:

Not Specified

Remaining:

Logged:

4h 20m

Details

Setup

Test valid user

Test invalid user

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify