Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.5.4
Affects Version/s: 4.5.4, 5.0
Component/s: Quiz, Themes
Labels:
- ci
- hqteam_moppies
- triaged
- ui_change

Affected Branches:
MOODLE_405_STABLE, MOODLE_500_STABLE
Fixed Branches:
MOODLE_405_STABLE
Pull from Repository:
https://github.com/sarjona/moodle.git
Pull 4.5 Branch:
~~MDL-84980~~-405
Pull 4.5 Diff URL:
https://github.com/sarjona/moodle/compare/f501225d0f...MDL-84980-405?w=1
Pull Main Branch:
~~MDL-84980~~-main
Pull Main Diff URL:
https://github.com/sarjona/moodle/compare/89d76fdc25...MDL-84980-main?w=1
Testing Instructions:
Hide

Scenario 1. Quiz

Login as admin.

Create a course.

Create a quiz and go to the Questions tab.

Add a couple of questions (True/False are the easier ones to create, but any of them are OK).

Click the x to remove the page break between both questions.

Check a + icon is displayed to add a page break.

Scenario 2. Component library

Run

grunt componentlibrary

Login as admin

Go to Site administration > Development > UI Component library

Search for the icons page and load it (admin/tool/componentlibrary/docspage.php/moodle/components/moodle-icons)

Check the icon for core:e/insert_page_break is now a +.
Show
Scenario 1. Quiz Login as admin. Create a course. Create a quiz and go to the Questions tab. Add a couple of questions (True/False are the easier ones to create, but any of them are OK). Click the x to remove the page break between both questions. Check a + icon is displayed to add a page break. Scenario 2. Component library Run grunt componentlibrary Login as admin Go to Site administration > Development > UI Component library Search for the icons page and load it (admin/tool/componentlibrary/docspage.php/moodle/components/moodle-icons) Check the icon for core:e/insert_page_break is now a +.
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-84980~~ using repository: https://github.com/sarjona/moodle.git

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-84980-405 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-84980-main | CI Job]

_{More information about this report}

Built on: Mon Mar 24 13:48:10 UTC 2025
Show
Code verified against automated checks. Checked MDL-84980 using repository: https://github.com/sarjona/moodle.git MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-84980-405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-84980-main | CI Job ] More information about this report Built on: Mon Mar 24 13:48:10 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-84980~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18769/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64294/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64295/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-84980~~-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18770/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64296/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64297/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64298/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64299/ App tests (stable app version)

Built on: Mon Mar 24 14:25:22 UTC 2025
Show
Launching automatic jobs for branch MDL-84980 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18769/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64294/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64295/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-84980 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18770/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64296/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64297/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64298/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64299/ App tests (stable app version) Built on: Mon Mar 24 14:25:22 UTC 2025

Story Points:
1
Sprint:
HQ 2025 Sprint I1.3 Moppies

As noticed by timhunt on ~~MDLQA-19913~~, the new icons for adding and removing page breaks on quiz have been changed but new icons are not very user friendly as the previous icon:

Before	After

These icons have been changed by ~~MDL-82497~~ so the goal here is to review those icons and maybe find alternative icons for that feature.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

MDL-84980.png
03/Apr/25 5:01 PM
304 kB
Ron Carl Alfon Yu
MDL-84980 - after.png
24/Mar/25 11:07 AM
17 kB
Simey Lameze
MDL-84980 - before.png
24/Mar/25 11:07 AM
5 kB
Simey Lameze
Screenshot 2025-03-24 at 11.28.20.png
24/Mar/25 7:26 PM
98 kB
Sabina Abellan
Screenshot 2025-03-24 at 12.27.21.png
24/Mar/25 7:28 PM
62 kB
Sabina Abellan

Discovered while testing

MDLQA-19913 CLONE - A teacher can create new pages and delete empty pages from a quiz

Passed

has been marked as being related by

MDL-82497 Update icon_map with the latest icons from Font Awesome 6 (core)

Closed

mentioned in: Page Loading...

Assignee:: Sara Arjona (@sarjona)

Reporter:: Simey Lameze

Peer reviewer:: Carlos Escobedo

Integrator:: David Woloszyn

Tester:: Ron Carl Alfon Yu

Participants:: Carlos Escobedo, CiBoT, David Woloszyn, Huong Nguyen, Ron Carl Alfon Yu, Sabina Abellan, Sara Arjona (@sarjona), Simey Lameze, Tim Hunt

Votes:: 1 Vote for this issue

Watchers:: 10 Start watching this issue

Created:: 24/Mar/25 11:03 AM

Updated:: 05/Apr/25 1:57 PM

Resolved:: 04/Apr/25 11:42 PM

Estimated:

Remaining:

Logged:

3d 1h 13m

Details

Scenario 1. Quiz

Scenario 2. Component library

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify