Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-84965

Modernise the HTML in assignment messages

    • Icon: Improvement Improvement
    • Resolution: Unresolved
    • Icon: Minor Minor
    • None
    • 4.5.3, 5.0
    • Assignment

      To reproduce:

      1. Do something in Mod assign that leads to you getting an email (e.g. make a submission as a student.)
      2. View the source of the HTML email.
      3. Cry.

      It could be argued that this is a bug, but it has been like this for 13+ years (https://github.com/moodle/moodle/blame/main/mod/assign/locallib.php#L6437) and changing the HTML in emails is risky (e.g. https://stackoverflow.com/questions/4829254/best-practices-for-styling-html-emails was just the first thing I found on Google). Also, the fix done here builds on
      MDL-84733, so, all in all, I am doing this as an improvement, to avoid regressions no stable branches.

        1. email layout.PNG
          email layout.PNG
          22 kB
        2. unit tests.PNG
          unit tests.PNG
          24 kB
        3. changed css.PNG
          changed css.PNG
          106 kB

            timhunt Tim Hunt
            timhunt Tim Hunt
            Jayce Birrell Jayce Birrell
            Votes:
            2 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 hours, 6 minutes
                3h 6m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.