Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.4.8, 4.5.4
Affects Version/s: 4.4.7, 4.5.3
Component/s: Libraries, Report builder
Labels:

Affected Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Epic Link:
WP-805
Pull from Repository:
https://github.com/odeialba/moodle/
Pull 4.4 Branch:
~~MDL-84961~~-404
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...odeialba:moodle:MDL-84961-404?w=1
Pull 4.5 Branch:
~~MDL-84961~~-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...odeialba:moodle:MDL-84961-405?w=1
Pull Main Branch:
~~MDL-84961~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...odeialba:moodle:MDL-84961?w=1

Testing Instructions:

Hide

Manually apply the following change:

$ git diff

diff --git a/lib/tests/other/chartjstestpage.php b/lib/tests/other/chartjstestpage.php

index fc54f6e0472..f7ae4d2e022 100644

--- a/lib/tests/other/chartjstestpage.php

+++ b/lib/tests/other/chartjstestpage.php

@@ -122,7 +122,7 @@ $chart11->set_legend_options(['display' => false]);

 $chart11->add_series($sales);

 $chart11->set_labels($labels);

-echo $OUTPUT->render($chart);

+echo $OUTPUT->render_chart($chart, false);

 echo $OUTPUT->render($chart2);

 echo $OUTPUT->render($chart3);

 echo $OUTPUT->render($chart4);

Log in as admin
Navigate to <WWWROOT>lib/tests/other/chartjstestpage.php
Inspect Pie chart element
Confirm that there is no table in DOM under the chart
Confirm the rest of the charts on the page do have a table (press Show chart data)

Show

Manually apply the following change: $ git diff diff --git a/lib/tests/other/chartjstestpage.php b/lib/tests/other/chartjstestpage.php index fc54f6e0472..f7ae4d2e022 100644 --- a/lib/tests/other/chartjstestpage.php +++ b/lib/tests/other/chartjstestpage.php @@ -122,7 +122,7 @@ $chart11->set_legend_options(['display' => false]); $chart11->add_series($sales); $chart11->set_labels($labels); -echo $OUTPUT->render($chart); +echo $OUTPUT->render_chart($chart, false); echo $OUTPUT->render($chart2); echo $OUTPUT->render($chart3); echo $OUTPUT->render($chart4); Log in as admin Navigate to <WWWROOT>lib/tests/other/chartjstestpage.php Inspect Pie chart element Confirm that there is no table in DOM under the chart Confirm the rest of the charts on the page do have a table (press Show chart data )

Pre-check results:
Hide

Code verified against automated checks with warnings.

Checked ~~MDL-84961~~ using repository: https://github.com/odeialba/moodle/

MOODLE_404_STABLE (0 errors / 2 warnings) [branch: MDL-84961-404 | CI Job]

overview (0/0), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/2), gherkin (0/0),

MOODLE_405_STABLE (0 errors / 2 warnings) [branch: MDL-84961-405 | CI Job]

overview (0/0), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/2), gherkin (0/0),

main (0 errors / 2 warnings) [branch: MDL-84961 | CI Job]

overview (0/0), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/2), gherkin (0/0),

Should these errors be fixed?

Built on: Mon Mar 24 17:19:25 UTC 2025
Show
Code verified against automated checks with warnings. Checked MDL-84961 using repository: https://github.com/odeialba/moodle/ MOODLE_404_STABLE (0 errors / 2 warnings) [branch: MDL-84961-404 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/2) , gherkin (0/0) , MOODLE_405_STABLE (0 errors / 2 warnings) [branch: MDL-84961-405 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/2) , gherkin (0/0) , main (0 errors / 2 warnings) [branch: MDL-84961 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/2) , gherkin (0/0) , Should these errors be fixed? Built on: Mon Mar 24 17:19:25 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-84961~~-404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18773/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64308/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64309/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-84961~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18774/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64310/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64311/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-84961~~

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18775/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64312/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64313/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64314/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64315/ App tests (stable app version)

Built on: Mon Mar 24 18:26:02 UTC 2025
Show
Launching automatic jobs for branch MDL-84961 -404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18773/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64308/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64309/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-84961 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18774/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64310/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64311/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-84961 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18775/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64312/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64313/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64314/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64315/ App tests (stable app version) Built on: Mon Mar 24 18:26:02 UTC 2025

Story Points:
2
Sprint:
WP Sprint 2025-I1.4 (Clones)

See screenshot - when the chart is rendered, even when passing '"withtable": false' in the template context data, the table is still rendered:

This is a waste of resources to transfer and write what could potentially be a large amount of redundant data to the DOM that will never be seen by the user

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

(1) 5 Passed -- (Main)MDL-84961.png
03/Apr/25 1:06 PM
312 kB
Kim Jared Lucas
(1) 6 Passed -- (Main)MDL-84961.png
03/Apr/25 1:06 PM
76 kB
Kim Jared Lucas
Screenshot from 2025-03-21 08-49-11.png
21/Mar/25 4:55 PM
138 kB
Paul Holden

Assignee:: Odei Alba

Reporter:: Paul Holden

Peer reviewer:: Paul Holden

Integrator:: Shamim Rezaie

Tester:: Kim Jared Lucas

Participants:: CiBoT, Kim Jared Lucas, Odei Alba, Paul Holden, Shamim Rezaie

Votes:: 1 Vote for this issue

Watchers:: 7 Start watching this issue

Created:: 21/Mar/25 4:53 PM

Updated:: 04/Apr/25 11:42 PM

Resolved:: 04/Apr/25 11:42 PM

Estimated:

Remaining:

Logged:

3h 17m

Details

Description

Attachments

Attachments

Activity

People

Dates

Time Tracking

Clockify