Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-84948

Require language strings for plugin types be defined

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Unresolved
    • Icon: Minor Minor
    • None
    • 5.0
    • Administration, Language
    • MOODLE_500_STABLE
    • Hide
      1. Revert language string change from MDL-80984, e.g. for 'main': 

        $ git revert 08a02cce55

      2. Log in as admin
      3. Purge caches
      4. Navigate to Plugins > Plugins overview in site administration
      5. Confirm you see the following debugging: 

        Invalid get_string() identifier: 'type_gradepenalty_plural' or component 'core_plugin'. Perhaps you are missing $string['type_gradepenalty_plural'] = ''; in lang/en/core_plugin.php?

      6. Confirm you see other plugin types listed, e.g.:
        • Activity modules
        • Blocks
      7. Confirm you see other sub-plugin types listed, e.g.:
        • Assignment / Submission plugins
        • Multi-factor authentication / Factor types
      Show
      Revert language string change from MDL-80984 , e.g. for ' main ': $ git revert 08a02cce55 Log in as admin Purge caches Navigate to Plugins > Plugins overview in site administration Confirm you see the following debugging: Invalid get_string() identifier: 'type_gradepenalty_plural' or component 'core_plugin'. Perhaps you are missing $string['type_gradepenalty_plural'] = ''; in lang/en/core_plugin.php? Confirm you see other plugin types listed, e.g.: Activity modules Blocks Confirm you see other sub-plugin types listed, e.g.: Assignment / Submission plugins Multi-factor authentication / Factor types
    • Hide

      Code verified against automated checks.

      Checked MDL-84948 using repository: https://github.com/paulholden/moodle.git

      More information about this report

      Built on: Mon Jun 9 08:46:20 UTC 2025

      Show
      Code verified against automated checks. Checked MDL-84948 using repository: https://github.com/paulholden/moodle.git main (0 errors / 0 warnings) [branch: MDL-84948 | CI Job ] More information about this report Built on: Mon Jun 9 08:46:20 UTC 2025

      For all the reasons discussed in MDL-79266 (for subplugin types) we should do the same for plugin types to avoid masking bugs, and making for untranslatable interface elements when said type is missing required language strings

      For example, in MDL-80984 we missed the language strings for the new "gradepenalty" plugin type (fixed after the fact):

      We've also had this in the past with content bank in MDL-77794

        1. Screenshot from 2025-03-20 10-19-35.png
          Screenshot from 2025-03-20 10-19-35.png
          14 kB

            pholden Paul Holden
            pholden Paul Holden
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.