Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Major
Fix Version/s: 4.5.5, 5.0.1
Affects Version/s: 4.5 regressions, 4.5.3, 5.0
Component/s: Course
Labels:
- accessibility
- ci
- regression
- release_notes
- triaged

Affected Branches:
MOODLE_405_STABLE, MOODLE_500_STABLE
Fixed Branches:
MOODLE_405_STABLE, MOODLE_500_STABLE
Pull from Repository:
https://github.com/paulholden/moodle.git
Pull 4.5 Branch:
~~MDL-84941~~-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...paulholden:MDL-84941-405
Pull 5.0 Branch:
~~MDL-84941~~-500
Pull 5.0 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_500_STABLE...paulholden:MDL-84941-500
Pull Main Branch:
~~MDL-84941~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...paulholden:MDL-84941
Testing Instructions:
Hide

Log in as admin

Navigate to Plugins > Manage activities in site administration

Ensure Subsection is enabled (it is in 5.0 since ~~MDL-82034~~)

Create a course

Hover "Add activity" (the "+" icon) at the end of a section to add new content

Inspect the element

Confirm it has the aria-label attribute value "Insert content in section '<sectionname>'"

Add some activities to the section

Hover "Add activity" (the "+" icon) between activities to add new content

Inspect the element

Confirm it has the aria-label attribute value "Insert content before '<activityname>'"
Show
Log in as admin Navigate to Plugins > Manage activities in site administration Ensure Subsection is enabled (it is in 5.0 since MDL-82034 ) Create a course Hover "Add activity" (the "+" icon) at the end of a section to add new content Inspect the element Confirm it has the aria-label attribute value "Insert content in section '<sectionname>'" Add some activities to the section Hover "Add activity" (the "+" icon) between activities to add new content Inspect the element Confirm it has the aria-label attribute value "Insert content before '<activityname>'"
Pre-check results:
Hide

Code verified against automated checks with warnings.

Checked ~~MDL-84941~~ using repository: https://github.com/paulholden/moodle.git

MOODLE_405_STABLE (0 errors / 1 warnings) [branch: MDL-84941-405 | CI Job]

overview (0/1), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

Warn: The ~~MDL-84941~~-405 branch at https://github.com/paulholden/moodle.git has not been rebased recently (>20 days ago).

MOODLE_500_STABLE (0 errors / 0 warnings) [branch: MDL-84941-500 | CI Job]

main (0 errors / 1 warnings) [branch: MDL-84941 | CI Job]

overview (0/1), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

Warn: The ~~MDL-84941~~ branch at https://github.com/paulholden/moodle.git has not been rebased recently (>20 days ago).

Should these errors be fixed?

Built on: Mon Apr 28 10:32:07 UTC 2025
Show
Code verified against automated checks with warnings. Checked MDL-84941 using repository: https://github.com/paulholden/moodle.git MOODLE_405_STABLE (0 errors / 1 warnings) [branch: MDL-84941-405 | CI Job ] overview (0/1) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Warn: The MDL-84941 -405 branch at https://github.com/paulholden/moodle.git has not been rebased recently (>20 days ago). MOODLE_500_STABLE (0 errors / 0 warnings) [branch: MDL-84941-500 | CI Job ] main (0 errors / 1 warnings) [branch: MDL-84941 | CI Job ] overview (0/1) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Warn: The MDL-84941 branch at https://github.com/paulholden/moodle.git has not been rebased recently (>20 days ago). Should these errors be fixed? Built on: Mon Apr 28 10:32:07 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-84941~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18706/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64089/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64090/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-84941~~

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18707/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64091/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64092/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64093/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64094/ App tests (stable app version)

Built on: Thu Mar 20 10:25:55 UTC 2025
Show
Launching automatic jobs for branch MDL-84941 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18706/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64089/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64090/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-84941 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18707/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64091/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64092/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64093/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64094/ App tests (stable app version) Built on: Thu Mar 20 10:25:55 UTC 2025

Create a course in 'topics' format with several sections
Inspect the "Add content" buttons, they all have aria-label="Insert content before '0'"

This is coming from here

https://github.com/moodle/moodle/blob/main/course/classes/output/activitychooserbutton.php#L78
https://github.com/moodle/moodle/blob/main/course/templates/activitychooserbutton.mustache#L50

Added in ~~MDL-81767~~ in 4.5 when it was only used for modules. It looks like in 5.0 we started using this component for sections too

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

MDL-84941.png
263 kB
05/Jun/25 2:40 PM

is a regression caused by

MDL-81767 Add a mod_subsection button to the add activity button.

Closed

Assignee:: Paul Holden

Reporter:: Marina Glancy

Peer reviewer:: Carlos Escobedo

Integrator:: Jun Pataleta

Tester:: Ron Carl Alfon Yu

Participants:: Carlos Escobedo, CiBoT, Jun Pataleta, Marina Glancy, Paul Holden, Ron Carl Alfon Yu

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Created:: 20/Mar/25 12:30 AM

Updated:: 05/Jun/25 11:11 PM

Resolved:: 05/Jun/25 11:11 PM

Estimated:

Remaining:

Logged:

59m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify