Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.1.18, 4.3.12, 4.4.8, 4.5.4
Affects Version/s: 4.1.17, 4.3.11, 4.4.7, 4.5.3
Component/s: Backup
Labels:

Affected Branches:
MOODLE_401_STABLE, MOODLE_403_STABLE, MOODLE_404_STABLE, MOODLE_405_STABLE
Fixed Branches:
MOODLE_401_STABLE, MOODLE_403_STABLE, MOODLE_404_STABLE, MOODLE_405_STABLE
Pull from Repository:
https://github.com/HuongNV13/moodle.git
Pull 4.1 Branch:
~~MDL-84907~~-401
Pull 4.1 Diff URL:
https://github.com/HuongNV13/moodle/compare/b05bd11a84...MDL-84907-401?w=1
Pull 4.3 Branch:
~~MDL-84907~~-403
Pull 4.3 Diff URL:
https://github.com/HuongNV13/moodle/compare/49bf20af0b...MDL-84907-403?w=1
Pull 4.4 Branch:
~~MDL-84907~~-404
Pull 4.4 Diff URL:
https://github.com/HuongNV13/moodle/compare/a18c3ad13a...MDL-84907-404?w=1
Pull 4.5 Branch:
~~MDL-84907~~-405
Pull 4.5 Diff URL:
https://github.com/HuongNV13/moodle/compare/d15172627c...MDL-84907-405?w=1
Pull Main Branch:
~~MDL-84907~~-main
Pull Main Diff URL:
https://github.com/HuongNV13/moodle/compare/c64e967ce6...MDL-84907-main?w=1
Workaround:

Hide

Rollback to PCRE Library 10.44

Show
Rollback to PCRE Library 10.44
Testing Instructions:
Hide

Check your server's version of the PCRE extension. You can find this at admin/phpinfo.php. Then search for "PCRE Library Version".

If it's less than 10.45, then great! Run the following tests:

Manual

Create a course.

Create some quiz activities inside that course.

Create some questions inside that Quiz.

Verify that you can export the questions successfully.

Verify that you can backup the quiz activities.

Verify that you can backup the course.

Try to restore the course.

Verify that you can restore the course successfully.

Try to restore the quizzes.

Verify that you can restore the quiz activities.

Try to import the questions.

Verify that you can import the questions successfully.

h5. Automated tests

Verify the PHPUnit tests of core_backup_testsuite are passed

# If using MDK.

$ mdk phpunit -r -s core_backup

(Optional) Upgrade to PCRE >= 10.45

Update your system

If you're on Ubuntu, run "sudo apt update && sudo apt upgrade -y"

Make sure to restart your web server. e.g. "sudo service apache2 restart"

Check the PCRE Library Version again and see if it has upgraded to 10.45 or later.

If this is the case, perform the above manual and automated tests again using the upgraded PCRE version and confirm that everything still works well.
Show
Check your server's version of the PCRE extension. You can find this at admin/phpinfo.php. Then search for "PCRE Library Version". If it's less than 10.45, then great! Run the following tests: Manual Create a course. Create some quiz activities inside that course. Create some questions inside that Quiz. Verify that you can export the questions successfully. Verify that you can backup the quiz activities. Verify that you can backup the course. Try to restore the course. Verify that you can restore the course successfully. Try to restore the quizzes. Verify that you can restore the quiz activities. Try to import the questions. Verify that you can import the questions successfully. h5. Automated tests Verify the PHPUnit tests of core_backup_testsuite are passed # If using MDK. $ mdk phpunit -r -s core_backup (Optional) Upgrade to PCRE >= 10.45 Update your system If you're on Ubuntu, run " sudo apt update && sudo apt upgrade -y " Make sure to restart your web server. e.g. " sudo service apache2 restart " Check the PCRE Library Version again and see if it has upgraded to 10.45 or later. If this is the case, perform the above manual and automated tests again using the upgraded PCRE version and confirm that everything still works well.
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-84907~~ using repository: https://github.com/HuongNV13/moodle.git

MOODLE_401_STABLE (0 errors / 0 warnings) [branch: MDL-84907-401 | CI Job]

MOODLE_403_STABLE (0 errors / 0 warnings) [branch: MDL-84907-403 | CI Job]

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-84907-404 | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-84907-405 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-84907-main | CI Job]

_{More information about this report}

Built on: Mon Mar 24 00:30:34 UTC 2025
Show
Code verified against automated checks. Checked MDL-84907 using repository: https://github.com/HuongNV13/moodle.git MOODLE_401_STABLE (0 errors / 0 warnings) [branch: MDL-84907-401 | CI Job ] MOODLE_403_STABLE (0 errors / 0 warnings) [branch: MDL-84907-403 | CI Job ] MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-84907-404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-84907-405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-84907-main | CI Job ] More information about this report Built on: Mon Mar 24 00:30:34 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-84907~~-401

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18635/ PHPUnit (sqlsrv / --testsuite core_backup_testsuite)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63828/ Behat (NonJS - boost and classic / --tags @core_backup,@core_question)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63829/ Behat (Firefox - boost / --tags @core_backup,@core_question)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63830/ Behat (Firefox - classic / --tags @core_backup,@core_question)

Launching automatic jobs for branch ~~MDL-84907~~-403

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18636/ PHPUnit (sqlsrv / --testsuite core_backup_testsuite)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63831/ Behat (NonJS - boost and classic / --tags @core_backup,@core_question)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63832/ Behat (Firefox - boost / --tags @core_backup,@core_question)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63833/ Behat (Firefox - classic / --tags @core_backup,@core_question)

Launching automatic jobs for branch ~~MDL-84907~~-404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18637/ PHPUnit (sqlsrv / --testsuite core_backup_testsuite)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63834/ Behat (NonJS - boost and classic / --tags @core_backup,@core_question)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63835/ Behat (Firefox - boost / --tags @core_backup,@core_question)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63836/ Behat (Firefox - classic / --tags @core_backup,@core_question)

Launching automatic jobs for branch ~~MDL-84907~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18638/ PHPUnit (sqlsrv / --testsuite core_backup_testsuite)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63837/ Behat (NonJS - boost and classic / --tags @core_backup,@core_question)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63838/ Behat (Firefox - boost / --tags @core_backup,@core_question)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63839/ Behat (Firefox - classic / --tags @core_backup,@core_question)

Launching automatic jobs for branch ~~MDL-84907~~-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18639/ PHPUnit (sqlsrv / --testsuite core_backup_testsuite)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63840/ Behat (NonJS - boost and classic / --tags @core_backup,@core_question)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63841/ Behat (Firefox - boost / --tags @core_backup,@core_question)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63842/ Behat (Firefox - classic / --tags @core_backup,@core_question)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63843/ App tests (stable app version) / --tags @core_backup,@core_question)

Built on: Tue Mar 18 07:18:53 UTC 2025
Show
Launching automatic jobs for branch MDL-84907 -401 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18635/ PHPUnit (sqlsrv / --testsuite core_backup_testsuite) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63828/ Behat (NonJS - boost and classic / --tags @core_backup,@core_question) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63829/ Behat (Firefox - boost / --tags @core_backup,@core_question) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63830/ Behat (Firefox - classic / --tags @core_backup,@core_question) Launching automatic jobs for branch MDL-84907 -403 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18636/ PHPUnit (sqlsrv / --testsuite core_backup_testsuite) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63831/ Behat (NonJS - boost and classic / --tags @core_backup,@core_question) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63832/ Behat (Firefox - boost / --tags @core_backup,@core_question) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63833/ Behat (Firefox - classic / --tags @core_backup,@core_question) Launching automatic jobs for branch MDL-84907 -404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18637/ PHPUnit (sqlsrv / --testsuite core_backup_testsuite) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63834/ Behat (NonJS - boost and classic / --tags @core_backup,@core_question) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63835/ Behat (Firefox - boost / --tags @core_backup,@core_question) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63836/ Behat (Firefox - classic / --tags @core_backup,@core_question) Launching automatic jobs for branch MDL-84907 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18638/ PHPUnit (sqlsrv / --testsuite core_backup_testsuite) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63837/ Behat (NonJS - boost and classic / --tags @core_backup,@core_question) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63838/ Behat (Firefox - boost / --tags @core_backup,@core_question) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63839/ Behat (Firefox - classic / --tags @core_backup,@core_question) Launching automatic jobs for branch MDL-84907 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18639/ PHPUnit (sqlsrv / --testsuite core_backup_testsuite) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63840/ Behat (NonJS - boost and classic / --tags @core_backup,@core_question) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63841/ Behat (Firefox - boost / --tags @core_backup,@core_question) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63842/ Behat (Firefox - classic / --tags @core_backup,@core_question) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63843/ App tests (stable app version) / --tags @core_backup,@core_question) Built on: Tue Mar 18 07:18:53 UTC 2025

Story Points:
2

We have below regex in Moodle backup code to clean the CTRL characters

/[\x-\x8\xb-\xc\xe-\x1f\x7f]/is

But in PHP (PCRE), \x is used to define hexadecimal escape sequences (e.g.: \x00 for NUL), and \x- is incorrect since - is not a valid hexadecimal digit.

This broke the backup/restore process in Moodle with the latest PHP versions. Example: 8.2.28 and 8.3.19

They might include PCRE library version: 10.45 2025-02-05. This PCRE introduces a breaking change:

https://github.com/PCRE2Project/pcre2/blob/master/ChangeLog#L119

We can see the error by running

vendor/bin/phpunit --filter test_restore_controller_is_executing

Error

1) core_backup\controller_test::test_restore_controller_is_executing

restore_controller_exception: error/restore_unknown_restore_type

$a contents:

I used XDebug and PPHPUnit to find out the root cause, below is the extra error

preg_replace(): Compilation failed: digits missing after \x or in \x{} or \o{} or \N{U+} at offset 3

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

(1) 10 Passed -- (Main)MDL-84907.png
71 kB
04/Apr/25 3:41 PM
(1) 12 Passed -- (Main)MDL-84907.png
68 kB
04/Apr/25 3:41 PM
(1) 4 Passed -- (Main)MDL-84907.png
75 kB
04/Apr/25 3:41 PM
(1) 5 Passed -- (Main)MDL-84907.png
78 kB
04/Apr/25 3:41 PM
(1) 6 Passed -- (Main)MDL-84907.png
115 kB
04/Apr/25 3:41 PM
(1) 8 Passed -- (Main)MDL-84907.png
65 kB
04/Apr/25 3:41 PM
(2) 1 Passed -- (Main)MDL-84907.png
64 kB
04/Apr/25 3:41 PM

has been marked as being related by

MDL-84946 PR only: MDL-84470 - Backup: Incorrect regex for CTRL characters cleaning

Closed

MDL-84962 PR only: MDL-84907 - Backup: Incorrect regex for CTRL characters cleaning

Closed

Assignee:: Huong Nguyen

Reporter:: Huong Nguyen

Peer reviewer:: Meirza

Integrator:: Jun Pataleta

Tester:: Kim Jared Lucas

Participants:: CiBoT, Huong Nguyen, iddqd, Jun Pataleta, Kim Jared Lucas, Meirza

Votes:: 2 Vote for this issue

Watchers:: 12 Start watching this issue

Created:: 18/Mar/25 1:34 PM

Updated:: 01/May/25 12:29 PM

Resolved:: 04/Apr/25 11:42 PM

Estimated:

Not Specified

Remaining:

Logged:

1d 25m

Details

Manual

(Optional) Upgrade to PCRE >= 10.45

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify