Loading...

XML

Word

Printable

Type: Improvement
Resolution: Fixed
Priority: Minor
Fix Version/s: 5.0
Affects Version/s: 4.4.6, 4.5.2, 5.0
Component/s: Libraries
Labels:
- ci

Affected Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE, MOODLE_500_STABLE
Fixed Branches:
MOODLE_500_STABLE
Pull from Repository:
https://github.com/timhunt/moodle.git
Pull Main Branch:
~~MDL-84846~~
Pull Main Diff URL:
https://github.com/timhunt/moodle/compare/main...MDL-84846
Testing Instructions:

Hide

Covered by automated tests.

Show
Covered by automated tests.
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-84846~~ using repository: https://github.com/timhunt/moodle.git

main (0 errors / 0 warnings) [branch: MDL-84846 | CI Job]

_{More information about this report}

Built on: Tue Mar 18 14:16:10 UTC 2025
Show
Code verified against automated checks. Checked MDL-84846 using repository: https://github.com/timhunt/moodle.git main (0 errors / 0 warnings) [branch: MDL-84846 | CI Job ] More information about this report Built on: Tue Mar 18 14:16:10 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-84846~~

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18640/ PHPUnit (sqlsrv / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63855/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63856/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63857/ Behat (Firefox - classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63858/ App tests (stable app version) / complete)

Built on: Tue Mar 18 08:54:48 UTC 2025
Show
Launching automatic jobs for branch MDL-84846 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18640/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63855/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63856/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63857/ Behat (Firefox - classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63858/ App tests (stable app version) / complete) Built on: Tue Mar 18 08:54:48 UTC 2025

At the moment, when a lock is claimed, but not relesed, you get an error like (e.g. from MDL-84695):

Message:  Coding error detected, it must be fixed by a programmer:     A lock was created but not released at: /var/www/html/lib/classes/task/manager.php on line 831

but, of course, that is not helpful at all. So, one secheduled task did something wrong, but which one?

I think we need to change it to have a full stack trace.

Also, currently the code was trying to only throw exceptions about un-released locks during PHPunit tests. However, I am pretty sure defined('PHPUNIT_TEST') is alwasy true. Anyway, I changed that to defined('BEHAT_SITE_RUNNING') || PHPUNIT_TEST || $CFG->debugdeveloper which I think is better.

Discovered while testing

MDL-84695 get_qbank_ids_of_type_in_course also yields modules of other types

Waiting for peer review

Assignee:: Tim Hunt

Reporter:: Tim Hunt

Peer reviewer:: Daniel Ziegenberg

Integrator:: Jun Pataleta

Tester:: CiBoT

Participants:: CiBoT, Daniel Ziegenberg, Huong Nguyen, Jun Pataleta, Neill Magill, Tim Hunt

Votes:: 2 Vote for this issue

Watchers:: 5 Start watching this issue

Created:: 12/Mar/25 10:59 PM

Updated:: 21/Mar/25 11:25 PM

Resolved:: 21/Mar/25 11:25 PM

Estimated:

Remaining:

Logged:

37m

Details

Description

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify