Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-84820

MoodleNet: Bootstrap upgrade broke sharing Modal

XMLWordPrintable

    • MOODLE_404_STABLE, MOODLE_405_STABLE
    • MOODLE_404_STABLE, MOODLE_405_STABLE, MOODLE_500_STABLE
    • MDL-84820-404
    • MDL-84820-405
    • Hide

      Note: we don't need a full blown Moodlenet deployment to test this, we can use the template library to assert visual elements

      1. Manually apply the following change:

        $ git diff
        diff --git a/lib/templates/moodlenet/send_activity_modal_base.mustache b/lib/templates/moodlenet/send_activity_modal_base.mustache
        index ff2521e5660..556c2200d57 100644
        --- a/lib/templates/moodlenet/send_activity_modal_base.mustache
        +++ b/lib/templates/moodlenet/send_activity_modal_base.mustache
        @@ -36,21 +36,7 @@
                         <button type="button" class="btn-close" data-action="hide" aria-label="{{#cleanstr}}closebuttontitle{{/cleanstr}}"></button>
                     </div>
                     <div class="modal-body" data-region="body">
        -                <div class="moodlenet-share-modal-content">
        -                    <div class="moodlenet-share-activity-info">
        -                        <span class="moodlenet-activity-type text-uppercase">{{activitytype}}</span>
        -                        <span class="moodlenet-activity-name">{{activityname}}</span>
        -                    </div>
        -                    <hr class="moodlenet-share-activity-info-hr">
        -                    <div class="moodlenet-share-notice">
        -                        {{sharenotice}}
        -                    </div>
        -                    {{^fullsharing}}
        -                        <div class="moodlenet-share-total-activities fw-bold ps-2 ms-3">
        -                            {{selectedactivitiesnotice}}
        -                        </div>
        -                    {{/fullsharing}}
        -                </div>
        +                {{> core/moodlenet/send_activity_modal_done }}
                     </div>
                     <div class="modal-footer" data-region="footer">
                         {{> core/moodlenet/send_activity_modal_footer_share }}
        

      2. Log in as admin
      3. Navigate to Development > Template library in site administration
      4. Search for "moodlenet"
      5. Press on core/moodlenet/send_activity_modal_base
      6. Use your browser inspector to inspect the Example template render
      7. Locate the "modal" class (it will be an immediate descendant of the "displaytemplateexample" container)
      8. Use your browser tools to remove the display: none attribute of the modal
      9. Confirm the MoodleNet logo in the top-left corner of the modal is appropriately sized
      10. Confirm the red cross icon is horizontally centred within the red circle
      Show
      Note: we don't need a full blown Moodlenet deployment to test this, we can use the template library to assert visual elements Manually apply the following change: $ git diff diff --git a/lib/templates/moodlenet/send_activity_modal_base.mustache b/lib/templates/moodlenet/send_activity_modal_base.mustache index ff2521e5660..556c2200d57 100644 --- a/lib/templates/moodlenet/send_activity_modal_base.mustache +++ b/lib/templates/moodlenet/send_activity_modal_base.mustache @@ -36,21 +36,7 @@ <button type="button" class="btn-close" data-action="hide" aria-label="{{#cleanstr}}closebuttontitle{{/cleanstr}}"></button> </div> <div class="modal-body" data-region="body"> - <div class="moodlenet-share-modal-content"> - <div class="moodlenet-share-activity-info"> - <span class="moodlenet-activity-type text-uppercase">{{activitytype}}</span> - <span class="moodlenet-activity-name">{{activityname}}</span> - </div> - <hr class="moodlenet-share-activity-info-hr"> - <div class="moodlenet-share-notice"> - {{sharenotice}} - </div> - {{^fullsharing}} - <div class="moodlenet-share-total-activities fw-bold ps-2 ms-3"> - {{selectedactivitiesnotice}} - </div> - {{/fullsharing}} - </div> + {{> core/moodlenet/send_activity_modal_done }} </div> <div class="modal-footer" data-region="footer"> {{> core/moodlenet/send_activity_modal_footer_share }} Log in as admin Navigate to Development > Template library in site administration Search for "moodlenet" Press on core/moodlenet/send_activity_modal_base Use your browser inspector to inspect the Example template render Locate the "modal" class (it will be an immediate descendant of the "displaytemplateexample" container) Use your browser tools to remove the display: none attribute of the modal Confirm the MoodleNet logo in the top-left corner of the modal is appropriately sized Confirm the red cross icon is horizontally centred within the red circle
    • Hide

      Code verified against automated checks.

      Checked MDL-84820 using repository: https://github.com/paulholden/moodle.git

      More information about this report

      Built on: Wed Mar 19 16:58:38 UTC 2025

      Show
      Code verified against automated checks. Checked MDL-84820 using repository: https://github.com/paulholden/moodle.git MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-84820-404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-84820-405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-84820 | CI Job ] More information about this report Built on: Wed Mar 19 16:58:38 UTC 2025
    • Show
      Launching automatic jobs for branch MDL-84820 -404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18683/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64000/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64001/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-84820 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18684/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64002/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64003/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-84820 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18685/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64004/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64005/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64006/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64007/ App tests (stable app version) Built on: Wed Mar 19 16:26:02 UTC 2025
    • HQ 2025 Sprint I1.3 Moppies

      The upgrade to Bootstrap 5.3 in MDL-75669 has broken the share dialogue of the MoodleNet outbound feature.

      We need to fix the MoodleNet logo and check icon

            pholden Paul Holden
            huongn@moodle.com Huong Nguyen
            Mikel Martín Corrales Mikel Martín Corrales
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            Ferran Recio Ferran Recio
            Votes:
            0 Vote for this issue
            Watchers:
            9 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 days, 2 hours, 37 minutes
                2d 2h 37m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.