Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 5.0.1
Affects Version/s: 5.0
Component/s: AI
Labels:

Affected Branches:
MOODLE_500_STABLE
Fixed Branches:
MOODLE_500_STABLE
Pull from Repository:
https://github.com/davewoloszyn/moodle.git
Pull 5.0 Branch:
~~MDL-84751~~-500
Pull 5.0 Diff URL:
https://github.com/davewoloszyn/moodle/compare/6999197243...MDL-84751-500
Pull Main Branch:
~~MDL-84751~~-main
Pull Main Diff URL:
https://github.com/davewoloszyn/moodle/compare/9242f9619a...MDL-84751-main
Testing Instructions:
Hide

Log in as admin

Go to Site admin -> General -> AI -> AI providers

Click 'Create a new provider instance'

Choose 'OpenAI API provider' and fill out all other required values (valid API is not needed)

Click 'Create instance'

Click on 'Settings' in the new created provider table row

Under the 'Action settings' heading, click on an action's 'Settings' link

Locate the settings help text that sits underneath the 'Settings' heading.

CONFIRM that the settings help text is wrapped in a 'p' tag (use your browser's inspector)

Do the same for all actions.

Create a new instance provider for 'Ollama API Provider' and confirming spacing for all of the provider's actions (steps 6-10).

NOTE: AzureAI does not have this same settings_help string.
Show
Log in as admin Go to Site admin -> General -> AI -> AI providers Click 'Create a new provider instance' Choose 'OpenAI API provider' and fill out all other required values (valid API is not needed) Click 'Create instance' Click on 'Settings' in the new created provider table row Under the 'Action settings' heading, click on an action's 'Settings' link Locate the settings help text that sits underneath the 'Settings' heading. CONFIRM that the settings help text is wrapped in a 'p' tag (use your browser's inspector) Do the same for all actions. Create a new instance provider for 'Ollama API Provider' and confirming spacing for all of the provider's actions (steps 6-10). NOTE: AzureAI does not have this same settings_help string.
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-84751~~ using repository: https://github.com/davewoloszyn/moodle.git

MOODLE_500_STABLE (0 errors / 0 warnings) [branch: MDL-84751-500 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-84751-main | CI Job]

_{More information about this report}

Built on: Tue May 13 03:57:30 UTC 2025
Show
Code verified against automated checks. Checked MDL-84751 using repository: https://github.com/davewoloszyn/moodle.git MOODLE_500_STABLE (0 errors / 0 warnings) [branch: MDL-84751-500 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-84751-main | CI Job ] More information about this report Built on: Tue May 13 03:57:30 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-84751~~-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18578/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63651/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63652/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63653/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63654/ App tests (stable app version)

Built on: Thu Mar 13 14:25:14 UTC 2025
Show
Launching automatic jobs for branch MDL-84751 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18578/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63651/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63652/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63653/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63654/ App tests (stable app version) Built on: Thu Mar 13 14:25:14 UTC 2025

Story Points:
1
Sprint:
Team Hedgehogs 2025 Sprint 1.3, Team Hedgehogs 2025 Sprint 1.4, Team Hedgehogs 2025 Sprint 2.0

Currently most AI provider plugins have a string `$string['settings_help']` that has two line breaks (<br><br>) at the end of the string to space the string out when it is rendered on the action model settings page.

These line breaks exist to space out the help description from the settings below.
These breaks should be removed from the string and the text that is rendered should have a bottom margin/padding done via the form rendering or template.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

Screenshot 2025-03-06 at 17-59-46 Generate text action settings Moodle Demo.png
48 kB
06/Mar/25 3:03 PM
(1) 9 Passed -- (Main)MDL-84751.png
167 kB
14/May/25 5:03 PM

blocks

MDL-82731 AI: Provider Plugin - AWS Bedrock

Reopened

Assignee:: David Woloszyn

Reporter:: Matt Porritt

Peer reviewer:: Raquel Ortega

Integrator:: Huong Nguyen

Tester:: Kim Jared Lucas

Participants:: CiBoT, David Woloszyn, Huong Nguyen, Jun Pataleta, Kim Jared Lucas, Matt Porritt, Raquel Ortega

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Created:: 06/Mar/25 3:02 PM

Updated:: 21/May/25 12:12 AM

Resolved:: 16/May/25 1:44 PM

Estimated:

Not Specified

Remaining:

Logged:

3h 17m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify