Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.5.3
Affects Version/s: 4.5
Component/s: Questions
Labels:
- ci
- triaged

Affected Branches:
MOODLE_405_STABLE
Fixed Branches:
MOODLE_405_STABLE
Pull from Repository:
https://github.com/junpataleta/moodle.git
Pull 4.5 Branch:
~~MDL-84737~~-405
Pull 4.5 Diff URL:
https://github.com/junpataleta/moodle/compare/76b8b81458...MDL-84737-405
Pull Main Branch:
~~MDL-84737~~-main
Pull Main Diff URL:
https://github.com/junpataleta/moodle/compare/5670447ece...MDL-84737-main
Testing Instructions:
Hide

Open a terminal and go to your Moodle instance's root folder.

Run the following commands:

nvm use

npm install

npx grunt css

Confirm that you no longer get any stylelint warning about the max-line-length rule violation
Show
Open a terminal and go to your Moodle instance's root folder. Run the following commands: nvm use npm install npx grunt css Confirm that you no longer get any stylelint warning about the max-line-length rule violation
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-84737~~ using repository: https://github.com/junpataleta/moodle.git

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-84737-405 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-84737-main | CI Job]

_{More information about this report}

Built on: Wed Mar 5 13:59:05 UTC 2025
Show
Code verified against automated checks. Checked MDL-84737 using repository: https://github.com/junpataleta/moodle.git MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-84737-405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-84737-main | CI Job ] More information about this report Built on: Wed Mar 5 13:59:05 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-84737~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18413/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63085/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63086/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-84737~~-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18414/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63087/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63088/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63089/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63090/ App tests (stable app version)

Built on: Wed Mar 5 14:25:19 UTC 2025
Show
Launching automatic jobs for branch MDL-84737 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18413/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63085/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63086/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-84737 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18414/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63087/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63088/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63089/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63090/ App tests (stable app version) Built on: Wed Mar 5 14:25:19 UTC 2025

When running grunt css, I get the following warning:

Running "stylelint:css" (stylelint) task

>> question/bank/managecategories/styles.css

>>  85:190  ⚠  Expected line length to be no more than 132 characters  max-line-length

>>

>> 1 problem (0 errors, 1 warning)

A quick fix is to disable the max-line-length rule for the affected line.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

(1) 3 Passed -- (Main)MDL-84737.png
40 kB
07/Mar/25 10:40 AM

Assignee:: Jun Pataleta

Reporter:: Jun Pataleta

Peer reviewer:: Tim Hunt

Integrator:: Huong Nguyen

Tester:: Kim Jared Lucas

Participants:: Huong Nguyen, Jun Pataleta, Kim Jared Lucas, Tim Hunt

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Created:: 05/Mar/25 11:26 AM

Updated:: 10/Mar/25 4:36 PM

Resolved:: 08/Mar/25 12:17 PM

Estimated:

Not Specified

Remaining:

Logged:

51m

Details

Description

Attachments

Attachments

Activity

People

Dates

Time Tracking

Clockify