Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-84676

Final deprecation of long-standing emitting functions

    • Icon: Task Task
    • Resolution: Unresolved
    • Icon: Minor Minor
    • None
    • 4.5
    • General
    • MOODLE_405_STABLE
    • MDL-84676_final-deprecation-of-long-standing-emitting-functions
    • Hide
      1. Execute the following:

        git grep -n -C3 -P 'setShowAdvanced\('
        git grep -n -C3 -P 'getShowAdvanced\('
        git grep -n -C3 -P 'course_category_tree\(' -- ':!lib/upgrade.txt' ':!theme/upgrade.txt'
        git grep -n -C3 -P 'course_category_tree_category\(' -- ':!theme/upgrade.txt'
        git grep -n -C3 -P 'deprecated_constructor\('
        git grep -n -C3 -P 'print_continue\(' -- ':!lib/upgrade.txt'
        git grep -n -C3 -P 'blank_hidden_total\('
        git grep -n -C3 -P 'drop_temp_table\('
        git grep -n -C3 -P 'change_field_unsigned\('
        git grep -n -C3 -P '(?<!helper::)get_string_from_input\(' -- ':!admin/tool/usertours/classes/helper.php'
        git grep -n -C3 -P '[>\s]+save_files\(' -- ':!question/engine/datalib.php'
        git grep -n -C3 -P 'display_preview\(' -- ':!*statistics*' ':!question'
        

      2. Confirm that the only matches are the original methods and functions (which emit a final deprecation notice) and upgrade notes regarding the removal
      3. Execute the following:

        git grep -n -C3 -P '[>\s]+can_view\(' -- ':!*reportbuilder*' ':!*recyclebin*' ':!*customfield*' ':!*comment*'
        

      4. Confirm that the only matches are the original methods and functions (which emit a final deprecation notice) and upgrade notes regarding the removal. There are a few false positives.
      Show
      Execute the following: git grep -n -C3 -P 'setShowAdvanced\(' git grep -n -C3 -P 'getShowAdvanced\(' git grep -n -C3 -P 'course_category_tree\(' -- ':!lib/upgrade.txt' ':!theme/upgrade.txt' git grep -n -C3 -P 'course_category_tree_category\(' -- ':!theme/upgrade.txt' git grep -n -C3 -P 'deprecated_constructor\(' git grep -n -C3 -P 'print_continue\(' -- ':!lib/upgrade.txt' git grep -n -C3 -P 'blank_hidden_total\(' git grep -n -C3 -P 'drop_temp_table\(' git grep -n -C3 -P 'change_field_unsigned\(' git grep -n -C3 -P '(?<!helper::)get_string_from_input\(' -- ':!admin/tool/usertours/classes/helper.php' git grep -n -C3 -P '[>\s]+save_files\(' -- ':!question/engine/datalib.php' git grep -n -C3 -P 'display_preview\(' -- ':!*statistics*' ':!question' Confirm that the only matches are the original methods and functions (which emit a final deprecation notice) and upgrade notes regarding the removal Execute the following: git grep -n -C3 -P '[>\s]+can_view\(' -- ':!*reportbuilder*' ':!*recyclebin*' ':!*customfield*' ':!*comment*' Confirm that the only matches are the original methods and functions (which emit a final deprecation notice) and upgrade notes regarding the removal. There are a few false positives.
    • Hide

      Code verified against automated checks.

      Checked MDL-84676 using repository: https://github.com/ziegenberg/moodle

      More information about this report

      Built on: Tue Apr 29 14:40:49 UTC 2025

      Show
      Code verified against automated checks. Checked MDL-84676 using repository: https://github.com/ziegenberg/moodle main (0 errors / 0 warnings) [branch: MDL-84676_final-deprecation-of-long-standing-emitting-functions | CI Job ] More information about this report Built on: Tue Apr 29 14:40:49 UTC 2025

      Now that we have a new deprecation policy it's time to update any long-standing emitting methods to be final.

            Daniel Ziegenberg Daniel Ziegenberg
            Daniel Ziegenberg Daniel Ziegenberg
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.