Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-84662

Event user_loggedout does not contain correct realuserid

XMLWordPrintable

      It has taken some time to understand this issue, however, I think we've got it now.

      If you are imitating an account, there is an issue with the fact the buffered writer (tool\log\classes\helper\buffered_writer) tries to retrieve the realuser just after it was destroyed.

      Meaning the wrong information is written to the log in the end.

      The issue is caused by the fact the $event->trigger() for the require_logout() takes place just after the session manager terminates the current session, meaning it has destroyed the data the buffered_writer wants to write, causing it to revert to null.

      Aka, the wrong details eventually end up in the logs.

       

      The fix is pretty simple, as it would be enough to just trigger the event before the session is terminated, which should make sure the realuserid is stored correctly while maintaining the rest of the flow.

        1. image-2025-03-03-11-43-43-438.png
          image-2025-03-03-11-43-43-438.png
          21 kB

            Unassigned Unassigned
            sebsoft Sebastian Berm
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 21 minutes
                21m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.