Loading...

XML

Word

Printable

Type: Task
Resolution: Fixed
Priority: Minor
Fix Version/s: 5.0
Affects Version/s: 4.5
Component/s: Calendar
Labels:

Affected Branches:
MOODLE_405_STABLE
Fixed Branches:
MOODLE_500_STABLE
Epic Link:
5.0 deprecations
Pull from Repository:
https://github.com/ziegenberg/moodle
Pull Main Branch:
~~MDL-84657~~_deprecate-calendar_add_month
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...ziegenberg:MDL-84657_deprecate-calendar_add_month
Testing Instructions:
Hide

On the dashboard open the "Full calendar"

Add a new event

Click "Import or export calendars"

Click "Export calendar"

Select "All events" and "This week"

Click "Export"

Confirm the exported file contains the created event
Show
On the dashboard open the "Full calendar" Add a new event Click " Import or export calendars " Click " Export calendar " Select " All events " and " This week " Click " Export " Confirm the exported file contains the created event
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-84657~~ using repository: https://github.com/ziegenberg/moodle

main (0 errors / 0 warnings) [branch: MDL-84657_deprecate-calendar_add_month | CI Job]

_{More information about this report}

Built on: Wed Mar 12 00:26:14 UTC 2025
Show
Code verified against automated checks. Checked MDL-84657 using repository: https://github.com/ziegenberg/moodle main (0 errors / 0 warnings) [branch: MDL-84657_deprecate-calendar_add_month | CI Job ] More information about this report Built on: Wed Mar 12 00:26:14 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-84657~~_deprecate-calendar_add_month

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63374/ Behat (NonJS - boost and classic / --tags @core_calendar)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63375/ Behat (Firefox - boost / --tags @core_calendar)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63376/ Behat (Firefox - classic / --tags @core_calendar)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63377/ App tests (stable app version) / --tags @core_calendar)

Built on: Mon Mar 10 23:19:32 UTC 2025
Show
Launching automatic jobs for branch MDL-84657 _deprecate-calendar_add_month https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63374/ Behat (NonJS - boost and classic / --tags @core_calendar) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63375/ Behat (Firefox - boost / --tags @core_calendar) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63376/ Behat (Firefox - classic / --tags @core_calendar) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63377/ App tests (stable app version) / --tags @core_calendar) Built on: Mon Mar 10 23:19:32 UTC 2025

In ~~MDL-79434~~ we deprecated calendar_sub_month(), which internally just called \core_calendar\type_factory::get_calendar_instance()~~>get_prev_month(...)~~. Following this, we can easily replace calendar_add_month() with \core_calendar\type_factory::get_calendar_instance()>get_next_month(...) too, and get another calendar lib function from the global space to the core_calendar API.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

(1) 7 Passed -- (Main)MDL-84657.png
140 kB
13/Mar/25 10:00 AM

has to be done after

MDL-79434 Final deprecation of calendar functions deprecated in Moodle 4.3

Closed

has to be done before

MDL-84655 Final deprecation of calendar_sub/add_month()

Open

Testing discovered

MDL-84788 Exporting a calendar with time period "This week" fails on 5th and 6th of the month

Development in progress

Assignee:: Daniel Ziegenberg

Reporter:: Daniel Ziegenberg

Peer reviewer:: Raquel Ortega

Integrator:: Huong Nguyen

Tester:: Kim Jared Lucas

Participants:: CiBoT, Daniel Ziegenberg, Huong Nguyen, Kim Jared Lucas, Raquel Ortega, Safat Shahin, Simey Lameze

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Created:: 26/Feb/25 6:33 PM

Updated:: 11/Apr/25 6:01 PM

Resolved:: 14/Mar/25 11:30 PM

Estimated:

Not Specified

Remaining:

Logged:

3h 5m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify