Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 5.0
Affects Version/s: 5.0
Component/s: Themes
Labels:
- ci
- hqteam_moppies
- regression
- triaged

Affected Branches:
MOODLE_500_STABLE
Fixed Branches:
MOODLE_500_STABLE
Epic Link:
Bootstrap 5.x Upgrade
Pull from Repository:
https://github.com/roland04/moodle.git
Pull Main Branch:
~~MDL-84618~~-main
Pull Main Diff URL:
https://github.com/roland04/moodle/compare/5670447ece...MDL-84618-main
Testing Instructions:
Hide

Login as administrator

Create a course with some 'Visible groups' activity.

Access the course on edit mode.

Confirm that focus styles are displayed as the following (See arrowed elements in the screenshot):
Show
Login as administrator Create a course with some 'Visible groups' activity. Access the course on edit mode. Confirm that focus styles are displayed as the following (See arrowed elements in the screenshot):
Pre-check results:
Hide

Code verified against automated checks with warnings.

Checked ~~MDL-84618~~ using repository: https://github.com/roland04/moodle.git

main (0 errors / 1 warnings) [branch: MDL-84618-main | CI Job]

overview (0/0), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/1), gherkin (0/0),

Should these errors be fixed?

Built on: Tue Mar 4 07:48:04 UTC 2025
Show
Code verified against automated checks with warnings. Checked MDL-84618 using repository: https://github.com/roland04/moodle.git main (0 errors / 1 warnings) [branch: MDL-84618-main | CI Job ] overview (0/0) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/1) , gherkin (0/0) , Should these errors be fixed? Built on: Tue Mar 4 07:48:04 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-84618~~-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18384/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63027/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62968/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62969/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62970/ App tests (stable app version)

Built on: Fri Feb 28 12:26:19 UTC 2025
Show
Launching automatic jobs for branch MDL-84618 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18384/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63027/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62968/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62969/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62970/ App tests (stable app version) Built on: Fri Feb 28 12:26:19 UTC 2025

Story Points:
2
Sprint:
HQ 2025 Sprint I1.2 Moppies

After Bootstrap 5 upgrade, buttons that only have the .btn helper class but no .btn-<colour> class are missing the focus styles.
That happened because in BS5 .btn class does not have focus styles anymore.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

(4) 1 Passed -- (Main)MDL-84618.png
99 kB
06/Mar/25 10:24 AM
screenshot-1.png
116 kB
27/Feb/25 11:34 PM

caused a regression

MDL-84790 Alignment of action items is off centre

Closed

is a regression caused by

MDL-75669 Upgrade the Boost theme with Bootstrap 5.x

Closed

Assignee:: Mikel Martín Corrales

Reporter:: Mikel Martín Corrales

Peer reviewer:: Carlos Escobedo

Integrator:: Amaia Anabitarte

Tester:: Kim Jared Lucas

Participants:: Amaia Anabitarte, Andrew Lyons, Carlos Escobedo, CiBoT, Jun Pataleta, Kim Jared Lucas, Mikel Martín Corrales, Paul Holden

Votes:: 0 Vote for this issue

Watchers:: 11 Start watching this issue

Created:: 21/Feb/25 9:59 PM

Updated:: 11/Mar/25 4:53 PM

Resolved:: 08/Mar/25 12:17 PM

Estimated:

Not Specified

Remaining:

Logged:

1h 24m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify