Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 5.0
Affects Version/s: 5.0
Component/s: Themes
Labels:
- ci
- hqteam_moppies
- regression
- triaged

Affected Branches:
MOODLE_500_STABLE
Fixed Branches:
MOODLE_500_STABLE
Epic Link:
Bootstrap 5.x Upgrade
Pull from Repository:
https://github.com/roland04/moodle.git
Pull Main Branch:
~~MDL-84613~~-main
Pull Main Diff URL:
https://github.com/roland04/moodle/compare/7a318d5c85...MDL-84613-main
Testing Instructions:
Hide

Login as any user

Click on Dashboard in the primary navigation

Without any other interaction press "Tab" key

Confirm the "Skip to main content" element is visible on the top left corner
Show
Login as any user Click on Dashboard in the primary navigation Without any other interaction press "Tab" key Confirm the "Skip to main content" element is visible on the top left corner
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-84613~~ using repository: https://github.com/roland04/moodle.git

main (0 errors / 0 warnings) [branch: MDL-84613-main | CI Job]

_{More information about this report}

Built on: Fri Feb 21 01:17:39 PM UTC 2025
Show
Code verified against automated checks. Checked MDL-84613 using repository: https://github.com/roland04/moodle.git main (0 errors / 0 warnings) [branch: MDL-84613-main | CI Job ] More information about this report Built on: Fri Feb 21 01:17:39 PM UTC 2025

Story Points:
1
Sprint:
HQ 2025 Sprint I1.2 Moppies

After Bootstrap 5 upgrade, although the "Skip to main content" is present in the page and focusable, it is not visible.

That is happening because when refactoring from previous versions "sr-only" and "sr-only-focusable" were replaced with "visually-hidden" and "visually-hidden-focusable", and we should only use "visually-hidden-focusable".

This is because in BS5 "visually-hidden" class does many more things than BS4 "sr-only" to hide the element.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

screenshot-1.png
21/Feb/25 8:20 PM
25 kB
Mikel Martín Corrales
MDL-84613.png
27/Feb/25 9:50 AM
211 kB
Ron Carl Alfon Yu

is a regression caused by

MDL-75669 Upgrade the Boost theme with Bootstrap 5.x

Closed

Assignee:: Mikel Martín Corrales

Reporter:: Mikel Martín Corrales

Peer reviewer:: Carlos Escobedo

Integrator:: Paul Holden

Tester:: Ron Carl Alfon Yu

Participants:: Carlos Escobedo, CiBoT, Mikel Martín Corrales, Paul Holden, Ron Carl Alfon Yu

Votes:: 0 Vote for this issue

Watchers:: 9 Start watching this issue

Created:: 21/Feb/25 5:57 PM

Updated:: 28/Feb/25 12:53 AM

Resolved:: 28/Feb/25 12:53 AM

Estimated:

Remaining:

Logged:

2h 32m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify