Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-84556

core_filters\local_settings_form not autoloadable

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Minor Minor
    • None
    • 4.5.3
    • Filters
    • MOODLE_405_STABLE
    • MDL-84556-main
    • Hide

      I can't see anywhere in core that this abstract class is actually overridden so the manual test would be to find or create a filter plugin that implements local settings and check that the form appears as expected.

      Otherwise, something like this will check that the class can be autoloaded by either its real name or its alias:

      <?php
      		 
       
      		 
      const CLI_SCRIPT = true;
      		 
      require_once('config.php');
      		 
       
      		 
      echo class_exists('filter_local_settings_form') ? "found" : "not found";
      		 
      echo PHP_EOL;
      		 
      echo class_exists('core_filters\form\local_settings_form') ? "found" : "not found";
      		 
      echo PHP_EOL;

      Show
      I can't see anywhere in core that this abstract class is actually overridden so the manual test would be to find or create a filter plugin that implements local settings and check that the form appears as expected. Otherwise, something like this will check that the class can be autoloaded by either its real name or its alias: <?php   const CLI_SCRIPT = true; require_once ( 'config.php' );   echo class_exists ( 'filter_local_settings_form' ) ? "found" : "not found" ; echo PHP_EOL; echo class_exists ( 'core_filters\form\local_settings_form' ) ? "found" : "not found" ; echo PHP_EOL;
    • Hide

      Fails against automated checks.

      Checked MDL-84556 using repository: https://github.com/micaherne/moodle.git

      Should these errors be fixed?

      Built on: Mon Feb 17 12:56:22 PM UTC 2025

      Show
      Fails against automated checks. Checked MDL-84556 using repository: https://github.com/micaherne/moodle.git main (2 errors / 0 warnings) [branch: MDL-84556-main | CI Job ] overview (0/0) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (2/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Should these errors be fixed? Built on: Mon Feb 17 12:56:22 PM UTC 2025

      The class core_filters\local_settings_form is not loadable by the autoloader as it's inside a form subdirectory of classes but that's not represented in the namespace.

            maherne Michael Aherne
            maherne Michael Aherne
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.