Loading...

XML

Word

Printable

Type: Bug
Resolution: Unresolved
Priority: Minor
Fix Version/s: None
Affects Version/s: 4.5.3, 5.0
Component/s: Web Services
Labels:
- ci
- hqteam_hedgehog
- patch
- triaged

Affected Branches:
MOODLE_405_STABLE, MOODLE_500_STABLE
Pull from Repository:
https://github.com/farhan6318/moodle.git
Pull 4.5 Branch:
MDL-84486-Add-sortby-while-getting-list-of-webservices-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...farhan6318:moodle:MDL-84486-Add-sortby-while-getting-list-of-webservices-405?expand=1
Pull 5.0 Branch:
MDL-84486-Add-sortby-while-getting-list-of-webservices-500
Pull 5.0 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_500_STABLE...farhan6318:moodle:MDL-84486-Add-sortby-while-getting-list-of-webservices-500?expand=1
Pull Main Branch:
MDL-84486-Add-sortby-while-getting-list-of-webservices
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...farhan6318:moodle:MDL-84486-Add-sortby-while-getting-list-of-webservices?expand=1
Testing Instructions:

Hide

Testing instructions

1. Login as Admin
2. Go to Site Administration -> Server > Web services -> External Services
3. Click on Add
4. Write a name in the name field that starts with the letter A, eg A webservice and press Add service
5. Repeat the above steps to create a number of webservices with different alphabets in different order example next create a webservice with the name "Webservice for testing" and after that create a webservice with the name "Bob the builder webservice"

6. Go to Server > Web services > Manage tokens
7. Click on Create Token

The list of options in the "Service" should be alphabetically arranged

Show
Testing instructions 1. Login as Admin 2. Go to Site Administration -> Server > Web services -> External Services 3. Click on Add 4. Write a name in the name field that starts with the letter A, eg A webservice and press Add service 5. Repeat the above steps to create a number of webservices with different alphabets in different order example next create a webservice with the name "Webservice for testing" and after that create a webservice with the name "Bob the builder webservice" 6. Go to Server > Web services > Manage tokens 7. Click on Create Token The list of options in the "Service" should be alphabetically arranged
Pre-check results:
Hide

Code verified against automated checks.

Checked MDL-84486 using repository: https://github.com/farhan6318/moodle.git

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-84486-Add-sortby-while-getting-list-of-webservices-405 | CI Job]

MOODLE_500_STABLE (0 errors / 0 warnings) [branch: MDL-84486-Add-sortby-while-getting-list-of-webservices-500 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-84486-Add-sortby-while-getting-list-of-webservices | CI Job]

_{More information about this report}

Built on: Sat May 10 06:38:18 UTC 2025
Show
Code verified against automated checks. Checked MDL-84486 using repository: https://github.com/farhan6318/moodle.git MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-84486-Add-sortby-while-getting-list-of-webservices-405 | CI Job ] MOODLE_500_STABLE (0 errors / 0 warnings) [branch: MDL-84486-Add-sortby-while-getting-list-of-webservices-500 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-84486-Add-sortby-while-getting-list-of-webservices | CI Job ] More information about this report Built on: Sat May 10 06:38:18 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch MDL-84486-Add-sortby-while-getting-list-of-webservices-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19277/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65879/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65880/ Behat (Firefox - boost)

Launching automatic jobs for branch MDL-84486-Add-sortby-while-getting-list-of-webservices-500

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19278/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65881/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65882/ Behat (Firefox - boost)

Launching automatic jobs for branch MDL-84486-Add-sortby-while-getting-list-of-webservices

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19279/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65883/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65884/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65885/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65886/ App tests (stable app version)

Built on: Mon May 12 12:31:05 UTC 2025
Show
Launching automatic jobs for branch MDL-84486 -Add-sortby-while-getting-list-of-webservices-405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19277/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65879/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65880/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-84486 -Add-sortby-while-getting-list-of-webservices-500 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19278/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65881/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65882/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-84486 -Add-sortby-while-getting-list-of-webservices https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19279/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65883/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65884/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65885/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65886/ App tests (stable app version) Built on: Mon May 12 12:31:05 UTC 2025

While getting the list of webservices the db call

// Service selector.$options = $DB->get_records_menu('external_services', null, '', 'id, name');

is missing the sort option which can lead to inconsistently ordered list of webservices .. this does cause issues at time in certain database engines.

has been marked as being related by

MDL-85422 PR only: MDL-84486 - Missing sort options while getting records of external services on manage tokens

Closed

Assignee:: Farhan Karmali

Reporter:: Farhan Karmali

Peer reviewer:: Meirza

Participants:: Farhan Karmali, Meirza

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Created:: 10/Feb/25 5:51 PM

Updated:: 12/May/25 8:31 PM

Details

Description

Attachments

Issue Links

Activity

People

Dates

Clockify