Loading...

XML

Word

Printable

Type: Bug
Resolution: Unresolved
Priority: Minor
Fix Version/s: None
Affects Version/s: 4.5.3
Component/s: Files API
Labels:
- ci

Affected Branches:
MOODLE_405_STABLE
Pull from Repository:
https://github.com/jarad-barker/moodle.git
Pull Main Branch:
MDL-84483-main
Pull Main Diff URL:
https://github.com/jarad-barker/moodle/compare/139a0ad5f0458caaff7506c8b26081eea1c85231...MDL-84483-main
Testing Instructions:
1. Ensure PHPUnit passes
Pre-check results:
Hide

Code verified against automated checks with warnings.

Checked MDL-84483 using repository: https://github.com/jarad-barker/moodle.git

main (0 errors / 1 warnings) [branch: MDL-84483-main | CI Job]

overview (0/1), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

Warn: The MDL-84483-main branch at https://github.com/jarad-barker/moodle.git has not been rebased recently (>20 days ago).

Should these errors be fixed?

Built on: Fri Mar 7 06:18:59 UTC 2025
Show
Code verified against automated checks with warnings. Checked MDL-84483 using repository: https://github.com/jarad-barker/moodle.git main (0 errors / 1 warnings) [branch: MDL-84483-main | CI Job ] overview (0/1) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Warn: The MDL-84483 -main branch at https://github.com/jarad-barker/moodle.git has not been rebased recently (>20 days ago). Should these errors be fixed? Built on: Fri Mar 7 06:18:59 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch MDL-84483-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18236/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62207/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62208/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62209/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62210/ App tests (stable app version)

Built on: Mon Feb 10 08:30:19 AM UTC 2025
Show
Launching automatic jobs for branch MDL-84483 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18236/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62207/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62208/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62209/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62210/ App tests (stable app version) Built on: Mon Feb 10 08:30:19 AM UTC 2025

~~MDL-75850~~ added logic to skip firing the after_file_created hook in unit tests.

https://github.com/moodle/moodle/blob/b9a5ed77371d1a3af2e255492ae98a6967701dd2/lib/filestorage/file_storage.php#L1079-L1081

This causes problems for unit tests that test functionality triggered by the after_file_created hook.

This is not an ideal approach to take. Hooks should fire in unit tests. If a unit test requires specific functionality (or to avoid specific functionality) from a hook, it can be intercepted by mocking a hook listener: https://moodledev.io/docs/5.0/apis/core/hooks#dispatching-hooks

It seems like at one point there was an `after_file_created` listener (initially introduced in ~~MDL-75850~~), but ~~MDL-83245~~ since removed that listener, and there are no others in core. So it should be safe to revert this code back to how it used to be (i.e., always fire the hook).

has a non-specific relationship to

MDL-84977 PHP unit Integration tests for create_file with file_storage are not possible

Open

MDL-83245 Addresses design issues with File redaction

Closed

is a regression caused by

MDL-75850 Add the ability to configure automatic EXIF data removal from uploaded images

Closed

Assignee:: Unassigned

Reporter:: cameron1729

Peer reviewer:: cameron1729

Participants:: cameron1729, CiBoT, Jarad Barker, Jun Pataleta

Votes:: 1 Vote for this issue

Watchers:: 3 Start watching this issue

Created:: 10/Feb/25 2:39 PM

Updated:: 13/Jun/25 4:06 PM

Estimated:

Not Specified

Remaining:

Logged:

Details

Description

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify