Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.5.5, 5.0.1
Affects Version/s: 4.4.6, 4.5.2
Component/s: Files API, Resource
Labels:
- ci
- triaged

Affected Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Fixed Branches:
MOODLE_405_STABLE, MOODLE_500_STABLE
Pull from Repository:
https://github.com/paulholden/moodle/
Pull 4.4 Branch:
~~MDL-84480~~-404
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...paulholden:MDL-84480-404
Pull 4.5 Branch:
~~MDL-84480~~-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...paulholden:MDL-84480-405
Pull Main Branch:
~~MDL-84480~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...paulholden:MDL-84480
Testing Instructions:
Hide

Log in as admin

Create a course

Add a File resource/activity to the course

Upload a text file (*.txt)

Appearance > Use filters on file content: All files

Save and view the activity

Confirm the file content is served

Confirm there are no debugging warnings in server error log
Show
Log in as admin Create a course Add a File resource/activity to the course Upload a text file ( *.txt ) Appearance > Use filters on file content: All files Save and view the activity Confirm the file content is served Confirm there are no debugging warnings in server error log
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-84480~~ using repository: https://github.com/paulholden/moodle/

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-84480-404 | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-84480-405 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-84480 | CI Job]

_{More information about this report}

Built on: Wed Mar 12 07:48:14 UTC 2025
Show
Code verified against automated checks. Checked MDL-84480 using repository: https://github.com/paulholden/moodle/ MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-84480-404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-84480-405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-84480 | CI Job ] More information about this report Built on: Wed Mar 12 07:48:14 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-84480~~-404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18548/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63534/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63535/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-84480~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18549/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63536/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63537/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-84480~~

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18550/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63538/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63539/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63540/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63541/ App tests (stable app version)

Built on: Wed Mar 12 08:25:22 UTC 2025
Show
Launching automatic jobs for branch MDL-84480 -404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18548/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63534/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63535/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-84480 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18549/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63536/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63537/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-84480 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18550/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63538/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63539/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63540/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63541/ App tests (stable app version) Built on: Wed Mar 12 08:25:22 UTC 2025

Add a file resource to a course, while enabling filters on the file content:

Debugging: Passing a courseid to format_text() is deprecated, please pass a context instead. in

* line 549 of /lib/weblib.php: call to debugging()

* line 2643 of /lib/filelib.php: call to format_text()

* line 2758 of /lib/filelib.php: call to send_file()

* line 421 of /mod/resource/lib.php: call to send_stored_file()

* line 5279 of /lib/filelib.php: call to resource_pluginfile()

* line 44 of /pluginfile.php: call to file_pluginfile()

, referer: http://moodle.internal/master/course/view.php?id=9

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

(1) 6 Passed -- (Main)MDL-84480.png
180 kB
24/Apr/25 11:16 AM

Assignee:: Paul Holden

Reporter:: Paul Holden

Peer reviewer:: Andrew Gosali

Integrator:: Huong Nguyen

Tester:: Kim Jared Lucas

Participants:: Andrew Gosali, CiBoT, Huong Nguyen, Jun Pataleta, Kim Jared Lucas, Paul Holden

Votes:: 1 Vote for this issue

Watchers:: 5 Start watching this issue

Created:: 10/Feb/25 4:54 AM

Updated:: 24/Apr/25 11:35 PM

Resolved:: 24/Apr/25 11:35 PM

Estimated:

Not Specified

Remaining:

Logged:

47m

Details

Description

Attachments

Attachments

Activity

People

Dates

Time Tracking

Clockify