Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 5.0
Affects Version/s: 5.0
Component/s: AI
Labels:
- ci
- triaged

Affected Branches:
MOODLE_500_STABLE
Fixed Branches:
MOODLE_500_STABLE
Pull from Repository:
https://github.com/paulholden/moodle/
Pull Main Branch:
~~MDL-84453~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...paulholden:MDL-84453
Testing Instructions:
Hide

Increase site logging level to debug

Log in as admin

Navigate to AI > AI providers in site administration

Create a new provider instance

After saving, press Settings in the table

Confirm you can edit and save the provider settings

Navigate to the following URL:

<WWWROOT>/ai/configure.php?id=42

Confirm you see the following error:

Can't find data record in database table ai_providers.

Table name only displays in higher debug level settings
Show
Increase site logging level to debug Log in as admin Navigate to AI > AI providers in site administration Create a new provider instance After saving, press Settings in the table Confirm you can edit and save the provider settings Navigate to the following URL: <WWWROOT>/ai/configure.php?id=42 Confirm you see the following error: Can't find data record in database table ai_providers. Table name only displays in higher debug level settings
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-84453~~ using repository: https://github.com/paulholden/moodle/

main (0 errors / 0 warnings) [branch: MDL-84453 | CI Job]

_{More information about this report}

Built on: Wed Feb 19 01:47:24 PM UTC 2025
Show
Code verified against automated checks. Checked MDL-84453 using repository: https://github.com/paulholden/moodle/ main (0 errors / 0 warnings) [branch: MDL-84453 | CI Job ] More information about this report Built on: Wed Feb 19 01:47:24 PM UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-84453~~

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18303/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62586/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62587/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62588/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62589/ App tests (stable app version)

Built on: Wed Feb 19 02:25:15 PM UTC 2025
Show
Launching automatic jobs for branch MDL-84453 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18303/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62586/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62587/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62588/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62589/ App tests (stable app version) Built on: Wed Feb 19 02:25:15 PM UTC 2025

Visit the following URL, where 42 is any value that doesn't correspond with a stored provider record:

http://moodle.internal/master/ai/configure.php?id=42

See the following:

Exception - Syntax error

More information about this error

Debug info:

Error code: generalexceptionmessage

Stack trace:

    line 60 of /ai/configure.php: JsonException thrown

    line 60 of /ai/configure.php: call to json_decode()

Output buffer: <br /> <b>Warning</b>: Attempt to read property "provider" on bool in <b>/opt/moodle/master/src/ai/configure.php</b> on line <b>57</b><br /> <br /> <b>Deprecated</b>: explode(): Passing null to parameter #2 ($string) of type string is deprecated in <b>/opt/moodle/master/src/ai/configure.php</b> on line <b>57</b><br /> <br /> <b>Warning</b>: Attempt to read property "config" on bool in <b>/opt/moodle/master/src/ai/configure.php</b> on line <b>60</b><br /> <br /> <b>Deprecated</b>: json_decode(): Passing null to parameter #1 ($json) of type string is deprecated in <b>/opt/moodle/master/src/ai/configure.php</b> on line <b>60</b><br />

The API call to ::get_provider_records(...) (plural) is awkward when we are passing the primary key as the filter, and the lack of error handling produces the above

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

MDL-84453.png
697 kB
20/Feb/25 2:03 PM

is a regression caused by

MDL-82977 AI: Provider instances

Closed

Assignee:: Paul Holden

Reporter:: Paul Holden

Peer reviewer:: Matt Porritt

Integrator:: Huong Nguyen

Tester:: Ron Carl Alfon Yu

Participants:: CiBoT, Huong Nguyen, Jun Pataleta, Matt Porritt, Paul Holden, Ron Carl Alfon Yu

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Created:: 07/Feb/25 5:33 AM

Updated:: 21/Feb/25 11:46 AM

Resolved:: 21/Feb/25 11:46 AM

Estimated:

Not Specified

Remaining:

Logged:

24m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify