Loading...

XML

Word

Printable

Type: Task
Resolution: Fixed
Priority: Minor
Fix Version/s: 5.0
Affects Version/s: 4.5
Component/s: Libraries
Labels:

Affected Branches:
MOODLE_405_STABLE
Fixed Branches:
MOODLE_500_STABLE
Epic Link:
5.0 deprecations
Pull from Repository:
https://github.com/ziegenberg/moodle
Pull Main Branch:
~~MDL-84449~~_deprecate-imagecopybicubic
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...ziegenberg:MDL-84449_deprecate-imagecopybicubic
Testing Instructions:
Hide

Execute the following:

$ git grep -A1 -B2 "imagecopybicubic("

Confirm the only matches are the original function (which emits a final deprecation notice) and upgrade notes regarding the removal
Show
Execute the following: $ git grep -A1 -B2 "imagecopybicubic(" Confirm the only matches are the original function (which emits a final deprecation notice) and upgrade notes regarding the removal
Pre-check results:
Hide

Fails against automated checks.

Checked ~~MDL-84449~~ using repository: https://github.com/ziegenberg/moodle

main (20 errors / 0 warnings) [branch: MDL-84449_deprecate-imagecopybicubic | CI Job]

overview (0/0), phplint (0/0), phpcs (20/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

Should these errors be fixed?

Built on: Sat Mar 8 08:59:46 UTC 2025
Show
Fails against automated checks. Checked MDL-84449 using repository: https://github.com/ziegenberg/moodle main (20 errors / 0 warnings) [branch: MDL-84449_deprecate-imagecopybicubic | CI Job ] overview (0/0) , phplint (0/0) , phpcs (20/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Should these errors be fixed? Built on: Sat Mar 8 08:59:46 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-84449~~_deprecate-imagecopybicubic

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18420/ PHPUnit (sqlsrv / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63117/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63118/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63119/ Behat (Firefox - classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63120/ App tests (stable app version) / complete) --> unrelated failure, please ignore.

Built on: Thu Mar 6 03:19:32 UTC 2025
Show
Launching automatic jobs for branch MDL-84449 _deprecate-imagecopybicubic https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18420/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63117/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63118/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63119/ Behat (Firefox - classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63120/ App tests (stable app version) / complete) --> unrelated failure, please ignore. Built on: Thu Mar 6 03:19:32 UTC 2025

The function imagecopybicubic() calls the GD function imagecopyresampled(). As GD is a strict requirement we can deprecate imagecopybicubic() and later remove it. Currently, only the gdlib calls it internally.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

MDL-84449_test.png
13/Mar/25 11:21 PM
76 kB
Sara Arjona (@sarjona)

has been marked as being related by

MDL-84734 Final deprecation of imagecopybicubic

Open

Assignee:: Daniel Ziegenberg

Reporter:: Daniel Ziegenberg

Peer reviewer:: Raquel Ortega

Integrator:: Sara Arjona (@sarjona)

Tester:: Sara Arjona (@sarjona)

Participants:: CiBoT, Daniel Ziegenberg, Raquel Ortega, Safat Shahin, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Created:: 06/Feb/25 11:05 PM

Updated:: 11/Apr/25 6:01 PM

Resolved:: 14/Mar/25 11:31 PM

Estimated:

Not Specified

Remaining:

Logged:

1h 54m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify