Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.5.5, 5.0.1
Affects Version/s: 4.2.11, 4.5.1
Component/s: Administration, Tasks
Labels:

Affected Branches:
MOODLE_402_STABLE, MOODLE_405_STABLE
Fixed Branches:
MOODLE_405_STABLE, MOODLE_500_STABLE
Pull from Repository:
https://github.com/bwalkerl/moodle
Pull 4.4 Branch:
~~MDL-84442~~-metadata-task-logs-MOODLE_404_STABLE
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...bwalkerl:MDL-84442-metadata-task-logs-MOODLE_404_STABLE
Pull 4.5 Branch:
~~MDL-84442~~-metadata-task-logs-MOODLE_405_STABLE
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...bwalkerl:MDL-84442-metadata-task-logs-MOODLE_405_STABLE
Pull 5.0 Branch:
~~MDL-84442~~-metadata-task-logs-MOODLE_500_STABLE
Pull 5.0 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_500_STABLE...bwalkerl:MDL-84442-metadata-task-logs-MOODLE_500_STABLE
Pull Main Branch:
~~MDL-84442~~-metadata-task-logs
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...bwalkerl:MDL-84442-metadata-task-logs
Testing Instructions:
Hide

Prerequisites

Install tool_testtasks:

git clone git@github.com:catalyst/moodle-tool_testtasks.git admin/tool/testtasks

Modify this patch so tasks get cleaned up quicker:

Open lib/classes/task/manager.php

In the cleanup_metadata method, look for:

if ($runningtask->timestarted > $clock->time() - HOURSECS) {

continue;

}

Modify it to:

if ($runningtask->timestarted > $clock->time() - MINSECS) {

continue;

}

Testing

Browse to "Site administration" > "Server" > "Tasks running now" (you'll need to get back to this page quickly after the next steps)

Queue up 1 1000 second tasks:

php admin/tool/testtasks/cli/queue_multiple_adhoc_tasks.php -n=1 -c="tool_testtasks\task\one_thousand_second_task"

Start processing the task:

php admin/cli/adhoc_task.php -e

Kill the adhoc task runners in the terminal by pressing ctrl+z followed by the command: kill -9 %1

Refresh the "Tasks running now page" and verify you see 1000 second task processing

Run the cleanup task:

php admin/cli/scheduled_task.php --execute=\\core\\task\\task_lock_cleanup_task

Browse to "Site administration" > "Server" > "Tasks logs"

Verify that you see the logs for \core\task\task_lock_cleanup_task and the result is Success

View the log output and Verify that it contains "Scheduled task complete" to confirm it has finished properly.
Show
Prerequisites Install tool_testtasks: git clone git@github.com:catalyst/moodle-tool_testtasks.git admin/tool/testtasks Modify this patch so tasks get cleaned up quicker: Open lib/classes/task/manager.php In the cleanup_metadata method, look for: if ($runningtask->timestarted > $clock->time() - HOURSECS) { continue; } Modify it to: if ($runningtask->timestarted > $clock->time() - MINSECS) { continue; } Testing Browse to "Site administration" > "Server" > "Tasks running now" (you'll need to get back to this page quickly after the next steps) Queue up 1 1000 second tasks: php admin/tool/testtasks/cli/queue_multiple_adhoc_tasks.php -n=1 -c="tool_testtasks\task\one_thousand_second_task" Start processing the task: php admin/cli/adhoc_task.php -e Kill the adhoc task runners in the terminal by pressing ctrl+z followed by the command: kill -9 %1 Refresh the "Tasks running now page" and verify you see 1000 second task processing Run the cleanup task: php admin/cli/scheduled_task.php --execute=\\core\\task\\task_lock_cleanup_task Browse to "Site administration" > "Server" > "Tasks logs" Verify that you see the logs for \core\task\task_lock_cleanup_task and the result is Success View the log output and Verify that it contains "Scheduled task complete" to confirm it has finished properly.
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-84442~~ using repository: https://github.com/bwalkerl/moodle

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-84442-metadata-task-logs-MOODLE_404_STABLE | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-84442-metadata-task-logs-MOODLE_405_STABLE | CI Job]

main (0 errors / 0 warnings) [branch: MDL-84442-metadata-task-logs | CI Job]

_{More information about this report}

Built on: Thu Apr 10 04:38:36 UTC 2025
Show
Code verified against automated checks. Checked MDL-84442 using repository: https://github.com/bwalkerl/moodle MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-84442-metadata-task-logs-MOODLE_404_STABLE | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-84442-metadata-task-logs-MOODLE_405_STABLE | CI Job ] main (0 errors / 0 warnings) [branch: MDL-84442-metadata-task-logs | CI Job ] More information about this report Built on: Thu Apr 10 04:38:36 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-84442~~-metadata-task-logs-MOODLE_404_STABLE

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19080/ PHPUnit (sqlsrv / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65242/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65243/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65244/ Behat (Firefox - classic / complete)

Launching automatic jobs for branch ~~MDL-84442~~-metadata-task-logs-MOODLE_405_STABLE

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19081/ PHPUnit (sqlsrv / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65245/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65246/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65247/ Behat (Firefox - classic / complete)

Launching automatic jobs for branch ~~MDL-84442~~-metadata-task-logs-MOODLE_500_STABLE

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19082/ PHPUnit (sqlsrv / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65248/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65249/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65250/ Behat (Firefox - classic / complete)

Launching automatic jobs for branch ~~MDL-84442~~-metadata-task-logs

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19083/ PHPUnit (sqlsrv / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65251/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65252/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65253/ Behat (Firefox - classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65254/ App tests (stable app version) / complete)

Built on: Tue Apr 22 00:33:25 UTC 2025
Show
Launching automatic jobs for branch MDL-84442 -metadata-task-logs-MOODLE_404_STABLE https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19080/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65242/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65243/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65244/ Behat (Firefox - classic / complete) Launching automatic jobs for branch MDL-84442 -metadata-task-logs-MOODLE_405_STABLE https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19081/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65245/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65246/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65247/ Behat (Firefox - classic / complete) Launching automatic jobs for branch MDL-84442 -metadata-task-logs-MOODLE_500_STABLE https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19082/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65248/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65249/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65250/ Behat (Firefox - classic / complete) Launching automatic jobs for branch MDL-84442 -metadata-task-logs https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19083/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65251/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65252/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65253/ Behat (Firefox - classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65254/ App tests (stable app version) / complete) Built on: Tue Apr 22 00:33:25 UTC 2025

When testing MDL-78437 I noticed that task logs for task_lock_cleanup_task were showing as failed when they had run successfully and marked another task as failed.

The cleanup task calls adhoc_task_failed to mark other tasks as failed, but finalise log has no concept of other tasks being able to call this and processes the current log file instead.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

MDL-84442.png
23/Apr/25 4:59 PM
469 kB
Ron Carl Alfon Yu

Discovered while testing

MDL-78437 Extend Clean up ad hoc task metadata logging and run it more frequently

Waiting for component lead review

has been marked as being related by

MDL-85156 core\task\task_lock_cleanup_task cannot correctly log failed tasks

Open

Assignee:: Benjamin Walker

Reporter:: Benjamin Walker

Peer reviewer:: cameron1729

Integrator:: David Woloszyn

Tester:: Ron Carl Alfon Yu

Participants:: Benjamin Walker, cameron1729, CiBoT, David Woloszyn, Huong Nguyen, Ron Carl Alfon Yu, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 11 Start watching this issue

Created:: 06/Feb/25 9:41 AM

Updated:: 06/Jun/25 4:32 PM

Resolved:: 24/Apr/25 11:35 PM

Estimated:

Remaining:

Logged:

1d 4h 50m

Details

Prerequisites

Testing

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify