Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.4.8, 4.5.4
Affects Version/s: 4.4.5
Component/s: Tasks
Labels:
- ci
- release_notes

Affected Branches:
MOODLE_404_STABLE
Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Pull from Repository:
https://github.com/clransom/moodle.git
Pull 4.4 Branch:
~~MDL-84419~~-404
Pull 4.4 Diff URL:
https://github.com/clransom/moodle/compare/MOODLE_404_STABLE...MDL-84419-404
Pull 4.5 Branch:
~~MDL-84419~~-405
Pull 4.5 Diff URL:
https://github.com/clransom/moodle/compare/MOODLE_405_STABLE...MDL-84419-405
Pull Main Branch:
~~MDL-84419~~-main
Pull Main Diff URL:
https://github.com/clransom/moodle/compare/main...MDL-84419-main
Testing Instructions:
Hide

Go to Site administration > Location > Location settings and set 'Default timezone' to 'Europe/London'

Site administration > Server > Tasks > Scheduled tasks

Pick any task and edit the task settings

Note down the current configuration so you can set it back afterwards

Set the task to run at 1am on the next day that daylight saving time begins (currently, that would be 29th March)

Save your changes

Verify that the date in the 'Next run' column for the task you changed is 2am on the day you chose in step 5 (e.g. currently the next run date should be Sunday, 29 March 2026, 2:00 AM)
Show
Go to Site administration > Location > Location settings and set 'Default timezone' to 'Europe/London' Site administration > Server > Tasks > Scheduled tasks Pick any task and edit the task settings Note down the current configuration so you can set it back afterwards Set the task to run at 1am on the next day that daylight saving time begins (currently, that would be 29th March) Save your changes Verify that the date in the 'Next run' column for the task you changed is 2am on the day you chose in step 5 (e.g. currently the next run date should be Sunday, 29 March 2026, 2:00 AM)
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-84419~~ using repository: https://github.com/clransom/moodle.git

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-84419-404 | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-84419-405 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-84419-main | CI Job]

_{More information about this report}

Built on: Fri Feb 7 09:58:15 AM UTC 2025
Show
Code verified against automated checks. Checked MDL-84419 using repository: https://github.com/clransom/moodle.git MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-84419-404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-84419-405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-84419-main | CI Job ] More information about this report Built on: Fri Feb 7 09:58:15 AM UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-84419~~-404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18871/ PHPUnit (sqlsrv / complete) --> unrelated, please ignore.

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64597/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64598/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64599/ Behat (Firefox - classic / complete)

Launching automatic jobs for branch ~~MDL-84419~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18872/ PHPUnit (sqlsrv / complete) --> unrelated, please ignore.

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64600/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64601/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64602/ Behat (Firefox - classic / complete)

Launching automatic jobs for branch ~~MDL-84419~~-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18873/ PHPUnit (sqlsrv / complete) --> unrelated, please ignore.

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64603/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64604/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64605/ Behat (Firefox - classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64606/ App tests (stable app version) / complete)

Built on: Mon Mar 31 05:31:27 UTC 2025
Show
Launching automatic jobs for branch MDL-84419 -404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18871/ PHPUnit (sqlsrv / complete) --> unrelated, please ignore. https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64597/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64598/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64599/ Behat (Firefox - classic / complete) Launching automatic jobs for branch MDL-84419 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18872/ PHPUnit (sqlsrv / complete) --> unrelated, please ignore. https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64600/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64601/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64602/ Behat (Firefox - classic / complete) Launching automatic jobs for branch MDL-84419 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18873/ PHPUnit (sqlsrv / complete) --> unrelated, please ignore. https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64603/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64604/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64605/ Behat (Firefox - classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64606/ App tests (stable app version) / complete) Built on: Mon Mar 31 05:31:27 UTC 2025

This is about scheduled tasks set to run at the hour when the clocks change for daylight saving time. E.g. if a task is set to run at 1am every day in the Europe/London timezone, then the day the clocks go forward gets skipped because 1am doesn't exist on that day.

There is an existing unit test for this case (scheduled_task_test::test_get_next_scheduled_time) that does catch this issue, however that just tests the current time so it will only test this case once a year if you happen to run your tests at the right time.

We actually noticed this because the existing unit test breaks when the clocks go backwards. In this case, the test expects the next scheduled time to be the first occurrence of 1am (midnight UTC), however get_next_scheduled_time actually gets the second occurrence of 1am (1am UTC). In this case, get_next_scheduled_time is actually doing the right thing, so the test is wrong.

So to fix this, we will fix get_next_scheduled_time in the case where the clocks go forward, and we will move the daylight saving time tests into a unit test that doesn't depend on the time when the tests are run.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

MDL-84419_404_Step3.png
95 kB
01/Apr/25 6:51 PM
MDL-84419_404_Step7.png
186 kB
01/Apr/25 6:51 PM
MDL-84419_405_Step3.png
87 kB
01/Apr/25 6:51 PM
MDL-84419_405_Step7.png
183 kB
01/Apr/25 6:51 PM
MDL-84419_Main_Step3.png
91 kB
01/Apr/25 6:51 PM
MDL-84419_Main_Step7.png
18 kB
01/Apr/25 6:51 PM

will help resolve

MDL-85055 Random failures on different task unit tests

Open

Assignee:: Katie Ransom

Reporter:: Katie Ransom

Peer reviewer:: Sam Marshall

Integrator:: David Woloszyn

Tester:: Raquel Ortega

Participants:: CiBoT, David Woloszyn, Huong Nguyen, Katie Ransom, Raquel Ortega, Sam Marshall

Votes:: 0 Vote for this issue

Watchers:: 7 Start watching this issue

Created:: 04/Feb/25 5:10 PM

Updated:: 11/Apr/25 3:40 PM

Resolved:: 01/Apr/25 10:54 PM

Estimated:

Not Specified

Remaining:

Logged:

3h 52m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify