Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Critical
Fix Version/s: 4.1.16, 4.3.10, 4.4.6, 4.5.2
Affects Version/s: 4.1.16, 4.3.10, 4.4.6, 4.5.2
Component/s: Unit tests
Labels:

Affected Branches:
MOODLE_401_STABLE, MOODLE_403_STABLE, MOODLE_404_STABLE, MOODLE_405_STABLE
Fixed Branches:
MOODLE_401_STABLE, MOODLE_403_STABLE, MOODLE_404_STABLE, MOODLE_405_STABLE
Pull from Repository:
https://github.com/andrewnicols/moodle.git
Pull 4.1 Branch:
~~MDL-84355~~-401
Pull 4.1 Diff URL:
https://github.com/andrewnicols/moodle/compare/2a753faf06...MDL-84355-401?w=1
Pull 4.3 Branch:
~~MDL-84355~~-403
Pull 4.3 Diff URL:
https://github.com/andrewnicols/moodle/compare/42a8b0c521...MDL-84355-403?w=1
Pull 4.4 Branch:
~~MDL-84355~~-404
Pull 4.4 Diff URL:
https://github.com/andrewnicols/moodle/compare/c5d94d21f2...MDL-84355-404?w=1
Pull 4.5 Branch:
~~MDL-84355~~-405
Pull 4.5 Diff URL:
https://github.com/andrewnicols/moodle/compare/77692ee5ea...MDL-84355-405?w=1
Pull Main Branch:
~~MDL-84355~~-main
Pull Main Diff URL:
https://github.com/andrewnicols/moodle/compare/bcf06a0484...MDL-84355-main?w=1
Testing Instructions:
Hide

Initialise PHPUnit

php admin/tool/phpunit/cli/init.php

php admin/tool/phpunit/cli/util.php --buildcomponentconfigs

Run PHPUnit against test_fixture_are_not_included:

./vendor/bin/phpunit --filter test_fixture_are_not_included

Confirm no test was executed

Run PHPUnit against test_fixture_are_not_included for one component:

./vendor/bin/phpunit --filter test_fixture_are_not_included -c lib/phpunit.xml

Confirm no test was executed

Run the test explicitly

./vendor/bin/phpunit --filter test_fixture_are_not_included lib/tests/fixtures/fixtures_not_tested_test.php

Confirm the test failed
Show
Initialise PHPUnit php admin/tool/phpunit/cli/init.php php admin/tool/phpunit/cli/util.php --buildcomponentconfigs Run PHPUnit against test_fixture_are_not_included : ./vendor/bin/phpunit --filter test_fixture_are_not_included Confirm no test was executed Run PHPUnit against test_fixture_are_not_included for one component: ./vendor/bin/phpunit --filter test_fixture_are_not_included -c lib/phpunit.xml Confirm no test was executed Run the test explicitly ./vendor/bin/phpunit --filter test_fixture_are_not_included lib/tests/fixtures/fixtures_not_tested_test.php Confirm the test failed
Pre-check results:
Hide

Fails against automated checks.

Checked ~~MDL-84355~~ using repository: https://github.com/andrewnicols/moodle.git

MOODLE_401_STABLE (1 errors / 0 warnings) [branch: MDL-84355-401 | CI Job]

overview (0/0), phplint (0/0), phpcs (1/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

MOODLE_403_STABLE (1 errors / 0 warnings) [branch: MDL-84355-403 | CI Job]

overview (0/0), phplint (0/0), phpcs (1/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

MOODLE_404_STABLE (1 errors / 0 warnings) [branch: MDL-84355-404 | CI Job]

overview (0/0), phplint (0/0), phpcs (1/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

MOODLE_405_STABLE (1 errors / 0 warnings) [branch: MDL-84355-405 | CI Job]

overview (0/0), phplint (0/0), phpcs (1/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

main (1 errors / 0 warnings) [branch: MDL-84355-main | CI Job]

overview (0/0), phplint (0/0), phpcs (1/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

Should these errors be fixed?

Built on: Wed Jan 29 05:30:19 AM UTC 2025
Show
Fails against automated checks. Checked MDL-84355 using repository: https://github.com/andrewnicols/moodle.git MOODLE_401_STABLE (1 errors / 0 warnings) [branch: MDL-84355-401 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (1/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , MOODLE_403_STABLE (1 errors / 0 warnings) [branch: MDL-84355-403 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (1/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , MOODLE_404_STABLE (1 errors / 0 warnings) [branch: MDL-84355-404 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (1/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , MOODLE_405_STABLE (1 errors / 0 warnings) [branch: MDL-84355-405 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (1/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , main (1 errors / 0 warnings) [branch: MDL-84355-main | CI Job ] overview (0/0) , phplint (0/0) , phpcs (1/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Should these errors be fixed? Built on: Wed Jan 29 05:30:19 AM UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-84355~~-401

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18097/ PHPUnit (sqlsrv / complete)

Launching automatic jobs for branch ~~MDL-84355~~-403

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18098/ PHPUnit (sqlsrv / complete)

Launching automatic jobs for branch ~~MDL-84355~~-404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18099/ PHPUnit (sqlsrv / complete)

Launching automatic jobs for branch ~~MDL-84355~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18100/ PHPUnit (sqlsrv / complete)

Launching automatic jobs for branch ~~MDL-84355~~-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18101/ PHPUnit (sqlsrv / complete)

Built on: Wed Jan 29 05:11:48 AM UTC 2025
Show
Launching automatic jobs for branch MDL-84355 -401 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18097/ PHPUnit (sqlsrv / complete) Launching automatic jobs for branch MDL-84355 -403 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18098/ PHPUnit (sqlsrv / complete) Launching automatic jobs for branch MDL-84355 -404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18099/ PHPUnit (sqlsrv / complete) Launching automatic jobs for branch MDL-84355 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18100/ PHPUnit (sqlsrv / complete) Launching automatic jobs for branch MDL-84355 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18101/ PHPUnit (sqlsrv / complete) Built on: Wed Jan 29 05:11:48 AM UTC 2025

As highlighted in ~~MDL-79843~~ PHPUnit is including the whole of the tests directory when finding tests. We currently have an exclude for the classes directory, but none for the fixtures directory... there should be.

In addition to this I discovered that our per-component phpunit configuration was including tests from the entire component and not just the tests directories.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

example_test.php
0.2 kB
29/Jan/25 11:03 AM
(1) 4 Passed -- (Main)MDL-84355.png
59 kB
30/Jan/25 1:34 PM
(1) 2 Passed -- (Main)MDL-84355.png
54 kB
30/Jan/25 1:34 PM
(1) 3 Passed -- (Main)MDL-84355.png
50 kB
30/Jan/25 1:34 PM

Discovered while testing

MDL-79843 Introduce mechanism for plugin type deprecation

Closed

Assignee:: Andrew Lyons

Reporter:: Andrew Lyons

Peer reviewer:: Jake Dallimore

Integrator:: Simey Lameze

Tester:: Kim Jared Lucas

Participants:: Andrew Lyons, CiBoT, Jake Dallimore, Kim Jared Lucas, Sara Arjona (@sarjona), Simey Lameze

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Created:: 29/Jan/25 10:51 AM

Updated:: 31/Jan/25 10:47 AM

Resolved:: 31/Jan/25 10:47 AM

Estimated:

Not Specified

Remaining:

Logged:

1h 42m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify