Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.4.7, 4.5.3
Affects Version/s: 4.4.6, 4.5.2
Component/s: H5P
Labels:
- release_notes
- triaged

Affected Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Pull from Repository:
https://github.com/DSI-Universite-Rennes2/moodle
Pull 4.4 Branch:
84348-hide-h5p-preview-message-404
Pull 4.4 Diff URL:
https://github.com/DSI-Universite-Rennes2/moodle/compare/84348-hide-h5p-preview-message-404~1...84348-hide-h5p-preview-message-404
Pull 4.5 Branch:
84348-hide-h5p-preview-message-405
Pull 4.5 Diff URL:
https://github.com/DSI-Universite-Rennes2/moodle/compare/84348-hide-h5p-preview-message-405~1...84348-hide-h5p-preview-message-405
Pull Main Branch:
84348-hide-h5p-preview-message-main
Pull Main Diff URL:
https://github.com/DSI-Universite-Rennes2/moodle/compare/84348-hide-h5p-preview-message-main~1...84348-hide-h5p-preview-message-main
Testing Instructions:
Hide

Setup:

ensure that Guest access is enabled in Administration > Plugins > Enrolments > Manage enrol plugins

create an empty course

enable Guest access in Participants > Enrolment methods

create a H5P activity (you can import a .h5p file from https://h5p.org/content-types-and-applications)

Test:

login as guest

go to the created H5P activity

you should not see the notification "You are in preview mode."
Show
Setup: ensure that Guest access is enabled in Administration > Plugins > Enrolments > Manage enrol plugins create an empty course enable Guest access in Participants > Enrolment methods create a H5P activity (you can import a .h5p file from https://h5p.org/content-types-and-applications ) Test: login as guest go to the created H5P activity you should not see the notification "You are in preview mode."
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-84348~~ using repository: https://github.com/DSI-Universite-Rennes2/moodle

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: 84348-hide-h5p-preview-message-404 | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: 84348-hide-h5p-preview-message-405 | CI Job]

main (0 errors / 0 warnings) [branch: 84348-hide-h5p-preview-message-main | CI Job]

_{More information about this report}

Built on: Tue Jan 28 04:18:21 PM UTC 2025
Show
Code verified against automated checks. Checked MDL-84348 using repository: https://github.com/DSI-Universite-Rennes2/moodle MOODLE_404_STABLE (0 errors / 0 warnings) [branch: 84348-hide-h5p-preview-message-404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: 84348-hide-h5p-preview-message-405 | CI Job ] main (0 errors / 0 warnings) [branch: 84348-hide-h5p-preview-message-main | CI Job ] More information about this report Built on: Tue Jan 28 04:18:21 PM UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch 84348-hide-h5p-preview-message-404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18169/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62066/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62067/ Behat (Firefox - boost)

Launching automatic jobs for branch 84348-hide-h5p-preview-message-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18170/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62068/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62069/ Behat (Firefox - boost)

Launching automatic jobs for branch 84348-hide-h5p-preview-message-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18171/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62070/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62071/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62072/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62073/ App tests (stable app version)

Built on: Thu Feb 6 08:31:11 AM UTC 2025
Show
Launching automatic jobs for branch 84348-hide-h5p-preview-message-404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18169/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62066/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62067/ Behat (Firefox - boost) Launching automatic jobs for branch 84348-hide-h5p-preview-message-405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18170/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62068/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62069/ Behat (Firefox - boost) Launching automatic jobs for branch 84348-hide-h5p-preview-message-main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18171/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62070/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62071/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62072/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62073/ App tests (stable app version) Built on: Thu Feb 6 08:31:11 AM UTC 2025

Currently, anonymous users see the message "You are in preview mode." on a public H5P activity.

According to the ~~MDL-69225~~ commit message, this notification should only be visible to teachers and content creators. This message should not be visible for guest users.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

(1) 3 Passed -- (Main)MDL-84348.png
19/Feb/25 2:19 PM
46 kB
Kim Jared Lucas

has been marked as being related by

MDL-69225 "Preview mode" warning banner is displayed on H5P activities even when not applicable

Closed

Assignee:: Julien Boulen

Reporter:: Julien Boulen

Peer reviewer:: Laurent David

Integrator:: Ferran Recio

Tester:: Kim Jared Lucas

Participants:: CiBoT, Ferran Recio, Julien Boulen, Jun Pataleta, Kim Jared Lucas, Laurent David, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 8 Start watching this issue

Created:: 28/Jan/25 6:48 PM

Updated:: 17/Mar/25 9:20 AM

Resolved:: 21/Feb/25 11:46 AM

Estimated:

Not Specified

Remaining:

Logged:

47m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify