-
Improvement
-
Resolution: Fixed
-
Minor
-
5.0
-
MOODLE_500_STABLE
-
MOODLE_500_STABLE
-
MDL-84346-main -
Setup
- Build the componentlibrary
grunt componentlibrary - Login as administrator
- Create a course
- Enrol an student in the course
- Create 2 assignment activities in the course
- One with "Students must manually mark the activity as done" completion condition
- One with "View the activity" Requirement completion condition
Test component library
- Go to Site administration > Development > UI Component library
- Navigate to Moodle > Moodle components > Buttons
- Confirm there is a "Subtle buttons" section
Test course page
- Login as student
- Access the course
- Confirm that the completion buttons are displayed as the following:
- Click on "Mark as done"
- Confirm that the completion buttons are displayed as the following:
- Access the second assignment and go back to the course page
- Confirm that the completion buttons are displayed as the following:
Test activity page
- Access the first assignment
- Confirm that the completion buttons are displayed as the following:
Setup Build the componentlibrary grunt componentlibrary Login as administrator Create a course Enrol an student in the course Create 2 assignment activities in the course One with "Students must manually mark the activity as done" completion condition One with "View the activity" Requirement completion condition Test component library Go to Site administration > Development > UI Component library Navigate to Moodle > Moodle components > Buttons Confirm there is a "Subtle buttons" section Test course page Login as student Access the course Confirm that the completion buttons are displayed as the following: Click on "Mark as done" Confirm that the completion buttons are displayed as the following: Access the second assignment and go back to the course page Confirm that the completion buttons are displayed as the following: Test activity page Access the first assignment Confirm that the completion buttons are displayed as the following: - Build the componentlibrary
-
Code verified against automated checks. 
Checked
MDL-84346using repository: https://github.com/roland04/moodle.git
main (0 errors / 0 warnings) [branch: MDL-84346-main | CI Job]
More information about this report
Built on: Mon Feb 24 12:20:04 PM UTC 2025
-
2
-
HQ 2025 Sprint I1.2 Moppies
The course page shows a nice interactable completion button; however, when the same buttons are used on another page (for example, the course overview), the same HTML looks completely different.
The reason is that the button has many CSS exceptions that only apply to the course page.
This is how it looks in the course:
This is when the same element is used in the activities overview page:
The completion button is rendered using the course/format/classes/output/local/content/cm/completion.php class.
This issue is about:
- Improving the button SCSS to unify the styles
- Try using core\output\local\properties\button for the different stylings
