Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.4.8, 4.5.4
Affects Version/s: 4.3.10, 4.4.6, 4.5.2
Component/s: Questions
Labels:
- triaged

Affected Branches:
MOODLE_403_STABLE, MOODLE_404_STABLE, MOODLE_405_STABLE
Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Pull from Repository:
https://github.com/PhilippImhof/moodle.git
Pull 4.4 Branch:
~~MDL-84335~~_404
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...PhilippImhof:moodle:MDL-84335_404
Pull 4.5 Branch:
~~MDL-84335~~_405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...PhilippImhof:moodle:MDL-84335_405
Pull Main Branch:
~~MDL-84335~~_main
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...PhilippImhof:moodle:MDL-84335_main
Testing Instructions:

Hide

Covered by unit test.

Note

Without the patch, the newly added unit test must fail for 4.3, 4.4 and 4.5, because the PHP warning (Attempt to read property "id" on null) will result in a \PHPUnit\Framework\Error\Warning exception being thrown.

However, as main uses PHPUnit 11.5, the test will not fail for the upcoming version of Moodle, even without the patch. Instead, it will be marked with a W, because of the PHP warning that it triggers. With the patch, the warning must be gone.

Show
Covered by unit test. Note Without the patch, the newly added unit test must fail for 4.3, 4.4 and 4.5, because the PHP warning (Attempt to read property "id" on null) will result in a \PHPUnit\Framework\Error\Warning exception being thrown. However, as main uses PHPUnit 11.5, the test will not fail for the upcoming version of Moodle, even without the patch. Instead, it will be marked with a W , because of the PHP warning that it triggers. With the patch, the warning must be gone.
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-84335~~ using repository: https://github.com/PhilippImhof/moodle.git

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-84335_404 | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-84335_405 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-84335_main | CI Job]

_{More information about this report}

Built on: Mon Mar 24 16:48:42 UTC 2025
Show
Code verified against automated checks. Checked MDL-84335 using repository: https://github.com/PhilippImhof/moodle.git MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-84335_404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-84335_405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-84335_main | CI Job ] More information about this report Built on: Mon Mar 24 16:48:42 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-84335~~_404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18758/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64257/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64258/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-84335~~_405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18759/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64259/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64260/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-84335~~_main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18760/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64261/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64262/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64263/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64264/ App tests (stable app version)

Built on: Mon Mar 24 04:30:22 UTC 2025
Show
Launching automatic jobs for branch MDL-84335 _404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18758/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64257/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64258/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-84335 _405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18759/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64259/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64260/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-84335 _main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18760/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64261/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64262/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64263/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64264/ App tests (stable app version) Built on: Mon Mar 24 04:30:22 UTC 2025

The function check_hint_file_access in questionbase.php fetches the applicable hint from the behaviour and compares its ID to the one supplied by the caller. However, get_applicable_hint may return null, so accessing the ID will lead to a warning.

I suggest checking that $hint is not null, before trying to access the ID.

Assignee:: Philipp Imhof

Reporter:: Philipp Imhof

Peer reviewer:: Andrew Gosali

Integrator:: Tim Hunt

Tester:: CiBoT

Participants:: Andrew Gosali, Andrew Lyons, CiBoT, Huong Nguyen, Philipp Imhof, Tim Hunt

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Created:: 27/Jan/25 9:50 PM

Updated:: 26/Mar/25 10:12 AM

Resolved:: 26/Mar/25 10:12 AM

Estimated:

Not Specified

Remaining:

Logged:

1h 15m

Details

Description

Attachments

Activity

People

Dates

Time Tracking

Clockify