Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.5.5, 5.0.1
Affects Version/s: 4.5.1, 5.0.1
Component/s: Authentication
Labels:

Affected Branches:
MOODLE_405_STABLE, MOODLE_500_STABLE
Fixed Branches:
MOODLE_405_STABLE, MOODLE_500_STABLE
Pull from Repository:
https://github.com/davewoloszyn/moodle.git
Pull 4.5 Branch:
~~MDL-84274~~-405
Pull 4.5 Diff URL:
https://github.com/davewoloszyn/moodle/compare/2ddab5548f...MDL-84274-405
Pull 5.0 Branch:
~~MDL-84274~~-500
Pull 5.0 Diff URL:
https://github.com/davewoloszyn/moodle/compare/ba42149eb1...MDL-84274-500
Pull Main Branch:
~~MDL-84274~~-main
Pull Main Diff URL:
https://github.com/davewoloszyn/moodle/compare/c576443111...MDL-84274-main
Testing Instructions:
Hide

There is some Behat test coverage, but I think this extra manual test is useful.

Set up MFA

Log in as admin

Go to Site admin -> Plugins -> Admin tools -> Multi factor authentication

Enable 'MFA plugin enabled' and save changes

Email factor should be enabled by default, but ensure that you have a way to receive MFA codes if ever you need to authenticate

Set up policies

Log in as admin

Go to Site admin -> Users -> Policy settings

Set 'Site policy handler' to 'Policies (tool_policy)' and save changes.

Go to Site admin -> Users -> Manage policies

Click 'New policy'

Set 'Policy status' to 'Active' and fill out all other required fields (leave other default settings) and save changes

Create a test user

Test 1 - Policy redirection fix

Log in with your test user

CONFIRM you see the policy acceptance page

Click the 'Next' button

Agree to the policy and click 'Next'

CONFIRM you see the MFA verification screen

Enter in the code

CONFIRM you are granted access to Moodle
Show
There is some Behat test coverage, but I think this extra manual test is useful. Set up MFA Log in as admin Go to Site admin -> Plugins -> Admin tools -> Multi factor authentication Enable 'MFA plugin enabled' and save changes Email factor should be enabled by default, but ensure that you have a way to receive MFA codes if ever you need to authenticate Set up policies Log in as admin Go to Site admin -> Users -> Policy settings Set 'Site policy handler' to 'Policies (tool_policy)' and save changes. Go to Site admin -> Users -> Manage policies Click 'New policy' Set 'Policy status' to 'Active' and fill out all other required fields (leave other default settings) and save changes Create a test user Test 1 - Policy redirection fix Log in with your test user CONFIRM you see the policy acceptance page Click the 'Next' button Agree to the policy and click 'Next' CONFIRM you see the MFA verification screen Enter in the code CONFIRM you are granted access to Moodle
Pre-check results:
Hide

Code verified against automated checks with warnings.

Checked ~~MDL-84274~~ using repository: https://github.com/davewoloszyn/moodle.git

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-84274-405 | CI Job]

main (0 errors / 1 warnings) [branch: MDL-84274-main | CI Job]

overview (0/1), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

Warn: The ~~MDL-84274~~-main branch at https://github.com/davewoloszyn/moodle.git has not been rebased recently (>20 days ago).

Should these errors be fixed?

Built on: Fri Mar 7 08:59:46 UTC 2025
Show
Code verified against automated checks with warnings. Checked MDL-84274 using repository: https://github.com/davewoloszyn/moodle.git MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-84274-405 | CI Job ] main (0 errors / 1 warnings) [branch: MDL-84274-main | CI Job ] overview (0/1) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Warn: The MDL-84274 -main branch at https://github.com/davewoloszyn/moodle.git has not been rebased recently (>20 days ago). Should these errors be fixed? Built on: Fri Mar 7 08:59:46 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-84274~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19114/ PHPUnit (sqlsrv / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65350/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65351/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65352/ Behat (Firefox - classic / complete)

Launching automatic jobs for branch ~~MDL-84274~~-500

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19115/ PHPUnit (sqlsrv / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65353/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65354/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65355/ Behat (Firefox - classic / complete)

Launching automatic jobs for branch ~~MDL-84274~~-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19116/ PHPUnit (sqlsrv / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65356/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65357/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65358/ Behat (Firefox - classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65359/ App tests (stable app version) / complete) --> unrelated

Built on: Thu Apr 24 02:30:53 UTC 2025
Show
Launching automatic jobs for branch MDL-84274 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19114/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65350/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65351/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65352/ Behat (Firefox - classic / complete) Launching automatic jobs for branch MDL-84274 -500 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19115/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65353/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65354/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65355/ Behat (Firefox - classic / complete) Launching automatic jobs for branch MDL-84274 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19116/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65356/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65357/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65358/ Behat (Firefox - classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65359/ App tests (stable app version) / complete) --> unrelated Built on: Thu Apr 24 02:30:53 UTC 2025

Story Points:
2
Sprint:
Team Hedgehogs 2025 Sprint 1.2, Team Hedgehogs 2025 Sprint 1.3, Team Hedgehogs 2025 Sprint 1.4, Team Hedgehogs 2025 Sprint 2.0, Team Hedgehogs 2025 Sprint 2.1

Hello,

we have an actual Moodle-site with LDAP-Login. Due to new security rules at our school, we activated MFA (Email, Passkey, Authenticator App). Everything worked fine and as expected.

But all new students and staff cannot login. There is an redirection error.

After investigating I found that the new users have one thing in common: They all haven't yet accepted the privacy agreement. I accepted it for them and now they can login.

Please see the attached files.

Greatings from Germany, Thorsten Butsch

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

Bildschirmfoto 2025-01-21 um 17.40.18.png
22/Jan/25 2:29 AM
57 kB
Thorsten Butsch
Bildschirmfoto 2025-01-21 um 17.55.05.png
22/Jan/25 2:29 AM
83 kB
Thorsten Butsch
Bildschirmfoto 2025-01-22 um 09.07.58.png
22/Jan/25 4:14 PM
356 kB
Thorsten Butsch
MDL-84274.png
21/May/25 3:58 PM
376 kB
Ron Carl Alfon Yu
Screen Shot 2025-02-25 at 3.34.30 pm.png
25/Feb/25 12:38 PM
109 kB
David Woloszyn

caused a regression

MDL-85719 MDL-84274 redefined meaning of 'secure' page layout without docs update

Open

Assignee:: David Woloszyn

Reporter:: Thorsten Butsch

Peer reviewer:: Raquel Ortega

Integrator:: Huong Nguyen

Tester:: Ron Carl Alfon Yu

Participants:: CiBoT, David Woloszyn, Edd Clementson, Huong Nguyen, Jun Pataleta, Raquel Ortega, Ron Carl Alfon Yu, Simey Lameze, Thorsten Butsch

Votes:: 0 Vote for this issue

Watchers:: 9 Start watching this issue

Created:: 22/Jan/25 2:29 AM

Updated:: 09/Jun/25 3:38 PM

Resolved:: 23/May/25 12:30 PM

Estimated:

Remaining:

Logged:

1d 3h 33m

Details

Set up MFA

Set up policies

Test 1 - Policy redirection fix

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify