Loading...

XML

Word

Printable

Type: Improvement
Resolution: Fixed
Priority: Minor
Fix Version/s: 5.0
Affects Version/s: 5.0
Component/s: Database activity module
Labels:
- ci
- release_notes
- triaged

Affected Branches:
MOODLE_500_STABLE
Fixed Branches:
MOODLE_500_STABLE
Epic Link:
5.0 deprecations
Pull from Repository:
https://github.com/paulholden/moodle.git
Pull Main Branch:
~~MDL-84267~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...paulholden:MDL-84267
Testing Instructions:
Hide

Execute the following:

$ git grep -C2 "mod/data:$comment\|managecomments$"

Confirm the only remaining references have been marked as deprecated in access.php and noted as such in upgradenotes
Show
Execute the following: $ git grep -C2 "mod/data:$comment\|managecomments$" Confirm the only remaining references have been marked as deprecated in access.php and noted as such in upgradenotes
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-84267~~ using repository: https://github.com/paulholden/moodle.git

main (0 errors / 0 warnings) [branch: MDL-84267 | CI Job]

_{More information about this report}

Built on: Thu Jan 23 05:36:14 PM UTC 2025
Show
Code verified against automated checks. Checked MDL-84267 using repository: https://github.com/paulholden/moodle.git main (0 errors / 0 warnings) [branch: MDL-84267 | CI Job ] More information about this report Built on: Thu Jan 23 05:36:14 PM UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-84267~~

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18058/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61691/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61692/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61693/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61694/ App tests (stable app version)

Built on: Thu Jan 23 06:25:15 PM UTC 2025
Show
Launching automatic jobs for branch MDL-84267 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18058/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61691/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61692/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61693/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61694/ App tests (stable app version) Built on: Thu Jan 23 06:25:15 PM UTC 2025

See following screenshot of module capabilities related to comments in a Database activity:

The latter two are unused, and their presence creates confusion due to duplication of the corresponding moodle/comment:* capabilities that are also listed (these capabilities work)

Both mod/data:comment and mod/data:managecomments have been unused since ~~MDL-20346~~ (15 years ago, specifically in these commits). We have a process for deprecating capabilities, use it here

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

Screenshot 2025-01-21 at 09-59-08 Permissions in Database MDL-52377 Mount Orange School.png
21/Jan/25 6:51 PM
71 kB
Paul Holden
(1) 2 Passed -- (Main)MDL-84267.png
04/Mar/25 2:12 PM
70 kB
Kim Jared Lucas

has a non-specific relationship to

MDL-77237 Debugging erroneously called during upgrade when cleaning up capabilities

Development in progress

has been marked as being related by

MDL-20346 comments api for database module

Closed

MDL-18079 Database module doesn't respect mod/data:comment capability when adding comments

Closed

MDL-55580 Process for deprecating a capability

Closed

is duplicated by

MDL-73096 Users can comment database activities if mod/data:comment set to Prohibit

Closed

mentioned in: Page Loading...

(1 mentioned in)

Assignee:: Paul Holden

Reporter:: Paul Holden

Peer reviewer:: Laurent David

Integrator:: Jun Pataleta

Tester:: Kim Jared Lucas

Participants:: CiBoT, Helen Foster, Jun Pataleta, Kim Jared Lucas, Laurent David, Paul Holden

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Created:: 21/Jan/25 6:46 PM

Updated:: 10/Jun/25 8:54 PM

Resolved:: 04/Mar/25 11:30 PM

Estimated:

Remaining:

Logged:

20m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify