Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 5.0
Affects Version/s: 5.0
Component/s: Questions
Labels:
- ci
- triaged

Affected Branches:
MOODLE_500_STABLE
Fixed Branches:
MOODLE_500_STABLE
Epic Link:
Quiz and Question bank in Moodle 5.0
Pull from Repository:
https://github.com/cwarwicker/moodle.git
Pull Main Branch:
~~MDL-84193~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...cwarwicker:moodle:MDL-84193
Testing Instructions:
Hide

Create a course

Create a question bank on the course (or use default one if it exists)

Create a question of any type

Edit the question so there is now a new version of it

Check the checkbox next to the question

Click the "With selected" button at the bottom

Confirm that you see both the options to Delete and Move to

Now click the question "Edit" action next to the question and choose "History"

Check the checkbox next to any of the question versions shown

Click the "With selected" button at the bottom

Confirm that you can still see the option to Delete but you cannot see the option to Move to
Show
Create a course Create a question bank on the course (or use default one if it exists) Create a question of any type Edit the question so there is now a new version of it Check the checkbox next to the question Click the "With selected" button at the bottom Confirm that you see both the options to Delete and Move to Now click the question "Edit" action next to the question and choose "History" Check the checkbox next to any of the question versions shown Click the "With selected" button at the bottom Confirm that you can still see the option to Delete but you cannot see the option to Move to
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-84193~~ using repository: https://github.com/cwarwicker/moodle.git

main (0 errors / 0 warnings) [branch: MDL-84193 | CI Job]

_{More information about this report}

Built on: Fri Jan 17 04:16:26 PM UTC 2025
Show
Code verified against automated checks. Checked MDL-84193 using repository: https://github.com/cwarwicker/moodle.git main (0 errors / 0 warnings) [branch: MDL-84193 | CI Job ] More information about this report Built on: Fri Jan 17 04:16:26 PM UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-84193~~

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17987/ PHPUnit (sqlsrv / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61433/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61434/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61435/ Behat (Firefox - classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61436/ App tests (stable app version) / complete)

Built on: Mon Jan 20 10:50:26 UTC 2025
Show
Launching automatic jobs for branch MDL-84193 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17987/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61433/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61434/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61435/ Behat (Firefox - classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61436/ App tests (stable app version) / complete) Built on: Mon Jan 20 10:50:26 UTC 2025

The think that belongs in a particular question category is a questoin bank entry, and then all versions of that question are in that category.

Therefore, it is misleading to users to have a bulk action for this on the question history view. Being able to select some, but not all versions, and then do With selected -> move to ... sends a false signal about how the system works.

(I think we can fix this by checking $qbank->is_listing_specific_versions in \qbank_bulkmove\plugin_feature::get_bulk_actions().)

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

MDL-84193.png
339 kB
22/Jan/25 4:25 PM

Discovered while testing

MDL-84117 Move question in history page (and other bulk actions with JS) causing url not found

Closed

Assignee:: CMR

Reporter:: Tim Hunt

Peer reviewer:: Mark Johnson

Integrator:: Tim Hunt

Tester:: Ron Carl Alfon Yu

Participants:: CiBoT, CMR, Huong Nguyen, Mark Johnson, Ron Carl Alfon Yu, Simey Lameze, Tim Hunt

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Created:: 13/Jan/25 8:06 PM

Updated:: 24/Jan/25 1:03 AM

Resolved:: 24/Jan/25 1:03 AM

Estimated:

Not Specified

Remaining:

Logged:

2h 29m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify