-
Bug
-
Resolution: Fixed
-
Minor
-
4.4 regressions, 4.4.5, 4.5.1
-
MOODLE_404_STABLE, MOODLE_405_STABLE
-
MOODLE_405_STABLE, MOODLE_500_STABLE
-
MDL-84192-405 -
MDL-84192-500 -
-
Code verified against automated checks with warnings.Checked
MDL-84192using repository: https://github.com/paulholden/moodle.git
MOODLE_405_STABLE (0 errors / 1 warnings) [branch: MDL-84192-405 | CI Job]
- MOODLE_500_STABLE (0 errors / 1 warnings) [branch: MDL-84192-500 | CI Job]
- main (0 errors / 1 warnings) [branch: MDL-84192 | CI Job]
Built on: Tue Apr 22 12:48:42 UTC 2025
Code verified against automated checks with warnings. Checked MDL-84192 using repository: https://github.com/paulholden/moodle.git MOODLE_405_STABLE (0 errors / 1 warnings) [branch: MDL-84192-405 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (0/1) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , MOODLE_500_STABLE (0 errors / 1 warnings) [branch: MDL-84192-500 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (0/1) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , main (0 errors / 1 warnings) [branch: MDL-84192 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (0/1) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Should these errors be fixed? Built on: Tue Apr 22 12:48:42 UTC 2025 -
While working on MDL-84139 I came over a method enrol_plugin::get_description_text() that was only overridden in enrol_fee and it was only used on course/info.php
So I looked further and found that:
- course/info.php is an ugly page that is hard to find (you have to have some strange combination of settings and course categories)
- it uses deprecated string 'summaryof', 'moodle'
- it calls method enrol_plugin::get_description_text() from all plugins and is only overridden in enrol_fee, the information from the callback is displayed ABOVE the course data
- in case of enrol_fee it displays the payment buttons that make the page even uglier. It may also be not relevant, if the user is already enrolled, for example
I suggest to:
- remove the method get_description_text() from enrol_fee plugin
- fix usage of deprecated string (un-deprecate or replace with another one)
- consider dropping course/info.php page completely (which means removing couple of methods from enrol api too)
- Discovered while testing
-
MDL-84139 Add an option to display title for the enrol_fee enrolment
-
- Closed
-
- has been marked as being related by
-
MDL-76565 Remove strings deprecated in Moodle versions <= 4.4
-
- Closed
-
- is a regression caused by
-
-
- Closed
-
- will be (partly) resolved by
-
-
- Closed
-
- mentioned in
-
Page Loading...
