Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-84142

Homogenise output of the enrolment methods on the course enrolment page

XMLWordPrintable

    • MOODLE_405_STABLE
    • MOODLE_500_STABLE
    • Hide

      Test 1 guest and self enrolment methods

      1. create a course and enable self enrolment method
      2. Go to the course as a user who is not enrolled in the course and make sure that you can enrol yourself into a course using self-enrolment
      3. Unenrol yourself from the course (so you can continue testing with the same user)
      4. As admin change self enrolment method to use a password
      5. Go to the course as a user who is not enrolled in the course and make sure that you can enrol yourself into a course using self-enrolment
      6. As admin change the self enrolment method to disable new enrolments
      7. As a user who is not enrolled go to the course page and make sure you see a warning
      8. Ad admin change the self enrolment method to enable enrolments and add a password
      9. Go to the course as a user who is not enrolled in the course and make sure that you can enrol yourself into a course using self-enrolment
      10. As a user who is logged in as a guest to to the course page and make sure that you see a button to login and if you press it you are redirected to login page
      11. as admin disable self-enrolment and enable guest enrolment with password
      12. As a user who is logged in as a guest or who is logged in but not enrolled in the course, go to the course page and make sure that you can enrol yourself using a password

      Test 2. Enrolment on payment and paypal

      1. Configure payment gateway (paypal) and payment account, see https://docs.moodle.org/405/en/Payment_gateways . See also https://docs.moodle.org/405/en/PayPal_enrolment and https://docs.moodle.org/dev/Setting_up_PayPal_development
      2. Enable enrolment plugins enrol_fee and enrol_paypal (Site administration>Plugins>Manage enrolment methods)
      3. Add an instance of the "Enrolment on payment" enrolment method to a course, configure it but leave the price as 0.
      4. As a user who is not enrolled go to the course page and make sure you see a warning on the enrolment page
      5. As admin edit the method and set the price
      6. As a user who is not enrolled in the course go to the course enrolment page and make sure you can enrol yourself
      7. Repeat the same with the paypal enrolment method
      Show
      Test 1 guest and self enrolment methods create a course and enable self enrolment method Go to the course as a user who is not enrolled in the course and make sure that you can enrol yourself into a course using self-enrolment Unenrol yourself from the course (so you can continue testing with the same user) As admin change self enrolment method to use a password Go to the course as a user who is not enrolled in the course and make sure that you can enrol yourself into a course using self-enrolment As admin change the self enrolment method to disable new enrolments As a user who is not enrolled go to the course page and make sure you see a warning Ad admin change the self enrolment method to enable enrolments and add a password Go to the course as a user who is not enrolled in the course and make sure that you can enrol yourself into a course using self-enrolment As a user who is logged in as a guest to to the course page and make sure that you see a button to login and if you press it you are redirected to login page as admin disable self-enrolment and enable guest enrolment with password As a user who is logged in as a guest or who is logged in but not enrolled in the course, go to the course page and make sure that you can enrol yourself using a password Test 2. Enrolment on payment and paypal Configure payment gateway (paypal) and payment account, see https://docs.moodle.org/405/en/Payment_gateways . See also https://docs.moodle.org/405/en/PayPal_enrolment and https://docs.moodle.org/dev/Setting_up_PayPal_development Enable enrolment plugins enrol_fee and enrol_paypal (Site administration>Plugins>Manage enrolment methods) Add an instance of the "Enrolment on payment" enrolment method to a course, configure it but leave the price as 0. As a user who is not enrolled go to the course page and make sure you see a warning on the enrolment page As admin edit the method and set the price As a user who is not enrolled in the course go to the course enrolment page and make sure you can enrol yourself Repeat the same with the paypal enrolment method
    • Hide

      Code verified against automated checks with warnings.

      Checked MDL-84142 using repository: https://github.com/marinaglancy/moodle

      Should these errors be fixed?

      Built on: Tue Mar 11 16:53:56 UTC 2025

      Show
      Code verified against automated checks with warnings. Checked MDL-84142 using repository: https://github.com/marinaglancy/moodle main (0 errors / 1 warnings) [branch: MDL-84142 | CI Job ] overview (0/1) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Warn: the branch is based off integration.git Should these errors be fixed? Built on: Tue Mar 11 16:53:56 UTC 2025
    • Show
      Launching automatic jobs for branch MDL-84142 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18522/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63442/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63443/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63444/ Behat (Firefox - classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63445/ App tests (stable app version) / complete) Built on: Tue Mar 11 16:37:09 UTC 2025
    • 2
    • WP Sprint 2025-I1.1 (Espresso), WP Sprint 2025-I1.2 (Espresso), WP Sprint 2025-I1.3 (Espresso)

      There are 4 enrolment methods in standard Moodle distribution that implement the method enrol_page_hook() and display enrolment options on the course enrolment page:

      • enrol_self - Self enrolment (with or without password)
      • enrol_guest - Guest enrolment (with or without password)
      • enrol_paypal - PayPal, half deprecated plugin using the old version of paypal api
      • enrol_fee - Enrolment on payment, that allows to connect with different payment systems, including PayPal (newer version of paypal api)

      Only the first two look similar, they both use moodleforms. The others look very inconsistent and use custom buttons that all look different and are in different locations. The headers are sometimes present, sometimes not and all have different styles.

      I already created a different issue MDL-84139 about allowing to display the enrol_fee instance name. We would like for all enrolment plugins to look similar and use similar templates or APIs.

        1. coreenrolplugins.png
          51 kB
          Marina Glancy
        2. enrol_apply.png
          44 kB
          Marina Glancy
        3. enrol_authorizedotnet.png
          63 kB
          Marina Glancy
        4. enrol_badgeenrol.png
          10 kB
          Marina Glancy
        5. enrol_credit.png
          14 kB
          Marina Glancy
        6. enrol_pagseguro.png
          24 kB
          Marina Glancy
        7. enrol_waitlist.png
          23 kB
          Marina Glancy
        8. enrol_wallet.png
          25 kB
          Marina Glancy
        9. e_m_then.png
          119 kB
          Rafael Lechugo
        10. modal.png
          258 kB
          Rafael Lechugo
        11. price_vs_cost.png
          35 kB
          Marina Glancy
        12. After.png
          10 kB
          Paul Holden
        13. Before.png
          10 kB
          Paul Holden
        14. (2) 4 Passed -- (Main)MDL-84142.png
          46 kB
          Kim Jared Lucas
        15. (2) 7 Passed -- (Main)MDL-84142.png
          60 kB
          Kim Jared Lucas
        16. (1) 12 Passed -- (Main)MDL-84142.png
          47 kB
          Kim Jared Lucas
        17. (1) 2 Passed -- (Main)MDL-84142.png
          50 kB
          Kim Jared Lucas
        18. (1) 5 Passed -- (Main)MDL-84142.png
          50 kB
          Kim Jared Lucas
        19. (1) 7 Passed -- (Main)MDL-84142.png
          29 kB
          Kim Jared Lucas
        20. (1) 9 Passed -- (Main)MDL-84142.png
          51 kB
          Kim Jared Lucas
        21. (1) 10 Passed -- (Main)MDL-84142.png
          333 kB
          Kim Jared Lucas

            marina Marina Glancy
            marina Marina Glancy
            David Carrillo David Carrillo
            Paul Holden Paul Holden
            Kim Jared Lucas Kim Jared Lucas
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 week, 1 hour, 27 minutes
                1w 1h 27m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.