Loading...

XML

Word

Printable

Type: Improvement
Resolution: Fixed
Priority: Minor
Fix Version/s: 5.0
Affects Version/s: 5.0
Component/s: Report builder
Labels:
- ci
- triaged

Affected Branches:
MOODLE_500_STABLE
Fixed Branches:
MOODLE_500_STABLE
Pull from Repository:
https://github.com/paulholden/moodle/
Pull Main Branch:
~~MDL-84135~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...paulholden:MDL-84135
Testing Instructions:
1. Covered by automated tests (PHPUnit)
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-84135~~ using repository: https://github.com/paulholden/moodle/

main (0 errors / 0 warnings) [branch: MDL-84135 | CI Job]

_{More information about this report}

Built on: Sun Jan 19 04:19:08 PM UTC 2025
Show
Code verified against automated checks. Checked MDL-84135 using repository: https://github.com/paulholden/moodle/ main (0 errors / 0 warnings) [branch: MDL-84135 | CI Job ] More information about this report Built on: Sun Jan 19 04:19:08 PM UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-84135~~

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17932/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61165/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61166/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61167/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61168/ App tests (stable app version)

Built on: Wed Jan 15 10:30:35 AM UTC 2025
Show
Launching automatic jobs for branch MDL-84135 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17932/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61165/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61166/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61167/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61168/ App tests (stable app version) Built on: Wed Jan 15 10:30:35 AM UTC 2025

This table name is not correct:

https://github.com/moodle/moodle/blob/ab5692acdf1f9a2b3cf06986f49b951558793f38/course/classes/reportbuilder/local/entities/completion.php#L51

As evidenced when it's used in a report source, and in XMLDB schema:

Now that we can deprecate table names in entities (since ~~MDL-78118~~), we should fix this so as to remove the element of surprise and support future work on table introspection once it's corrected

The deprecation of entity table names should support defining replacements. In this case from 'course_completion' to 'course_completions'

has been marked as being related by

MDL-78118 Final removal of custom report elements deprecated in 4.3

Closed

has to be done before

MDL-84713 Final removal of report entity deprecated table names

Open

Assignee:: Paul Holden

Reporter:: Paul Holden

Peer reviewer:: Carlos Castillo

Integrator:: David Carrillo

Tester:: CiBoT

Participants:: Andrew Lyons, Carlos Castillo, CiBoT, David Carrillo, Jun Pataleta, Paul Holden

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Created:: 09/Jan/25 6:46 PM

Updated:: 08/Mar/25 12:17 PM

Resolved:: 08/Mar/25 12:17 PM

Estimated:

Not Specified

Remaining:

Logged:

2h 23m

Details

Description

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify