Test 1 - No error after upgrading from main

1. In a Moodle site without the patch (for instance, you can run git checkout 89d76fdc25ead41d29253972c45268a21dae7633), copy the addoldindicators.phpin your current installation.
2. Run :

   php addoldindicators.php

3. Login as admin.
4. Go to Site administration > Advanced feature, enable Analytics and Save changes.
5. Go to Site administration > Analytics > Analytics models (admin/tool/analytics/index.php)
6. Check that there is a debug message
7. Change your site to use this patch.
8. Update the site (php admin/cli/upgrade.php)
9. Check the page again and ensure there is no warning related to missing indicators for chat and survey

Test 2 - Upgrading from a version with core chat and survey

1. Create a new 4.4 Moodle version
2. Import the model attached to this ticket twice 
3. Edit one of the imported model so to add an indicator that is not related to chat and survey
4. Log in as admin and activate DEVELOPER debugging level in Site administration > Development > Debugging
5. Navigate to Site administration > Analytics > Analytics models
6. Confirm there are no debug messages.
7. Change your site to use this patch.
8. Navigate to Site administration > Analytics > Analytics models
9. Confirm there are no debug messages.
10. Confirm: on the two imported indicator, one has one indicator left and the other one 0 (because it was all chat and survey related)

Code verified against automated checks.

Checked MDL-84131 using repository: https://github.com/laurentdavid/moodle.git

• main (0 errors / 0 warnings) [branch: MDL-84131-main | CI Job]

_{More information about this report}

Built on: Mon Mar 24 15:51:16 UTC 2025

Launching automatic jobs for branch MDL-84131-main

• https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18723/ PHPUnit (sqlsrv)
• https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64142/ Behat (NonJS - boost and classic)
• https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64144/ Behat (Firefox - boost)
• https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64146/ Behat (Firefox - classic)
• https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64147/ App tests (stable app version)

Built on: Thu Mar 20 12:31:59 UTC 2025