Loading...

XML

Word

Printable

Type: Improvement
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.4.8, 4.5.4
Affects Version/s: 4.4 regressions, 4.5 regressions
Component/s: BigBlueButton
Labels:

Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Pull from Repository:
https://github.com/praxisdigital/moodle
Pull 4.4 Branch:
~~MDL-84112~~-MOODLE_404_STABLE-fix_bigbluebutton_defaultcompletion_performance
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/cbd60e5a9bdbdf222c0b8ae691cceebe247f18eb...praxisdigital:moodle:MDL-84112-MOODLE_404_STABLE-fix_bigbluebutton_defaultcompletion_performance?expand=1
Pull 4.5 Branch:
~~MDL-84112~~-MOODLE_405_STABLE-fix_bigbluebutton_defaultcompletion_performance
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/b3931cdb959b928eefa72cd5638c3a89d221828f...praxisdigital:moodle:MDL-84112-MOODLE_405_STABLE-fix_bigbluebutton_defaultcompletion_performance?expand=1
Pull Main Branch:
~~MDL-84112~~-main-fix_bigbluebutton_defaultcompletion_performance
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/8f89677192a80aaed64da2ff196ce3528f1a3105...praxisdigital:moodle:MDL-84112-main-fix_bigbluebutton_defaultcompletion_performance?expand=1
Testing Instructions:
Hide

Initial setup:

Login as admin

Navigate to Site Admin > Plugins > Manage activities

Click Settings for BigBlueButton.

Enter the server URL and shared secret.

Save changes.

Enable that activity.

Before patch

Use mdk to create the site (mdk create -i -s 84112 -r dev)

Set your memory settings low

Create a lot of users
php admin/tool/generator/cli/maketestcourse.php --size=L --shortname=C1

Click on 'Site administration'

Click on the 'courses' tab

Click on 'Default activity completion' under the 'Default settings' heading

Confirm that a Fatal error occurs

After patch

Use mdk to create the site (mdk create -i -s 84112 -r dev)

Set your memory settings low

Create a lot of users
php admin/tool/generator/cli/maketestcourse.php --size=L --shortname=C1

Click on 'Site administration'

Click on the 'courses' tab

Click on 'Default activity completion' under the 'Default settings' heading

Confirm that the page is now accessible
Show
Initial setup: Login as admin Navigate to Site Admin > Plugins > Manage activities Click Settings for BigBlueButton. Enter the server URL and shared secret. Save changes. Enable that activity. Before patch Use mdk to create the site (mdk create -i -s 84112 -r dev) Set your memory settings low Create a lot of users php admin/tool/generator/cli/maketestcourse.php --size=L --shortname=C1 Click on ' Site administration ' Click on the ' courses ' tab Click on ' Default activity completion ' under the ' Default settings ' heading Confirm that a Fatal error occurs After patch Use mdk to create the site (mdk create -i -s 84112 -r dev) Set your memory settings low Create a lot of users php admin/tool/generator/cli/maketestcourse.php --size=L --shortname=C1 Click on ' Site administration ' Click on the ' courses ' tab Click on ' Default activity completion ' under the ' Default settings ' heading Confirm that the page is now accessible
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-84112~~ using repository: https://github.com/praxisdigital/moodle

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-84112-MOODLE_404_STABLE-fix_bigbluebutton_defaultcompletion_performance | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-84112-MOODLE_405_STABLE-fix_bigbluebutton_defaultcompletion_performance | CI Job]

main (0 errors / 0 warnings) [branch: MDL-84112-main-fix_bigbluebutton_defaultcompletion_performance | CI Job]

_{More information about this report}

Built on: Tue Mar 18 10:39:46 UTC 2025
Show
Code verified against automated checks. Checked MDL-84112 using repository: https://github.com/praxisdigital/moodle MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-84112-MOODLE_404_STABLE-fix_bigbluebutton_defaultcompletion_performance | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-84112-MOODLE_405_STABLE-fix_bigbluebutton_defaultcompletion_performance | CI Job ] main (0 errors / 0 warnings) [branch: MDL-84112-main-fix_bigbluebutton_defaultcompletion_performance | CI Job ] More information about this report Built on: Tue Mar 18 10:39:46 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-84112~~-MOODLE_404_STABLE-fix_bigbluebutton_defaultcompletion_performance

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18717/ PHPUnit (sqlsrv / --testsuite mod_bigbluebuttonbn_testsuite)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64124/ Behat (NonJS - boost and classic / --tags @mod_bigbluebuttonbn)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64125/ Behat (Firefox - boost / --tags @mod_bigbluebuttonbn)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64126/ Behat (Firefox - classic / --tags @mod_bigbluebuttonbn)

Launching automatic jobs for branch ~~MDL-84112~~-MOODLE_405_STABLE-fix_bigbluebutton_defaultcompletion_performance

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18718/ PHPUnit (sqlsrv / --testsuite mod_bigbluebuttonbn_testsuite)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64127/ Behat (NonJS - boost and classic / --tags @mod_bigbluebuttonbn)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64128/ Behat (Firefox - boost / --tags @mod_bigbluebuttonbn)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64129/ Behat (Firefox - classic / --tags @mod_bigbluebuttonbn)

Launching automatic jobs for branch ~~MDL-84112~~-main-fix_bigbluebutton_defaultcompletion_performance

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18719/ PHPUnit (sqlsrv / --testsuite mod_bigbluebuttonbn_testsuite)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64130/ Behat (NonJS - boost and classic / --tags @mod_bigbluebuttonbn)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64131/ Behat (Firefox - boost / --tags @mod_bigbluebuttonbn)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64132/ Behat (Firefox - classic / --tags @mod_bigbluebuttonbn)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64133/ App tests (stable app version) / --tags @mod_bigbluebuttonbn)

Built on: Thu Mar 20 12:14:12 UTC 2025
Show
Launching automatic jobs for branch MDL-84112 -MOODLE_404_STABLE-fix_bigbluebutton_defaultcompletion_performance https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18717/ PHPUnit (sqlsrv / --testsuite mod_bigbluebuttonbn_testsuite) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64124/ Behat (NonJS - boost and classic / --tags @mod_bigbluebuttonbn) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64125/ Behat (Firefox - boost / --tags @mod_bigbluebuttonbn) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64126/ Behat (Firefox - classic / --tags @mod_bigbluebuttonbn) Launching automatic jobs for branch MDL-84112 -MOODLE_405_STABLE-fix_bigbluebutton_defaultcompletion_performance https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18718/ PHPUnit (sqlsrv / --testsuite mod_bigbluebuttonbn_testsuite) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64127/ Behat (NonJS - boost and classic / --tags @mod_bigbluebuttonbn) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64128/ Behat (Firefox - boost / --tags @mod_bigbluebuttonbn) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64129/ Behat (Firefox - classic / --tags @mod_bigbluebuttonbn) Launching automatic jobs for branch MDL-84112 -main-fix_bigbluebutton_defaultcompletion_performance https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18719/ PHPUnit (sqlsrv / --testsuite mod_bigbluebuttonbn_testsuite) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64130/ Behat (NonJS - boost and classic / --tags @mod_bigbluebuttonbn) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64131/ Behat (Firefox - boost / --tags @mod_bigbluebuttonbn) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64132/ Behat (Firefox - classic / --tags @mod_bigbluebuttonbn) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64133/ App tests (stable app version) / --tags @mod_bigbluebuttonbn) Built on: Thu Mar 20 12:14:12 UTC 2025

Whenever you have a site with a lot of users, and you want to set a default activity completion on the site. Then it breaks because of the massive load time and missing memory.

This is because of Bigbluebutton's mod_form class, definition() method.

It creates a hidden html element and adds participant data, for the JavaScript to find, whenever you normally edit a bigbluebutton activity. Which is not needed in the defaultcompletion view.

If it's possible for any tester to create hundreds of thousands of users.. Then the test scenario is as follows:

Ensure your site has a lot of users (In our case; 400.000)
Click on 'Site administration'
Click on the 'courses' tab
Click on 'Default activity completion' under the 'Default settings' heading
Confirm that a Fatal error occurs

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

bbb1.png
183 kB
07/Jan/25 10:40 PM
bbb2.png
259 kB
07/Jan/25 10:40 PM
before_patch.png
47 kB
25/Mar/25 5:16 PM
image-2025-03-21-08-23-26-034.png
28 kB
21/Mar/25 3:23 PM
MDL-84112.png
98 kB
25/Mar/25 5:18 PM
site.png
350 kB
07/Jan/25 10:40 PM

has been marked as being related by

MDL-79105 Improve Big Blue Button activity completion form

Open

Assignee:: Anders Rasmussen

Reporter:: Anders Rasmussen

Peer reviewer:: Tue Korsgaard

Integrator:: Laurent David

Tester:: Ron Carl Alfon Yu

Participants:: Amaia Anabitarte, Anders Rasmussen, Andrew Lyons, CiBoT, Fred Dixon, Huong Nguyen, Laurent David, Ron Carl Alfon Yu, Tue Korsgaard

Votes:: 0 Vote for this issue

Watchers:: 9 Start watching this issue

Created:: 07/Jan/25 10:26 PM

Updated:: 11/Apr/25 3:41 PM

Resolved:: 26/Mar/25 10:12 AM

Estimated:

Not Specified

Remaining:

Logged:

3d 3h 35m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify