Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.5.2
Affects Version/s: 4.5
Component/s: Authentication
Labels:
- CatalystIT
- ci
- hqteam_hedgehog
- partner
- triaged

Affected Branches:
MOODLE_405_STABLE
Fixed Branches:
MOODLE_405_STABLE
Pull from Repository:
https://github.com/brendanheywood/moodle
Pull 4.5 Branch:
~~MDL-84079~~-kill-all-MOODLE_405_STABLE
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...brendanheywood:MDL-84079-kill-all-MOODLE_405_STABLE
Pull Main Branch:
~~MDL-84079~~-kill-all
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...brendanheywood:moodle:MDL-84079-kill-all
Testing Instructions:
1. Make sure debugging is on
2. Login as anyone
3. On the cli run php admin/cli/kill_all_sessions.php
4. Confirm you do not get a deprecation warning
5. Confirm you are logged out
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-84079~~ using repository: https://github.com/brendanheywood/moodle

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-84079-kill-all-MOODLE_405_STABLE | CI Job]

main (0 errors / 0 warnings) [branch: MDL-84079-kill-all | CI Job]

_{More information about this report}

Built on: Thu Jan 2 04:17:23 AM UTC 2025
Show
Code verified against automated checks. Checked MDL-84079 using repository: https://github.com/brendanheywood/moodle MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-84079-kill-all-MOODLE_405_STABLE | CI Job ] main (0 errors / 0 warnings) [branch: MDL-84079-kill-all | CI Job ] More information about this report Built on: Thu Jan 2 04:17:23 AM UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-84079~~-kill-all-MOODLE_405_STABLE

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17797/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60614/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60615/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-84079~~-kill-all

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17798/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60616/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60617/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60618/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60619/ App tests (stable app version)

Built on: Thu Jan 2 04:25:18 AM UTC 2025
Show
Launching automatic jobs for branch MDL-84079 -kill-all-MOODLE_405_STABLE https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17797/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60614/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60615/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-84079 -kill-all https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17798/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60616/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60617/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60618/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60619/ App tests (stable app version) Built on: Thu Jan 2 04:25:18 AM UTC 2025

Since ~~MDL-66151~~ landed, this cli now produces a deprecation warning:

php admin/cli/kill_all_sessions.php

++ Deprecation: core\session\manager::kill_all_sessions has been deprecated since 4.5. Use destroy_all instead. ++

* line 255 of /lib/classes/deprecation.php: call to debugging()

* line 136 of /lib/classes/deprecation.php: call to core\deprecation::emit_deprecation_notice()

* line 900 of /lib/classes/session/manager.php: call to core\deprecation::emit_deprecation_if_present()

* line 53 of /admin/cli/kill_all_sessions.php: call to core\session\manager::kill_all_sessions()

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

(1) 4 Passed -- (Main)MDL-84079.png
104 kB
08/Jan/25 3:49 PM
(1) 5 Passed -- (Main)MDL-84079.png
111 kB
08/Jan/25 3:49 PM

is a regression caused by

MDL-66151 Performance: Allow session stores to fully manage the session

Closed

Assignee:: Brendan Heywood

Reporter:: Brendan Heywood

Peer reviewer:: Benjamin Walker

Integrator:: Safat Shahin

Tester:: Kim Jared Lucas

Participants:: Benjamin Walker, Brendan Heywood, CiBoT, Jun Pataleta, Kim Jared Lucas, Safat Shahin

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Created:: 02/Jan/25 11:56 AM

Updated:: 09/Jan/25 10:38 PM

Resolved:: 09/Jan/25 10:38 PM

Estimated:

Not Specified

Remaining:

Logged:

20m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify